From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KAX4Ft9GXGEOggEAgWs5BA (envelope-from ) for ; Tue, 05 Oct 2021 14:36:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +CqOEt9GXGFdfQAAbx9fmQ (envelope-from ) for ; Tue, 05 Oct 2021 12:36:47 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C250617661 for ; Tue, 5 Oct 2021 14:36:46 +0200 (CEST) Received: from localhost ([::1]:36422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXjgb-0004xU-SB for larch@yhetil.org; Tue, 05 Oct 2021 08:36:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXjfu-0003tR-LH for guix-patches@gnu.org; Tue, 05 Oct 2021 08:36:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXjfu-0008H0-Ai for guix-patches@gnu.org; Tue, 05 Oct 2021 08:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mXjfu-0006z0-6j for guix-patches@gnu.org; Tue, 05 Oct 2021 08:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50844] [PATCH] Update vim to v8.2.3455 Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Oct 2021 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50844 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Steve George Cc: 50844@debbugs.gnu.org, Tobias Geerinckx-Rice Received: via spool by 50844-submit@debbugs.gnu.org id=B50844.163343735626828 (code B ref 50844); Tue, 05 Oct 2021 12:36:02 +0000 Received: (at 50844) by debbugs.gnu.org; 5 Oct 2021 12:35:56 +0000 Received: from localhost ([127.0.0.1]:39293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXjfo-0006ye-3i for submit@debbugs.gnu.org; Tue, 05 Oct 2021 08:35:56 -0400 Received: from flashner.co.il ([178.62.234.194]:37268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXjfl-0006yN-Hz for 50844@debbugs.gnu.org; Tue, 05 Oct 2021 08:35:54 -0400 Received: from localhost (unknown [141.226.169.107]) by flashner.co.il (Postfix) with ESMTPSA id CB95140085; Tue, 5 Oct 2021 12:35:46 +0000 (UTC) Date: Tue, 5 Oct 2021 15:33:05 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Steve George , Tobias Geerinckx-Rice , 50844@debbugs.gnu.org References: <20210927083219.2256220-1-steve@futurile.net> <87h7dydrsf.fsf@nckx> <54cd6313-0c58-6f91-d521-27cad80d9fff@futurile.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="llEStcd5QCK6fYhY" Content-Disposition: inline In-Reply-To: <54cd6313-0c58-6f91-d521-27cad80d9fff@futurile.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633437406; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Zqva71pjMIvUpN7jGwitOSIqyyYfySgs8SeTCxeFN5Q=; b=PvTBNz2l5Tg4FKOsZ7tlpELjSGg6WryevQ5oCVldqkEqAezneOV1PoPwchI9TvuaxQwIY2 TOXDE+kqIcZdmj5kaXCB7qEDiKtTMUYUxPtbnQ+fvUXif5vzzRCEJT3XvqZfxWRLiUZyCZ 9cQQOwtDvdc2gzz806wdSKG1qLeTJlkOkI/04oQyl6+MnKbbPQ7SHwv4rVU8GK8XUEcXho cHON8bLmvNp6yejD5O4n3W2ZwDyvtI2v9fBzEkejjUA5C/DRnrVksE5UKhPwQe5Yy9VV/w Mgr4ns1uObRHfp3jlvCsQwcPCa7M1xFN1KrBWvTKUp/SDqsid/eHn+PxlTg5jg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633437406; a=rsa-sha256; cv=none; b=gTvrAjOmu2aSrNpAErgRYVLLG3/vZFdgxVSMW85eDAJwScM01C025QPKl9/CIgFuU3Emda kmsZAiMqC3csj1NCulZOknVeC+nyaFjD7u1/xJ0wGye/5UWeBokqvq4SUPjjjOUoF0NgXS C8cKRfJnwiTcn3YcQ/1CUZDDBLNGlp/t2FEaECV8yPBFGhpR0MndLp1TsTyBELN/ienm9S tWf3b+ZG2PedT6YDKAWB4xh51R1eHcqK1cqrCUyhV0kAYzwhnprXP4yPi2JtELaBd56ps4 cR9OWg4NiGHQskr9hESt4salNI6fI0WoBfSqn9sYDH5z3vnUbFfHIIu/eBbpUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -4.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C250617661 X-Spam-Score: -4.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: 6wxeISPlAkC1 --llEStcd5QCK6fYhY Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 05, 2021 at 12:25:34PM +0100, Steve George wrote: > Hi Tobias/Efraim, >=20 > Apologies for the delay, this is my first attempt at a contribution and I= 've > been learning/struggling with my set-ups repeatability. >=20 > The Test_shellxquote (from test_shell.vim) test fails for me consistently > after patch 3061. >=20 > I can get the current version in Guix to build fine: >=20 > guix environment guix --pure > ./pre-inst-env guix environment vim >=20 > ./pre-inst-env guix build vim --no-substitutes --verbosity=3D3 --keep-f= ailed > 2>&1 | tee ../8.2.2689-vim-build.log >=20 > In 3061 > (https://github.com/vim/vim/commit/054794c20f6322bbd9482c4124041dc0a140c7= 8e) > the shell tests were changed. This build fails for me: >=20 > ./pre-inst-env guix build vim --no-substitutes --verbosity=3D3 > --with-git-url=3Dvim=3Dhttps://github.com/vim/vim --with-commit=3Dvim=3Dv= 8.2.3061 > --keep-failed 2>&1 | tee ../8.2.3061-git-vim-build.log >=20 > Failures: > From test_shell.vim: > Found errors in Test_shellxquote(): > Caught exception in Test_shellxquote(): Vim(call):E484: Can't open > file Xlog @ command line..script /tmp/guix-build-vim-8.2.3477.drv-0/sourc= e/src/testdir/runtest.vim[486]..function > RunTheTest[44]..Test_shellxquote, line 13 >=20 > In the tests log it says: >=20 > Cannot execute shell ./Xtestshell >=20 > The issue appears to be that if the Xtestshell file is there already then= it > fails. >=20 > I can build it fine manually: >=20 > guix environment guix --pure > ./pre-inst-env guix environment vim --ad-hoc less > cd > source ./environment-variables > cd src/testdir > mv Xtestshell Xtestshell.bak > make >=20 > That's as far as I've got at this point. >=20 > Are either of you able to confirm that you can: >=20 > a. Build versions before 3061 (ie 3060) >=20 > b. That with 3061 if you move Xtestshell it builds >=20 > c. Suggest any paths from here? >=20 >=20 > Thanks, >=20 > Steve >=20 =2E/pre-inst-env guix build --no-grafts --no-substitutes vim --with-commit= =3Dvim=3Dv8.2.3060 worked for me on the machines I was able to test it on. (ins)efraim@3900XT ~$ cat /tmp/guix-build-vim-8.2.3061.drv-0/source/src/tes= tdir/Xtestshell #!/bin/sh echo "Cmd: [$*]" > Xlog After adding 'testdir/test_shell.vim' to the '/bin/sh' substitution in the 'patch-absolute-paths phase I was able to build 8.2.3061. I'd go ahead and make that change in the substitution and if that fixes the version you sent then either resend that patch with the change or try bumping vim to a later version. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --llEStcd5QCK6fYhY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmFcRf4ACgkQQarn3Mo9 g1G4lw//QtGmobVyFigRpJmoFrtgD+S8gvb/L+9ockVbC1n/zUFEXq1ULPX+oIJn kxiQyiIho0AXaqfyvC7xE8BgfaqcAv9omxclHJ40gahNykhdE3qsHwpjh0pBfru8 zf/1hAPlgipKxxU1nNJpBfTCPPbHvAfNei7eS3mTQ1qXKfl4H1knXRPoUUBffaeb oDzcvToGBdVBMQI71m1/bm/QZTlGmbWqromq50uWw99XWZoqB/nV9AmaNlZYHkZ7 D/JoxC/tYDDa7syLm93pVm8z6+RsNCq/PvTE0yk08dzuBjotW6qzTKbNEZNxbSJe irQMA/foR1cad3UxFlvqdUHOerHGaVodyR38FweAY/FdWNA3YVhi+Xllvf7Cmsh2 Hz5p0S92EMx2zsbCIcO/rrV1wRh4mGDXjuufF/tCNbMh8uTrwmnvjsreJqyfo5Is 8mYbHlzY1fkFMJwJYI3q5Et+aG3PsCmlzNJYnM9pODSj/KbtfrtvXKQGLS/+ZPeQ V5uhfPntDGvARotf2jBicJ1WwA/zheJ8xbkF7KsRZJO63JJrAdezNwXUMUb9kW8b 5fYR8e+i81MlmatXRMNMJgKk8LLSqcL781OhI+AajdfKikrXN6vYD5CvH6frAK79 Gm7cA/q8H9n+9DNc7Q3ZLMlrRoZBc06SemU6IXe1kgv3Fv3Twm4= =02s3 -----END PGP SIGNATURE----- --llEStcd5QCK6fYhY--