From: Ivan Gankevich <i.gankevich@spbu.ru>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 49713@debbugs.gnu.org
Subject: [bug#49713] [PATCH 2/3] gnu: Add libigl.
Date: Sun, 19 Sep 2021 23:18:54 +0300 [thread overview]
Message-ID: <YUebLuVBESs1mTHU@gust> (raw)
In-Reply-To: <60123c258c4a361fec28fb13fed0cde7efa09fa0.camel@gmail.com>
>Can we provide test data as input?
I’ve added test data and enabled tests.
>> + "-DLIBIGL_BUILD_TUTORIALS=OFF"
>> + "-DLIBIGL_EXPORT_TARGETS=ON"
>> + "-DLIBIGL_WITH_CGAL=ON"
>> + "-DLIBIGL_WITH_COMISO=OFF"
>> + "-DLIBIGL_WITH_CORK=OFF"
>> + "-DLIBIGL_WITH_EMBREE=OFF"
>> + "-DLIBIGL_WITH_MATLAB=OFF"
>> + "-DLIBIGL_WITH_MOSEK=OFF"
>> + "-DLIBIGL_WITH_OPENGL=OFF"
>> + "-DLIBIGL_WITH_OPENGL_GLFW=OFF"
>> + "-DLIBIGL_WITH_OPENGL_GLFW_IMGUI=OFF"
>> + "-DLIBIGL_WITH_PNG=OFF"
>> + "-DLIBIGL_WITH_TETGEN=OFF"
>> + "-DLIBIGL_WITH_TRIANGLE=OFF"
>> + "-DLIBIGL_WITH_PREDICATES=OFF"
>> + "-DLIBIGL_WITH_XML=OFF")
>In Guix we prefer to build packages as feature-complete as possible.
>Obviously MATLAB won't work unless they also accept octave, but you
>might want to at least enable some of the low-hanging fruits such as
>XML or OpenGL. If it's about having a minimal package, simply provide
>a -minimal variant as well.
This library is header-only. All the dependencies from this list are used in the
tests. Headers that use these dependencies are installed no matter which
dependenies are “ON” in this list. I’ve added XML. Adding other dependencies
would require rewriting most of “cmake/libigl.cmake” file, because the
authors of the package like to download and build all the dependencies manually.
>> + #:tests? #f
>Don't leave #:tests? #f uncommented.
Enabled tests.
>> + (description "The library provides functionality for shape
>> modelling,
>> +visualization, matrix manipulation.")
>s/The/This/ ?
Fixed!
Thanks for your corrections. I’ve sent the updated version of this patch via
“git send-email”.
Regards,
Ivan
next prev parent reply other threads:[~2021-09-19 20:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 21:00 [bug#49713] [PATCH 1/3] gnu: cereal: Use cmake to build and install the library Ivan Gankevich
2021-07-23 21:07 ` [bug#49713] [PATCH 2/3] gnu: Add libigl Ivan Gankevich
2021-09-18 17:17 ` Liliana Marie Prikler
2021-09-19 20:18 ` Ivan Gankevich [this message]
2021-07-23 21:08 ` [bug#49713] [PATCH 3/3] gnu: Add prusa-slicer Ivan Gankevich
2021-09-18 17:26 ` Liliana Marie Prikler
2021-09-19 21:39 ` Ivan Gankevich
2021-09-19 21:53 ` Liliana Marie Prikler
2021-09-20 22:17 ` Ivan Gankevich
2021-09-21 12:12 ` bug#49713: " Liliana Marie Prikler
2021-09-18 15:53 ` [bug#49713] Patches work, how to upstream them phodina via Guix-patches via
2021-09-18 17:13 ` [bug#49713] [PATCH 1/3] gnu: cereal: Use cmake to build and install the library Liliana Marie Prikler
2021-09-19 18:27 ` Ivan Gankevich
2021-09-19 18:26 ` [bug#49713] [PATCH 1/3 v2] " Ivan Gankevich
2021-09-19 20:18 ` [bug#49713] [PATCH 2/3 v2] gnu: Add libigl Ivan Gankevich
2021-09-19 21:38 ` [bug#49713] [PATCH 3/3 v2] gnu: Add prusa-slicer Ivan Gankevich
2021-09-20 22:15 ` [bug#49713] [PATCH v3 1/3] gnu: cereal: Use cmake to build and install the library Ivan Gankevich
2021-09-20 22:15 ` [bug#49713] [PATCH v3 2/3] gnu: Add libigl Ivan Gankevich
2021-09-20 22:15 ` [bug#49713] [PATCH v3 3/3] gnu: Add prusa-slicer Ivan Gankevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUebLuVBESs1mTHU@gust \
--to=i.gankevich@spbu.ru \
--cc=49713@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.