From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0OtQFtWMOmF9YgEAgWs5BA (envelope-from ) for ; Fri, 10 Sep 2021 00:38:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MKJIEtWMOmFHEwAA1q6Kng (envelope-from ) for ; Thu, 09 Sep 2021 22:38:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 246251F217 for ; Fri, 10 Sep 2021 00:38:13 +0200 (CEST) Received: from localhost ([::1]:36626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOSgO-00042V-50 for larch@yhetil.org; Thu, 09 Sep 2021 18:38:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOSgE-00042F-QY for bug-guix@gnu.org; Thu, 09 Sep 2021 18:38:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOSgE-0000Af-J3 for bug-guix@gnu.org; Thu, 09 Sep 2021 18:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOSgE-00024k-El for bug-guix@gnu.org; Thu, 09 Sep 2021 18:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50493: Update go-build-system to use Go 1.17. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 09 Sep 2021 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50493 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Sarah Morgensen Received: via spool by 50493-submit@debbugs.gnu.org id=B50493.16312270717955 (code B ref 50493); Thu, 09 Sep 2021 22:38:02 +0000 Received: (at 50493) by debbugs.gnu.org; 9 Sep 2021 22:37:51 +0000 Received: from localhost ([127.0.0.1]:36410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOSg3-00024F-EV for submit@debbugs.gnu.org; Thu, 09 Sep 2021 18:37:51 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOSg1-00023v-I8 for 50493@debbugs.gnu.org; Thu, 09 Sep 2021 18:37:50 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DA3A05C006D; Thu, 9 Sep 2021 18:37:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 09 Sep 2021 18:37:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=GrMUsP1OEHuR4em7TzDSWHJl bmte+Id5jZjahvlZ7CY=; b=a4DkSSG13RxDwfOItE/GIockKTarz9fuInPQgXe3 DPN/W9A/c9jZAbVrdvd6nkmmY/i8FzjamxoAzl4atEgqcm9/zUoq1Z7ElxSF7uCl cJEUi7uPPP7fbJaj58VIHrkSvIi2W1CnO6dKG/a22yel0resxGwkBK4OEgBReTMt zz4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=GrMUsP 1OEHuR4em7TzDSWHJlbmte+Id5jZjahvlZ7CY=; b=L9yqjwLcfETKwRyFkXrb69 wntb34A6PJC4vGK60nLUI617N8tg0FAoTHmJS205nP7YMeaRGiOM7J3Q2Hx+w60+ 7+bsZ6nA0STUjrZBnKcbI1zr2g12C3YTqjULhk+A6PtY6cfF8wG3ZXxMTh5w43k3 o9HZw38Rg4ywLkkqxDMNT0dIVebC2cLfW7efrgopeWWTSy5HJIe6o2L4TLb2X1Yb vaUtEhqC/3N2+49HPnnP31jZi7M6p9DnV2sHPkPHhmHNso30pMeX1IdjI/Qb9IJn tY4+KZ86cqlEQqxjACGzfluobAKnLr5Lx/WYykp33pjGsnYD0Lpsdpb6eEdqJ7Zw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudegtddgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhephefgleevhfdttdefheeitdfgheffff ffledvlefhgfektdethefguefgheegtefhnecuffhomhgrihhnpehgihhthhhusgdrtgho mhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Sep 2021 18:37:43 -0400 (EDT) Date: Thu, 9 Sep 2021 18:37:37 -0400 From: Leo Famulari Message-ID: References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <865yv9mm5a.fsf@mgsn.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 50493@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 246251F217 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: H6CFrgd1mDIi On Thu, Sep 09, 2021 at 03:14:57PM -0700, Sarah Morgensen wrote: > This is intended to be a tracking issue for updating go-build-system to > use Go 1.17 by default. The build system currently uses Go 1.14, which > no longer receives security updates [0]. Thanks for putting this together. > Here's what needs to be done: > > 1. Address the aarch64 bug [1], either by verifying that it only happens > on emulated systems, or by fixing it if not. It looks like there was a patch for this issue: https://github.com/golang/go/issues/20763#issuecomment-314627882 And it was apparently added to Go, but maybe it was not sufficient, did not make it into a release, or we are seeing a different bug. > 2. Make some much-needed improvements to go-build-system [2]: > > * replace the *slow* phase 'remove-go-references with -trimpath option > > * avoid building a directory union of Go inputs (and then copying it!) Are these required to use 1.17? I agree they are important problems to fix but we shouldn't let them block the upgrade. > * add a "go-std-cache-for-build" package (hidden; name to be > bikeshedded), which will be an implicit input in go-build-system (needed > since we removed the pre-built standard library in go-1.17) Okay. Feel free to choose the name. I think it's your shed. > 3. Some/all Docker packages still require Go 1.14; make them use go-1.14 > explicitly. Alternatively, update Docker (significant effort involved). Okay. > 4. Update or patch broken packages. I've got patches for four so far: > > go-github-com-urfave-cli > go-github-com-urfave-cli-v2 > go-github-com-sevlyar-go-daemon > go-github-com-keybase-go-ps > > I'll submit them as a separate patch and block this with it. If anyone > else would like to see if their favorite package works with Go 1.17, you > can build it with: Okay, great. > go build --with-input=go@1.14=go@1.17 Syncthing builds! That's great.