all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#49917] [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+.
@ 2021-08-06 21:40 Sarah Morgensen
  2021-08-08 12:14 ` bug#49917: " Efraim Flashner
  0 siblings, 1 reply; 2+ messages in thread
From: Sarah Morgensen @ 2021-08-06 21:40 UTC (permalink / raw)
  To: 49917

With GCC 9+, go-1.14 fails a test when the gold linker is not
available (https://github.com/golang/go/issues/39157). Backport the fix
for that from https://github.com/golang/go/commit/4ec4a79.

gnu/packages/golang.scm (go-1.14)[arguments]<#:phases>{prebuild}:
Fix test failure with GCC 9+.
---
Hello Guix,

This fixes the CI failure at

  https://ci.guix.gnu.org/build/725502/details

and probably for other platforms as well. This should also probably go to
core-updates.

--
Sarah

 gnu/packages/golang.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d3ef39a2e6..cbcd9adb4c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1247,6 +1247,11 @@ in the style of communicating sequential processes (@dfn{CSP}).")
                    (("/bin/pwd") (which "pwd"))
                    (("/bin/sh") (which "sh")))
 
+                 ;; Backport fix for go-1.14 with GCC 9+
+                 ;; https://github.com/golang/go/issues/39157
+                 (substitute* "cmd/go/note_test.go"
+                   (("cannot find 'ld'") "cannot find [‘']ld[’']"))
+
                  ;; Add libgcc to runpath
                  (substitute* "cmd/link/internal/ld/lib.go"
                    (("!rpath.set") "true"))

base-commit: b2a5a180cfa56e55bc8078d606a971e34e326967
-- 
2.31.1





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#49917: [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+.
  2021-08-06 21:40 [bug#49917] [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+ Sarah Morgensen
@ 2021-08-08 12:14 ` Efraim Flashner
  0 siblings, 0 replies; 2+ messages in thread
From: Efraim Flashner @ 2021-08-08 12:14 UTC (permalink / raw)
  To: Sarah Morgensen; +Cc: 49917-done

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

Thanks. Patch pushed.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-08 12:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-06 21:40 [bug#49917] [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+ Sarah Morgensen
2021-08-08 12:14 ` bug#49917: " Efraim Flashner

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.