From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KJuLJNkh2mCwyQAAgWs5BA (envelope-from ) for ; Mon, 28 Jun 2021 21:24:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cBglINkh2mBdQwAA1q6Kng (envelope-from ) for ; Mon, 28 Jun 2021 19:24:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B9A81095D for ; Mon, 28 Jun 2021 21:24:09 +0200 (CEST) Received: from localhost ([::1]:33612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxwrY-0006kY-ET for larch@yhetil.org; Mon, 28 Jun 2021 15:24:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxwrS-0006kG-Dv for guix-patches@gnu.org; Mon, 28 Jun 2021 15:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41060) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxwrS-0007Kn-6Y for guix-patches@gnu.org; Mon, 28 Jun 2021 15:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lxwrS-00042O-35 for guix-patches@gnu.org; Mon, 28 Jun 2021 15:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49221] [PATCH 00/13] Add go-1.16 and build with gccgo Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Jun 2021 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49221 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49221@debbugs.gnu.org Received: via spool by 49221-submit@debbugs.gnu.org id=B49221.162490824115513 (code B ref 49221); Mon, 28 Jun 2021 19:24:02 +0000 Received: (at 49221) by debbugs.gnu.org; 28 Jun 2021 19:24:01 +0000 Received: from localhost ([127.0.0.1]:52606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxwrQ-000429-RA for submit@debbugs.gnu.org; Mon, 28 Jun 2021 15:24:01 -0400 Received: from flashner.co.il ([178.62.234.194]:53082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxwrL-00041o-Ge for 49221@debbugs.gnu.org; Mon, 28 Jun 2021 15:23:58 -0400 Received: from localhost (unknown [31.210.177.125]) by flashner.co.il (Postfix) with ESMTPSA id AA01A40190; Mon, 28 Jun 2021 19:23:49 +0000 (UTC) Date: Mon, 28 Jun 2021 22:22:15 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Sarah Morgensen , 49221@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="13OgINQYSVkhXmBJ" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 5B9A81095D X-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: 11K8DAXWA1ks --13OgINQYSVkhXmBJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 24, 2021 at 11:52:55PM -0700, Sarah Morgensen via Guix-patches = via wrote: > Hello Guix, >=20 > This patch adds go 1.16, but does *not* make it the default for other pac= kages > which use go (as suggested in [2]). There have been a lot of changes betw= een > 1.14 and 1.16, and while I have fixed many issues, I am sure continued te= sting > will uncover many more. >=20 > This patch is based on [0], which adds gccgo-10. I've applied the patch, so it should now be available in the main repo :) > With this patch, go automatically bootstraps from gccgo[0][1] on platform= s not > supported by go 1.4, but you can do so on any platform with: >=20 > guix build go --with-input=3Dgo@1.4-bootstrap-20171003=3Dgccgo@10 >=20 > Additionally, to build packages with 1.16: >=20 > guix build --with-input=3Dgo@1.14=3Dgo@1.16 >=20 > I would appreciate testing and feedback on the new bootstrap process, > especially from powerpc64le users, as I have only been able to test on x8= 6-64. > (Note that it took about two hours for gccgo to build and 30 minutes for = gccgo > to build go.) I was able to build go@1.16 as-is and with the conditional switched, so it used gccgo to bootstrap go@1.16. Additionally on my x86_64 machine using emulation I was able to build go@1.16 for powerpc64le. On the powerpc64le box I have access to I was able to build gccgo and I'm still building out to go@1.16. > Changes from 1.14: >=20 > * Bootstrap with gccgo on platforms which do not support go 1.4 (see ab= ove) > * Use GO_LDSO to set the interpreter rather than patching files > * Fix typo in cgoldflags patch ("-rpath=3D" > "-Wl,-rpath=3D") > * Fix and re-enable some cgo/gccgo tests > * Remove references to perl (used for tests) to reduce closure size by = 10% > * Set GOCACHE so go doesn't complain that it can't access it $HOME > * Break out tests into "check" phase so builders have more control >=20 > I have successfully built and tested most go packages on x86-64, including > restic, syncthing, chezmoi, and exercism. >=20 > However... docker does not pass tests. It should probably be updated to 2= 0.10, > but it is a very complicated package and I do not have the skill to do so= =2E I > attempted to backport some of the fixes, but that was also beyond my abil= ities. >=20 > Perhaps someone else will rise to the challenge? :) My only concern about the patches is that I've been burned before about pushing updates to go packages, where some seem to have insufficient testing and then they'll build and fail. So in the meantime I've pushed the go@1.16 patch. > Sarah >=20 > [0] [PATCH 0/1] gnu: Add gccgo-10. > [1] Build go with gccgo > [2] [PATCH] Added Go 1.16.2 >=20 > Sarah Morgensen (13): > gnu: go-github-com-puerkitobio-goquery: Update to 1.7.0. > gnu: go-go-uber-org-atomic: Update to 1.8.0. > gnu: go-github-com-sergi-go-diff: Update to 1.2.0. > gnu: go-github-com-pelletier-go-toml: Update to 1.9.3. > gnu: go-github-com-masterminds-goutils: Update to 1.1.1. > gnu: go-github-com-magiconair-properties: Update to 1.8.5. > gnu: go-github-com-dlclark-regexp2: Update to 1.4.0. > gnu: earlyoom: Patch tests for go-1.16. > gnu: go-github-com-bmatcuk-doublestar: Remove test incompatible with > go-1.16. > gnu: restic: Patch tests for go-1.16. > gnu: go-gopkg-in-check-v1: Update to latest. > gnu: go-etcd-io-bbolt: Update to 1.3.6. > gnu: Add go-1.16. >=20 > gnu/local.mk | 4 + > gnu/packages/backup.scm | 5 +- > gnu/packages/golang.scm | 243 +++++++++++++++--- > gnu/packages/linux.scm | 4 +- > .../earlyoom-1.6.2-disable-go-module.patch | 17 ++ > .../patches/go-fix-script-tests.patch | 18 ++ > ...m-bmatcuk-doublestar-1.3-remove-test.patch | 15 ++ > .../restic-0.9.6-fix-tests-for-go1.15.patch | 51 ++++ > 8 files changed, 314 insertions(+), 43 deletions(-) > create mode 100644 gnu/packages/patches/earlyoom-1.6.2-disable-go-module= =2Epatch > create mode 100644 gnu/packages/patches/go-fix-script-tests.patch > create mode 100644 gnu/packages/patches/go-github-com-bmatcuk-doublestar= -1.3-remove-test.patch > create mode 100644 gnu/packages/patches/restic-0.9.6-fix-tests-for-go1.1= 5.patch >=20 >=20 > base-commit: c7804cd97b28ef012acc20c1d861904e9592382b > prerequisite-patch-id: edb56de17ac3cce58402c83a9671b00381dfee76 > --=20 > 2.31.1 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --13OgINQYSVkhXmBJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmDaIWcACgkQQarn3Mo9 g1FkrhAAhDM5brVtI5lkvc9Kx3hG0k7AU2O33NMInolluamKeq+3VpZVNJRBlXLK eRoIU9BObhiQCN2aEBlm0LT9gfJxH6tAcbHXIP7mK7BNcGZoN2hMQPMgosC5FsKJ 71qVXrQSJS8TbMWZqO5M0Np69iAAoWJweKkzpQ3VDnJzHGLs7HkOxz/5fdy7InG1 RXQlR31rHK4z/sogM8eUAeIpkBGL5kLAlKUWRQbJAdIIj9yQfBqcemzzT2QJrwUY VjTdJen1xI8r/5ZllHRibrB74jNHZZRtdd71roUclJE5fxtwLWDOKsTtzsfUaZtD 0wvQ91up5SqntDqBIeE5VzDkeDYgXo5LimzdVmWzGAIUqlQTb+TDINTV+9Royc4v eqnVMmRB6mtq/waxLhVbp075Zv4IpixKZDfSqBzda7OzPW70kw2aVpB4wzU2ipNK QGKzjuzd2bqkMKgENdECKbSnCDcuzgyfnXxqFJkaVcdiozQExEhnzqSQV8lWP5JS V2saZNWtVhNFCuyItmbKuh/erDpGKa2UN4MlG8DyCLf1Su9KG6qE6imC5OdxwDKs 9bldn41Wp2X4je37JM9N6IrQF92UP98VgxtzfUrBG7dURfdphXfk2W5Bu+2u5SN/ 6bwVPmml3tIHuI+DAi9HW18JXVd85XLia4LARz5BwWPdnyKfMjY= =P6bq -----END PGP SIGNATURE----- --13OgINQYSVkhXmBJ--