From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mM4VKSO1kWBLTQAAgWs5BA (envelope-from ) for ; Tue, 04 May 2021 22:57:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id XGWJJCO1kWCdSAAAbx9fmQ (envelope-from ) for ; Tue, 04 May 2021 20:57:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4990D1FB7F for ; Tue, 4 May 2021 22:57:07 +0200 (CEST) Received: from localhost ([::1]:41762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1le26M-0003ul-G3 for larch@yhetil.org; Tue, 04 May 2021 16:57:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le26I-0003uW-I4 for guix-patches@gnu.org; Tue, 04 May 2021 16:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1le26I-0001CY-B0 for guix-patches@gnu.org; Tue, 04 May 2021 16:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1le26I-0008R5-Au for guix-patches@gnu.org; Tue, 04 May 2021 16:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48126] [PATCH] Add package for vim-solarized Resent-From: Tissevert Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 May 2021 20:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48126 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 48126@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 48126@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162016180332409 (code B ref -1); Tue, 04 May 2021 20:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 May 2021 20:56:43 +0000 Received: from localhost ([127.0.0.1]:55384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le25y-0008Qf-KV for submit@debbugs.gnu.org; Tue, 04 May 2021 16:56:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:42772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le25w-0008QZ-JN for submit@debbugs.gnu.org; Tue, 04 May 2021 16:56:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le25w-0003dd-Af for guix-patches@gnu.org; Tue, 04 May 2021 16:56:40 -0400 Received: from marvid.fr ([163.172.81.107]:54292 helo=courriel.marvid.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le25t-0000pt-CU for guix-patches@gnu.org; Tue, 04 May 2021 16:56:40 -0400 Received: from hellebore (unknown [78.194.167.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sahkopoika (Postfix) with ESMTPSA id 282545242988; Tue, 4 May 2021 22:56:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=marvid.fr; s=201901; t=1620161788; bh=RMhq1bUIOTzjkPDPTCO9W4aISx32y+D2QMpoEwPCsos=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KzDE9zhD0NvIoVOQDtzyGR1VB6zFuvCg57I6zSAr76U2HHkl0AXUc3caUi8b6+KIN KjCFO6Evw4+h6TNNOBoIXE/NjIvPF3vFJ3XdAa7Z2lOWXu0HKoiaqV5OYH23HbCY3k 1vd9IFkjrXuSskpUFMiDf2uncq2bAWqsYwyfmJlo= Date: Tue, 4 May 2021 22:56:27 +0200 From: Tissevert Message-ID: References: <20210430194235.1461cada@pine.local> <87im43qs01.fsf@nckx> <87fsz7qroo.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="pxP9MzgVe4BVKtua" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87fsz7qroo.fsf@nckx> Received-SPF: pass client-ip=163.172.81.107; envelope-from=tissevert+guix@marvid.fr; helo=courriel.marvid.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620161827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=u/lNU9/3a2CkiH1ShZDLxG6+lZrUJ1pr9UiNWb6iRjc=; b=rnRGDlTXcoV8YgEED0Pr65EC+Hbc4OVDBebeq6Mtf/oysV1h6WNQ58DV/vVLeWuIGVVMrL 9QJvWt5HWP0FD4E9niHRrVBDaBTEK9bbnVPWOdxORKmOIVw9+ti/VTtraNQcCiKz/rHNds 1O5bHRfijCtgWG6vCZF3LtGX8HVPCzn9IwRUQzeYsoLMjwa7KzEKD+EmwKxpgHYnVm66MJ a9eSrywICsl76/mdndJAvHD9Q9GExus2DV+1yMU+gz/HReEowK7NBVOsF56mpqcK5N35nJ X68mAD61bt+ha/O0ReEBf5QJ86j9C6he0T6J6dq7clexSZatUEjrxzl5w/b1tA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620161827; a=rsa-sha256; cv=none; b=O9KIYF4ALvvFMgfJ/eGj1OjTBBI54MHKVt+u+RjSoXttoO8nlX2whx12uL+lGTILUKXbvQ xYuZbsJuv1owUkuvJaHQ+XNxjxYgH9XYRcqBTbHXDiyKOv9WE6kisohRd/zOnE2NghNvLH OKx53PYOdyUpBfCXBaraZK90eJMfBy6V1o2mO1LJQiSJ3dAoV7fch8TY6a9GCTsvxze7oX MdevwGvnDmsXt0inibvBdwfs04NIXlQ0x0Nr+bZmReAsi4XzNrIEIDCvmSKuUbAHCRB2Oq EtUO3lA1f7HNVfow0uX1PxxsNag4kkYqJRySu3IWGqAPPxmakIdbWEBUM84LVA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=marvid.fr header.s=201901 header.b=KzDE9zhD; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 1.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=marvid.fr header.s=201901 header.b=KzDE9zhD; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 4990D1FB7F X-Spam-Score: 1.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: jWSsrR7xigvX --pxP9MzgVe4BVKtua Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hello ! Thanks a lot for all your feedback. It took me a little while but I think I've improved my first patch proposal. I had tried to indent the code automatically like mentioned in the video tutorial using etc/indent-code.el but obviously this had failed. Maybe I overwrote the changes with vim ? Anyway, I tried doing it again but there are many other badly indented blocks in the rest of the file so it is hard to do and retain only what is in my new package. So I've done it twice during the process, but it could still be a little weird. I changed the source to use the main «heavy» repos, and since it has a release tag but the actual commit corresponding to this tag is a little behind the current state (I checked the diff, it has changes to the vim files, not just the documentation) so I used the latest commit as target to be sure the most recent changes were included in the package even though I still call it by the name of the most recent tag. So here goes. Kind regards, Tissevert Le Sat, May 01, 2021 at 01:27:19AM +0200, Tobias Geerinckx-Rice a écrit : > Well that diff got börked to hell. Here it is again. > > Kind regards, > > T G-R > --pxP9MzgVe4BVKtua Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Update-version-indentation-and-description.patch" >From e310e94869cfa274d0699ab97c60835dab6fa5eb Mon Sep 17 00:00:00 2001 From: Tissevert Date: Tue, 4 May 2021 22:43:25 +0200 Subject: [PATCH] Update version, indentation and description --- gnu/packages/vim.scm | 53 ++++++++++++++++++++++++++------------------ 1 file changed, 32 insertions(+), 21 deletions(-) diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm index 477c15b9aa..6fb79851b8 100644 --- a/gnu/packages/vim.scm +++ b/gnu/packages/vim.scm @@ -581,28 +581,39 @@ are detected, the user is notified.") (license license:wtfpl2))) (define-public vim-solarized - (package - (name "vim-solarized") - (version "v1.0.0beta1") - (source - (origin - (method git-fetch) - (uri (git-reference + (let ((commit "62f656a02f93c5190a8753159e34b385588d5ff3") + (revision "1")) + (package + (name "vim-solarized") + (version (git-version "v1.0.0beta1" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference (url "https://github.com/altercation/vim-colors-solarized") - (commit "528a59f26d12278698bb946f8fb82a63711eec21"))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "05d3lmd1shyagvr3jygqghxd3k8a4vp32723fvxdm57fdrlyzcm1")))) - (build-system copy-build-system) - (arguments - '(#:install-plan - '(("colors" "share/vim/vimfiles/") - ("doc" "share/vim/vimfiles/")))) - (home-page "https://github.com/altercation/vim-colors-solarized") - (synopsis "Solarized Colorscheme for Vim") - (description "Precision colors for machines and people") - (license license:bsd-3))) + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0001mz5v3a8zvi3gzmxhi3yrsb6hs7qf6i497arsngnvj2cwn61d")))) + (build-system copy-build-system) + (arguments + '(#:install-plan + '(("vim-colors-solarized/colors" "share/vim/vimfiles/") + ("vim-colors-solarized/doc" "share/vim/vimfiles/")))) + (home-page "https://github.com/altercation/vim-colors-solarized") + (synopsis "Solarized color scheme for Vim") + (description + "Solarized is a 16-color palette comprising 8 monotones and 8 accent +colors. It was designed for use with both terminal and GUI applicatins, and +has a dark and a light mode. + +Based on CIELAB lightness relationships between colors, this theme reduces +brightness contrast but retains contrasting hues based on colorwheel relations +for syntax highlighting readability. + +It retains the same selective contrast relationships and overall feel when +switching between the light and dark background modes.") + (license license:expat)))) (define-public editorconfig-vim (package -- 2.31.1 --pxP9MzgVe4BVKtua--