all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: elaexuotee@wilsonb.com
Cc: 47905-done@debbugs.gnu.org
Subject: bug#47905: gnu: Add rasdaemon.
Date: Sat, 24 Apr 2021 12:33:56 -0400	[thread overview]
Message-ID: <YIRIdPmHCbwcH669@jasmine.lan> (raw)
In-Reply-To: <377TR65TD6KJY.2JY05ANZ7375P@wilsonb.com>

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

On Thu, Apr 22, 2021 at 07:01:20PM +0900, elaexuotee@wilsonb.com wrote:
> Fixed!  Thanks for holding my hand on this.  That above link cleared up a lot
> of lingering questions I had.

You're welcome! My goal is help contributors keep learning until they
are sending patches that pass code review on the first try, and they
feel confident to start reviewing patches, too. Based on this submission,
I think you are more than knowledgeable enough to review some patches :)

> Let me know what you think.

> From d31cb88e5c34cc0b650ff181ebb6a0d85d045f9d Mon Sep 17 00:00:00 2001
> From: "B. Wilson" <elaexuotee@wilsonb.com>
> Date: Tue, 20 Apr 2021 11:49:26 +0900
> Subject: [PATCH] gnu: Add rasdaemon.
> To: guix-patches@gnu.org
> 
> * gnu/packages/linux.scm (rasdaemon): New variable.
> * gnu/services/linux.scm (rasdaemon-configuration)
>   (rasdaemon-configuration?, rasdaemon-configuration-record?)
>   (rasdaemon-service-type): New variables.
> * doc/guix.texi (Linux Services): Document it.

It's good! I pushed as 2c93df3d11bf8ceeb5c203416a2533cf32275e1a after
splitting it into two commits: one for the package, and one for the
service and its documentation.

By the way, you might ask upstream about fixing the issues in their
build scripts — the ones you fixed in the 'munge-autotools' phase. I
think most distros will need to do similar fixes.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-04-24 16:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  4:24 [bug#47905] gnu: Add rasdaemon elaexuotee--- via Guix-patches via
2021-04-20  5:04 ` Leo Famulari
2021-04-20  5:07 ` Leo Famulari
2021-04-20  5:54   ` elaexuotee--- via Guix-patches via
2021-04-20 16:08     ` Leo Famulari
2021-04-20  5:30 ` Leo Famulari
2021-04-20  6:18   ` elaexuotee--- via Guix-patches via
2021-04-20 16:19     ` Leo Famulari
2021-04-20  5:33 ` Leo Famulari
2021-04-20  6:23   ` elaexuotee--- via Guix-patches via
2021-04-20 16:20     ` Leo Famulari
2021-04-20  7:10   ` elaexuotee--- via Guix-patches via
2021-04-20 16:23     ` Leo Famulari
2021-04-22 10:01       ` elaexuotee--- via Guix-patches via
2021-04-24 16:33         ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIRIdPmHCbwcH669@jasmine.lan \
    --to=leo@famulari.name \
    --cc=47905-done@debbugs.gnu.org \
    --cc=elaexuotee@wilsonb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.