From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iB1VN8L1dmBKTQEAgWs5BA (envelope-from ) for ; Wed, 14 Apr 2021 16:01:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WPksMcL1dmBQZQAAB5/wlQ (envelope-from ) for ; Wed, 14 Apr 2021 14:01:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 59ECC10A1E for ; Wed, 14 Apr 2021 16:01:38 +0200 (CEST) Received: from localhost ([::1]:39566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWg5J-0002EK-EU for larch@yhetil.org; Wed, 14 Apr 2021 10:01:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWg4m-0002E2-OP for guix-devel@gnu.org; Wed, 14 Apr 2021 10:01:08 -0400 Received: from flashner.co.il ([178.62.234.194]:57262) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWg4h-0005z6-Qk for guix-devel@gnu.org; Wed, 14 Apr 2021 10:01:04 -0400 Received: from localhost (unknown [31.210.177.71]) by flashner.co.il (Postfix) with ESMTPSA id AE6EE40333; Wed, 14 Apr 2021 14:00:58 +0000 (UTC) Date: Wed, 14 Apr 2021 17:00:13 +0300 From: Efraim Flashner To: Chris Marusich Subject: Re: bug#47615: [PATCH 2/9] gnu: guile-3.0: Fix building on powerpc-linux. Message-ID: Mail-Followup-To: Chris Marusich , 47615@debbugs.gnu.org, guix-devel@gnu.org References: <87h7k91pn8.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wSoOHJ9gKDIJB839" Content-Disposition: inline In-Reply-To: <87h7k91pn8.fsf_-_@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, 47615@debbugs.gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618408898; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=GmKqMzjAkpfdidwZjyPVwKrEWqLgeHMq8uI36o/ZTt8=; b=ZeiF7u4xGiZyR+/N5koZ3O0blKpEsXQCRSC21h+KmwkTRNJpz5ZeT19f+xr1+xboEyVFUu 25+ivj0QFuAh0TTYk4USkUpZGk7skkMRIIxdOsA5PLNC8IRl2jF7B+w366kkBIa00xTOEo 75ud57cmRsUrWYyOFumRjYUZKxtNhFJhOPd/Zz8/Nbxo0JmfNXTGvTjfJtUe6yA+/EVlzn 3dr4qMr9++gandKi/wAzlKb/689LGhf/eRpSU2LEYSQzGRHhJ75pkSPc2yfEEz0MDqEgbo q+CwprIGrbIXy29JPSQq9rzMKT+I5AvLvyvTdPYd6XJeMI+p6Ck2rDydWwlxNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618408898; a=rsa-sha256; cv=none; b=qaivEUOAPT7H+egpOk7vxWJzdgvjpZG4zFSVA4RlQPwbUEsxVbmtFZiRtivBIealGHw00M pBQI3PvmJjDSxDyOAhSM08XrDdIqbUV47AbfYedXCBvY3eDvgtq0TRx9BNass+IzGbq58D rMEuDZBp0akwK0K49Z9NstNEMZHndAZUBdBw7Pg4ps6nq0zrkX5yjiHyxUVsruqM1o2Sda hMN7tVIzFErNe4X2sUOePVGyDvrU3i3ZRFqyinah59Pm50HW2azgPEptkqloM5T7IeTL2r V/QjMrUKaSQy/TR+bMPIprrO+aIhi2uCR5vZNWVTBa+YL4qiLEwFVS6i10Gy0A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -4.64 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 59ECC10A1E X-Spam-Score: -4.64 X-Migadu-Scanner: scn0.migadu.com X-TUID: qVyHXmNb9sFE --wSoOHJ9gKDIJB839 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 13, 2021 at 09:00:43PM -0700, Chris Marusich wrote: > Efraim Flashner writes: >=20 > > * gnu/packages/guile.scm (guile-3.0)[arguments]: On powerpc add two > > phases to adjust for 32-bit big-endian systems. > > --- > > gnu/packages/guile.scm | 21 ++++++++++++++++++++- > > 1 file changed, 20 insertions(+), 1 deletion(-) > > > > diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm > > index f63322794d..dca1b1c16f 100644 > > --- a/gnu/packages/guile.scm > > +++ b/gnu/packages/guile.scm > > @@ -305,7 +305,26 @@ without requiring the source code to be rewritten.= ") > > (substitute-keyword-arguments (package-arguments guile-2.2) > > ((#:configure-flags flags ''()) > > `(cons "--disable-jit" ,flags))) > > - (package-arguments guile-2.2))) > > + (if (string-prefix? "powerpc-" (%current-system)) > > + (substitute-keyword-arguments (package-arguments guile-2.2) > > + ((#:phases phases) > > + `(modify-phases ,phases > > + (add-after 'unpack 'adjust-bootstrap-flags > > + (lambda _ > > + ;; Upstream not yet notified about suggested solu= tion. > > + ;; See existing bug reports: > > + ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug= =3D45214 > > + ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?= bug=3D977223 > > + (substitute* "bootstrap/Makefile.in" > > + (("^GUILE_OPTIMIZATIONS.*") > > + "GUILE_OPTIMIZATIONS =3D -O1 -Oresolve-primiti= ves -Ocps\n")) > > + #t)) > > + (add-after 'unpack 'remove-failing-tests > > + (lambda _ > > + ;; TODO: Discover why this test fails on powerpc-= linux Needs a period at the end of the sentence. > > + (delete-file "test-suite/standalone/test-out-of-m= emory") > > + #t))))) > > + (package-arguments guile-2.2)))) > > (native-search-paths > > (list (search-path-specification > > (variable "GUILE_LOAD_PATH") >=20 > Generally this looks reasonable. I understand 3 weeks is a long > iteration time! I think it's OK to proceed if it works for > bootstrapping other software on this platform. Especially since the > change is isolated to just powerpc-linux. >=20 > Has the Guile test failure been reported upstream? >=20 The two bugs mentioned are known to upstream and there are some other reports of failures on other niche architectures like hppa. Unfortunately I haven't gotten around to writing the email letting them know what works for me but I'll do that soon. I haven't signed the CLA for GNU projects so I want to make sure I don't send them a poisoned patch. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --wSoOHJ9gKDIJB839 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmB29W0ACgkQQarn3Mo9 g1H/bA//T5ReM+nQHG5OvrAWxJHHbBt1wexsBSSnbcvEC6J03xnOww5VW3jP8h0n OktNpYArX7Yvj639kxFbDd7kcuYNdxj3pWlQ8DQeLAh5zr1D4fzE7cEDjU/92a66 z5dWEFkCbpCr1zFFI8aXLH1H4ROPSjJtsEiO2A7IIPxKz9GYsDgOjdE6pzoeY7Ot sk44l1qFxGBSuf35AXRnKzDZu7N2Y/S0XiG6KBAcTRYlZ2Ng7kbHwg5UaNS8HEsZ ijF8yKwVw1Vi/SoPjbhgXGpRgBhYFTxBgyqGO+AVEcKooLIysh9cBKXKxb/ZzZvi 2BW4nZy6MWWF3e94eWDzAIoWKXG4WGzwvzyEiidlsgMnvuoosl2QIWpfExJ+2PXm FTn3TCImExBXnDHj+SWtXqZOkfWq/HT0olpQ8uJWjShjPVEe61z3GdbQs84QSBe8 HAIaX6Moxl9GcIi7lSnoAIJ8+cMW6TETBtUcTaSeNqUGUpyWuY7+ixPX3xZdYlBh NyH3ataj4n9YXCpAsotPDbPOPjgWOP7oan0UaZDehMGUQ2ZWimZCsQ0hOZ+TBsRc CdJlRZd9NipSMrafq5x0zCKB+X9GIS+wUJFmMiJJC6gtqEtaRl46yPPaKNC9JSMN mctho4RH4CAdC5pHXvrfYqCNift6bgYui0TkQfG5SCsxv/E0Isk= =fm9d -----END PGP SIGNATURE----- --wSoOHJ9gKDIJB839--