From: Leo Famulari <leo@famulari.name>
To: Winter Hound <winterhound@yandex.com>
Cc: 47923@debbugs.gnu.org
Subject: [bug#47923] gnu: Add daemonize.
Date: Tue, 20 Apr 2021 21:05:32 -0400 [thread overview]
Message-ID: <YH96XJickL+GYT2s@jasmine.lan> (raw)
In-Reply-To: <2832341618952534@mail.yandex.com>
On Wed, Apr 21, 2021 at 02:37:02AM +0530, Winter Hound wrote:
> From f9e100cf01ea72544996b54b78a08502ca33a413 Mon Sep 17 00:00:00 2001
> From: WinterHound <winterhound@yandex.com>
> Date: Wed, 21 Apr 2021 02:17:13 +0530
> Subject: [PATCH] gnu: Add daemonize.
Thanks for the patch!
Don't forget to add yourself to the list of authors of
gnu/packages/admin.scm. There's an example in commit
3ddece896fddc38a29ab7e69f7c74f35e5a381fb, which was your patch adding
kirc:
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3ddece896fddc38a29ab7e69f7c74f35e5a381fb
> + (arguments
> + `(#:tests? #f
I'm guessing this program doesn't have a test suite?
We prefer to document why #:tests? are #f. A code comment like "No test
suite" is sufficient.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-makefile
> + (lambda _
> + (substitute* "Makefile.in"
> + (("/sbin") "/bin")) #t)))))
Why change this output directory? We usually respect the upstream
decision about whether executable binaries go in 'sbin' or 'bin'. Guix
will add both directories to $PATH, so it will work either way.
Otherwise, looks good! Can you send a revised patch or answer those
questions?
next prev parent reply other threads:[~2021-04-21 1:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 21:07 [bug#47923] gnu: Add daemonize Winter Hound
2021-04-21 1:05 ` Leo Famulari [this message]
2021-04-21 5:17 ` Winter Hound
2021-04-21 5:18 ` Winter Hound
2021-04-21 6:21 ` Winter Hound
2021-04-22 8:37 ` bug#47923: " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH96XJickL+GYT2s@jasmine.lan \
--to=leo@famulari.name \
--cc=47923@debbugs.gnu.org \
--cc=winterhound@yandex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.