From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iDZgMS+gbGDbEQAAgWs5BA (envelope-from ) for ; Tue, 06 Apr 2021 19:53:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UDE6Ky+gbGDYZwAAB5/wlQ (envelope-from ) for ; Tue, 06 Apr 2021 17:53:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 433E22C229 for ; Tue, 6 Apr 2021 19:53:50 +0200 (CEST) Received: from localhost ([::1]:52702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTptd-0008Uw-Dq for larch@yhetil.org; Tue, 06 Apr 2021 13:53:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTpl8-0007iW-OT for guix-patches@gnu.org; Tue, 06 Apr 2021 13:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTpl8-0000kP-Eh for guix-patches@gnu.org; Tue, 06 Apr 2021 13:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lTpl8-00087k-B4 for guix-patches@gnu.org; Tue, 06 Apr 2021 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47613] =?UTF-8?Q?[PATCH]=C2=A0add?= parmetis Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Apr 2021 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47613 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Franck =?UTF-8?Q?P=C3=A9rignon?= Cc: 47613@debbugs.gnu.org Received: via spool by 47613-submit@debbugs.gnu.org id=B47613.161773105331156 (code B ref 47613); Tue, 06 Apr 2021 17:45:02 +0000 Received: (at 47613) by debbugs.gnu.org; 6 Apr 2021 17:44:13 +0000 Received: from localhost ([127.0.0.1]:41691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTpkL-00086S-Ca for submit@debbugs.gnu.org; Tue, 06 Apr 2021 13:44:13 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:43985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTpkG-000869-LS for 47613@debbugs.gnu.org; Tue, 06 Apr 2021 13:44:12 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 96D2C133D; Tue, 6 Apr 2021 13:44:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 06 Apr 2021 13:44:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=HPFK/nOYIGIYotJ9Lhtoh05d yXn0yEqdOBuXCYXqTjA=; b=qXVQQvEpscSKxbf70Rb2UcfdWuoqdS9wP5wSGidX NXqf6baUNasHknIDH4B8Fj9ozXs7/w31tQ/XvEVVu9cKpS5ZJcRsSAILo3lgdq1K LXv3YNsFC+5pedOnmjFIWD3jK6S/E8BATpMyUe+BcBwQUb70n13I+Miaj+nraz+i 8tI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HPFK/n OYIGIYotJ9Lhtoh05dyXn0yEqdOBuXCYXqTjA=; b=iL6Plpdm8rUVEv8LgXZQPm R39fEljhtlMhydpRGNN1nOjakTjenMkNZB629za60JWgMXhVUmIjw4eEefDEHzUa fttJTOg48h1yJvvYC+tMgAt+UMNtKT19aljL9Ge3yfoWQkTzsoJ+ykZCMewaRn2e rl0sTsVuQnu/k+7mBaOwKt8LFyuYTgCsgw01hr+hbl+TUeyf+/cXLcFkX/UzSk3j m1JEzW2HejVHUv/PuNHOtBPhKIXQvqKfcjQ8TkUYggEhAryDhn0AnQ5+Sx/1DCAZ V41w6z7qp4jgcp/2J767KR8pZ+oBqTKXAybSoq2ibTkk2PXXykwpPCzj813nn/bw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejhedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedufeeutdehtdffiefhffduveettddvieehueeghfeufedtvdffgeekkeelvdff heenucffohhmrghinhepuhhmnhdrvgguuhenucfkphepuddttddruddurdduieelrdduud eknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgv ohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 61DAC240057; Tue, 6 Apr 2021 13:44:01 -0400 (EDT) Date: Tue, 6 Apr 2021 13:43:59 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617731630; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HPFK/nOYIGIYotJ9Lhtoh05dyXn0yEqdOBuXCYXqTjA=; b=ebpYW3bJqDrsh0msSigVSzPqUQsqwC3BgFHZtseTNh2xxJv99O9ErN9QzEG6Xlw/wW2qCI 2KGQA14/Wr0cVpeQ2lJms9A/aplQndVx+3cdQh3bLDH4brhmnQpst9k3uhNz5sXFGYEGeH IqfUFxZqhSvY0knSHbDxjPDUcN6WTrJtzcmd7ca2s+ZRvUcVjyl9Tv1XiDw6wgTUBfpxB7 oawKvu8Tq0idOj/I8jRhlErllEVpQJfVJnuihUlP97svf87g6ICCxXP03W9EAlqCnSZ+V1 kY3xD8z/m3lcq1QaXXD75AFNky0Fn4l2V4OWJVF0PsD+aM8VNsxwyzYtwrj81g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617731630; a=rsa-sha256; cv=none; b=rNLMzC4kUgBTvk8WoTgnXe1oCNaJkPX6BCTgZEDpIiqXefBaO7jBXnI6TeHe2vP8jnU2Ye kJmhG0+67kYKucjV73pWAfSg9rqlHUa7ig6JjW/MzznkWBlnzeynA0sWSYQ4g8ccz1HW5/ n8g08YXB5wmZTWsq5+EJGwo54BZDdiIUvBRqOKPoUK+3EwjV8kA6J0bhsbdw+4CFCj+izE dsCVmgfVSjIzQgWkUJaYj7Ll+3kCs21+38sEnX4RaPEBT8ZNRs1ahY1mxupRY3QQwt5xu/ TkcXyYYgZCMzkpfKH4nas8nNdEatX7CNVCMaiAFxTog10VlkovXQP3yvUME/Qw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=qXVQQvEp; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=iL6Plpdm; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.06 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=qXVQQvEp; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=iL6Plpdm; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 433E22C229 X-Spam-Score: 0.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: kfi/yJ7YFvDI Subject: [PATCH] [PATCH] Add parmetis Thanks! + (build-system cmake-build-system) + (native-inputs `(("gcc" ,gcc) + ("openmpi" ,openmpi))) GCC is made available via the cmake-build-system, so I think we could leave it out of native-inputs. Or am I missing something? + (arguments + `(#:tests? #f ;no tests + #:configure-flags `("-DSHARED=ON" + ,"-DCMAKE_C_COMPILER=mpicc" + ,"-DCMAKE_CXX_COMPILER=mpic++" + ,"-DCMAKE_VERBOSE_MAKEFILE=1" + ,(string-append "-DGKLIB_PATH=../parmetis-4.0.3/metis/GKlib") + ,(string-append "-DMETIS_PATH=../parmetis-4.0.3/metis" )))) We can avoid hard-coding the version string here, like this: ------ diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index bdfa051db1..f0ebdd6009 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -3348,8 +3348,10 @@ schemes.") ,"-DCMAKE_C_COMPILER=mpicc" ,"-DCMAKE_CXX_COMPILER=mpic++" ,"-DCMAKE_VERBOSE_MAKEFILE=1" - ,(string-append "-DGKLIB_PATH=../parmetis-4.0.3/metis/GKlib") - ,(string-append "-DMETIS_PATH=../parmetis-4.0.3/metis" )))) + ,(string-append "-DGKLIB_PATH=../parmetis-" + ,(package-version this-version) "/metis/GKlib")) + ,(string-append "-DMETIS_PATH=../parmetis-" + ,(package-version this-version) "/metis")))) (home-page "http://glaros.dtc.umn.edu/gkhome/metis/parmetis/overview") (synopsis "Parallel Graph Partitioning and Fill-reducing Matrix Ordering") (description ------ + (license license:asl2.0))) There is a problem with the licensing, however. In the source code, LICENSE.txt contains this: ------ Copyright & License Notice -------------------------- The ParMETIS package is copyrighted by the Regents of the University of Minnesota. It can be freely used for educational and research purposes by non-profit institutions and US government agencies only. Other organizations are allowed to use ParMETIS only for evaluation purposes, and any further uses will require prior approval. The software may not be sold or redistributed without prior approval. One may make copies of the software for their use provided that the copies, are not sold or distributed, are used under the same terms and conditions. As unestablished research software, this code is provided on an ``as is'' basis without warranty of any kind, either expressed or implied. The downloading, or executing any part of this software constitutes an implicit agreement to these terms. These terms and conditions are subject to change at any time without prior notice. ------ I saw in 'metis/Changelog' that a relicensing to Apache 2 was done for the "metis" program in version 5.0.3. But, this is "parmetis", version 4.0.3. If the copyright owners intend to release this as free software, they need to change the 'LICENSE.txt' file.