From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aGlVEK5TUWB0cgAA0tVLHw (envelope-from ) for ; Wed, 17 Mar 2021 00:56:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6AsKDK5TUWBwYgAAbx9fmQ (envelope-from ) for ; Wed, 17 Mar 2021 00:56:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E124417167 for ; Wed, 17 Mar 2021 01:56:13 +0100 (CET) Received: from localhost ([::1]:43510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMKTs-0007jF-O0 for larch@yhetil.org; Tue, 16 Mar 2021 20:56:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMKTi-0007hI-Q1 for guix-patches@gnu.org; Tue, 16 Mar 2021 20:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58189) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMKTi-0002yo-Ia for guix-patches@gnu.org; Tue, 16 Mar 2021 20:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMKTi-0000hA-HU for guix-patches@gnu.org; Tue, 16 Mar 2021 20:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47013] [PATCH] gnu: Harden filesystem links. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Mar 2021 00:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47013 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 47013@debbugs.gnu.org Received: via spool by 47013-submit@debbugs.gnu.org id=B47013.16159425022588 (code B ref 47013); Wed, 17 Mar 2021 00:56:02 +0000 Received: (at 47013) by debbugs.gnu.org; 17 Mar 2021 00:55:02 +0000 Received: from localhost ([127.0.0.1]:41502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMKSk-0000fb-9q for submit@debbugs.gnu.org; Tue, 16 Mar 2021 20:55:02 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMKSj-0000fE-5p for 47013@debbugs.gnu.org; Tue, 16 Mar 2021 20:55:01 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 33B6A5C00E5; Tue, 16 Mar 2021 20:54:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 16 Mar 2021 20:54:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=JLEFU8iQDsZqvHjM3UdsRvdrGLOF9FHKnPF72ofAoUM=; b=pV0rx1lUIwPv zVLAu8xa1rBKjU0Kv61P79sLnNx1MnoY9dpViJwWRF8Xl6XTWl1R/h9OM8IPOltx rYNVy3vgTMcqIMUnQzo+A+yxjuvJifgptJUszKLyFpOXOFgkTGkVwi4tBPlJNzn5 FvXNjOobApqBmu10ZHddxdfQ1u6R61A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=JLEFU8iQDsZqvHjM3UdsRvdrGLOF9FHKnPF72ofAo UM=; b=gDleW4eWV5q37q3TjaJmy3ovMttEMs9iJ976s80b7jO2Tbl1c1xQkYgPr haty5OlLr605C+bHbjKF7CQFDRhW8p+aiwjr7uZKoEdFIq885B3AvqJ51cmfKQh9 LSRgMnOQEr9qBHw4fASPqKCRU2r6+lwOmmRwb+FiYYp/K7yNtpGM+kGM0jdA9eJ5 HHkqQPfISUzEJa4ZtRz38h0fMlxkQOjnteVvOJZgpDHlpWUM9sYH4lQpPXhQmuiI YF3mZyUKM2lGKc4aOSA9VXuf0sFHJ70D1fiPCuSHVe8wPsdaPCXKT65h5Yw/da6b eo1cH4EZesr/MzIMjHc2AqujEaUGg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeffedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtudenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepueeugedugfdvgfevuedvleduleefjefhgefgjeetgfegkedukefhvdefleej hefgnecukfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 4FC4D108006A; Tue, 16 Mar 2021 20:54:54 -0400 (EDT) Date: Tue, 16 Mar 2021 20:54:52 -0400 From: Leo Famulari Message-ID: References: <8735wu7nf9.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8735wu7nf9.fsf_-_@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615942574; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JLEFU8iQDsZqvHjM3UdsRvdrGLOF9FHKnPF72ofAoUM=; b=NaRpGkHAVGtwSUMmkOPTiu2JBHzRIFqvyzavhIqNUH8La+cCDy+ZtOb7tuJgQkO9kwz96X Wq73ADNwuSx31XMukJcK7s1VerEsJfFgzIdO5YDwr4qD8b6P5Gd67lAd6jcWeZ+WpWtwFq 4dHbe87YnIrobLUkmtuLrx0Bd03E9/+HvvfAfNaiJR8xGNUIGdScWjzGN4sx9DuWGLWwm7 tScwmg7P0If25kBDmca4G9/YRSFMqa4yyk3P7dv1CD/QLTG91y1guPIrkZOgLPvUIlNT+b vH9fU6VD1ZAMjzuiRafSHmk6kPQ5fSKp4dobAlAhsQjLAyCWyu24AucifHRkZQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615942574; a=rsa-sha256; cv=none; b=DghQmkMDzmU3sPivD3z9UrvE6WPaGyi9zUR6bBxS7f8Yqz3H5/sOVaGsaYJZqJEDBI0Yn5 PYSUYotgN6edWY6V9yiTPbXGMRufoMGhMWv4VqqaNn8xVOSkFNqUh/mOMUtALQFMJu4zti S2Mu/92JGrpQ3xvvry/SJDKPNezWWPjtTWAwxJN272UAOgZu4D2oIDYs1ik8p8wtDHboAN Afg4TLYSQwUmsHHM3eeQpk0HNAv/s1l9kNTc8Gomm1Pi6M3SBRS8GyMPKUSeh3bSgFPDFb EQd4JqNEtdVFwWH9Wux5/PmZAO1dJU5Hd73CS0JDoe39dcc1XSEXxV3G2pu5zQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=pV0rx1lU; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=gDleW4eW; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=pV0rx1lU; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=gDleW4eW; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E124417167 X-Spam-Score: -1.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: MrEO6HEh4s6l On Tue, Mar 16, 2021 at 11:18:18PM +0100, Ludovic Courtès wrote: > Thoughts? We discussed this on IRC. Basically, my goal is to make it easy for users to add their own sysctl-service-type without accidentally removing the default sysctl settings. My third patch achieves that. However, you did not like that it required creating a new service type just to set some defaults. As a compromise, we could create a new variable %default-sysctl-settings and add a sysctl-service-type in %base-services that uses that variable. At least, that way, it would be a little more clear that there are some defaults. The manual could show users how to append their own sysctl parameters to %default-sysctl-settings. While implementing that, I noticed the variable %default-kernel-arguments in (gnu system). All these years, I have been setting some custom kernel-arguments, and I never noticed there was a default value that I was erasing. This illustrates why I prefer the approach in my 3rd patch. Otherwise, it will be very easy for users to implicitly and unexpectedly disable the default parameters we are trying to set, if they try to add their own.