From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iB5AN72qMWBECgAA0tVLHw (envelope-from ) for ; Sun, 21 Feb 2021 00:35:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iY7lMr2qMWBDLwAAbx9fmQ (envelope-from ) for ; Sun, 21 Feb 2021 00:35:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8CC8315BF0 for ; Sun, 21 Feb 2021 01:35:09 +0100 (CET) Received: from localhost ([::1]:50616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDciK-0007BR-E9 for larch@yhetil.org; Sat, 20 Feb 2021 19:35:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDciE-0007BK-8c for guix-patches@gnu.org; Sat, 20 Feb 2021 19:35:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDciE-0003nA-1e for guix-patches@gnu.org; Sat, 20 Feb 2021 19:35:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lDciD-0002pp-V6 for guix-patches@gnu.org; Sat, 20 Feb 2021 19:35:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46393] [PATCH] gnu: Add ocrfeeder Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Feb 2021 00:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46393 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: 46393@debbugs.gnu.org Received: via spool by 46393-submit@debbugs.gnu.org id=B46393.161386765110837 (code B ref 46393); Sun, 21 Feb 2021 00:35:01 +0000 Received: (at 46393) by debbugs.gnu.org; 21 Feb 2021 00:34:11 +0000 Received: from localhost ([127.0.0.1]:53207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDchP-0002oj-6k for submit@debbugs.gnu.org; Sat, 20 Feb 2021 19:34:11 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:45191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lDchN-0002oV-85 for 46393@debbugs.gnu.org; Sat, 20 Feb 2021 19:34:10 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id DB4F25A6; Sat, 20 Feb 2021 19:34:02 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 20 Feb 2021 19:34:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=8KwyjxU5FuAN74DjLyI6tUzI yZX9QSR/wba6CqYyllE=; b=XLDgXM0qBGNfJ4M35SH7cjgbnUdPEEzYCRDMC9RA TofU0R4GhGlwrfP3yqFN+le7V3RTYe7KiAFs/tb/4V+vk5hSY/5/eUph6IWwvOgZ Qsc5ESLmR1DWi72wru+jEXwMp3zt8AZbVPWqZJUzwYZPwZc0Z3vqV+DgFfKnXg5s pF4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=8Kwyjx U5FuAN74DjLyI6tUzIyZX9QSR/wba6CqYyllE=; b=Ln5/hUs3I44Qq04wiO6rOw bR7etyKK8zMe6AB9lD9d5avPkLHZhLsOUuZHFiG6JSKuNPShwzT7Z66i1TKnQ6wP tdXFxFqB+6OxFmREF19Psj9UPTKUJwkt90ENnd54H/knr3N8UfEcSRafPzK9njPg EHM4lZb5UNazbJFGxqRPv7bmAgbdwAZs3WAl9u8cYxoYgY5Fup2UCs/r9y0ib6Kt b5jq58xyTwhNmaZi1I7yMC6390Mxf11Hga+Dva8qrrpYaIGtbS/EI9I5LxnekwsQ QtuwqCrsqxnocUVSgugmgbyc6HcoPZxcXQr3EK4h8SSVZaEbmDRq9QSU8umdAUYQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjeelgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcuhfgr mhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvg hrnhepgeegveekjeetgfdvheetjeejueejgfehgfdtieduuddtkeeluefhhfffvddtvdef necuffhomhgrihhnpehgnhhurdhorhhgpdhfshhfrdhorhhgnecukfhppeeiledruddvtd drledvrddvtdeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (ool-45785cd0.dyn.optonline.net [69.120.92.208]) by mail.messagingengine.com (Postfix) with ESMTPA id 07294240057; Sat, 20 Feb 2021 19:34:02 -0500 (EST) Date: Sat, 20 Feb 2021 19:33:56 -0500 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.37 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=XLDgXM0q; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="Ln5/hUs3"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8CC8315BF0 X-Spam-Score: -1.37 X-Migadu-Scanner: scn1.migadu.com X-TUID: ccg3cfTKFoL5 On Sat, Feb 13, 2021 at 06:40:57PM -0800, Andy Tai wrote: > * gnu/packages/gnome.scm (ocrfeeder): New variable > * gnu/packages/python-xyz.scm (python-sane): New variable In general, we add packages one commit at a time, so we prefer to receive this as two patches. First, a patch that adds python-sane, and then a second patch adding ocrfeeder. > +(define-public ocrfeeder Overall LGTM, thanks! > + (synopsis "A Complete OCR Suite") I would write, simply, "Complete OCR Suite". For some reason, the linter doesn't complain for me, but it should recommend against starting synopses with an article. That is, with "a", "an", or "the". https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html > + (description "OCRFeeder is a complete Optical Character > Recognition and Document Analysis and Recognition program") And make sure to end the sentence with a period "." > +(define-public python-sane Great! > + (synopsis "Python interface to the SANE scanner") > + (description "Python interface to the SANE scanner and frame > grabber interface for Linux") We prefer to use complete sentences in the description. You can always make it simple: "This package provides Python interface to the SANE scanner and frame grabber interface for Linux." > + (license license:expat))) I looked in the repo and it doesn't look like the expat license: https://directory.fsf.org/wiki/License:Expat I'm not sure what it is? Can you do a little research? That FSF license directory might help.