From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8AS9An6JKWB1dAAA0tVLHw (envelope-from ) for ; Sun, 14 Feb 2021 20:35:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WJ4aOn2JKWAGLAAAbx9fmQ (envelope-from ) for ; Sun, 14 Feb 2021 20:35:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B043B15B2A for ; Sun, 14 Feb 2021 21:35:09 +0100 (CET) Received: from localhost ([::1]:59568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBO6m-0002Zw-SE for larch@yhetil.org; Sun, 14 Feb 2021 15:35:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBO6g-0002ZZ-Gp for guix-patches@gnu.org; Sun, 14 Feb 2021 15:35:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBO6g-00026g-9T for guix-patches@gnu.org; Sun, 14 Feb 2021 15:35:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBO6g-0006Pb-7m for guix-patches@gnu.org; Sun, 14 Feb 2021 15:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46322] [staging 2/2] gnu: pulseaudio: Use meson build system. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 14 Feb 2021 20:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46322 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Brice Waegeneire Cc: 46322@debbugs.gnu.org Received: via spool by 46322-submit@debbugs.gnu.org id=B46322.161333484224573 (code B ref 46322); Sun, 14 Feb 2021 20:35:02 +0000 Received: (at 46322) by debbugs.gnu.org; 14 Feb 2021 20:34:02 +0000 Received: from localhost ([127.0.0.1]:36833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBO5i-0006O9-46 for submit@debbugs.gnu.org; Sun, 14 Feb 2021 15:34:02 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:59625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBO5g-0006No-Q9 for 46322@debbugs.gnu.org; Sun, 14 Feb 2021 15:34:01 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E1AB0C2B; Sun, 14 Feb 2021 15:33:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 14 Feb 2021 15:33:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=5GLWl2QZxqLQYJpDNtWwUnW1 rHmPgtLODHQRqXfu+yQ=; b=Wg2jtWgTy+P02Nj87KFKHsVZBDoPh6sfjGeGaP6Q o0Y04Kzw7hZffr8IzAZ0NXxAZsQsmyFlrg8Uea7T601WDki1IMp4tK9KsHDIfJ5z nSEGveJpWxe86gx87+BJDCvwhsP/cu6qoi+R460ij0sSQQ4A+nUPt/XU1yP1ceee T9g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5GLWl2 QZxqLQYJpDNtWwUnW1rHmPgtLODHQRqXfu+yQ=; b=HH/7JuYkMg8gdgmhP/DK/O j9us+PI0q9r8g2KPYT9TjqFb7F2LJRiSq/uL133T31U6LhWulHYCKtZ+WGbTIoMr FrQqVVmac9BwroNRUVHOB4/4+OTdpX2xE8u4H7EvvYOpas/N1k+Xjtbpd4Hm7gHv dWPSTmV+HE9MG3BJ/drEPilUsR2F2i/uh/7PiIJm2C2ltWBwrt+zWh3wi5pL0UYc M8P2r9LThl68qFwLQHAkXmNn3h1GerTo7EEc/Utiew86M8Lqm2Qn1P6J8TTZDoss EA7oRQNd3nubPMVp6YKrJ0thXhAOUUyOaxUvSabsGg6NhWnJvZpwn6cXApO/wDkg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrieehgddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdortddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpefghfejleevteeuvefhheehhfevgfegvedtteetjefhfeefvdfhvddtjeejkedu feenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id A79FE1080059; Sun, 14 Feb 2021 15:33:53 -0500 (EST) Date: Sun, 14 Feb 2021 15:33:52 -0500 From: Leo Famulari Message-ID: References: <20210205075519.2935-1-brice@waegenei.re> <20210205080029.3433-2-brice@waegenei.re> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210205080029.3433-2-brice@waegenei.re> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=Wg2jtWgT; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="HH/7JuYk"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B043B15B2A X-Spam-Score: -1.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: HHGbgZfWJbNX On Fri, Feb 05, 2021 at 09:00:29AM +0100, Brice Waegeneire wrote: > * gnu/packages/pulseaudio.scm (pulseaudio)[build-system]: Switch from > gnu to meson. > [arguments]: Migrate configure flags for meson. > [propagated-inputs]: Replace 'gdbm' with 'tdb', upstream default. > + `(#:configure-flags > + (let ((out (assoc-ref %outputs "out"))) > + (list "-Doss-output=disable" > + "-Dbluez5=true" > + "-Dlocalstatedir=/var" > + (string-append "-Dudevrulesdir=" > + out "/lib/udev/rules.d") > + ;; Ensure the RUNPATH contains all installed library locations. > + (string-append "-Dc_link_args=-Wl,-rpath=" > + out "/lib/pulseaudio:" > + out "/lib:" > + out "/lib/pulse-14.2/modules"))) We should avoid hard-coding the version string with something like "/lib/pulse-" ,version "/modules" Overall LGTM for staging. Maybe you already did this but I recommend comparing the built outputs of the old and new versions to make sure we don't accidentally lose any components by using the new build system.