From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CEZaG4YRJGCLVQAA0tVLHw (envelope-from ) for ; Wed, 10 Feb 2021 17:01:58 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cKQaF4YRJGBTZwAAbx9fmQ (envelope-from ) for ; Wed, 10 Feb 2021 17:01:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 94FE49402B3 for ; Wed, 10 Feb 2021 17:01:57 +0000 (UTC) Received: from localhost ([::1]:56572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9ssG-0002Yo-4S for larch@yhetil.org; Wed, 10 Feb 2021 12:01:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9sgk-0000F6-IH for guix-patches@gnu.org; Wed, 10 Feb 2021 11:50:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45551) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9sgj-0002Ln-ST for guix-patches@gnu.org; Wed, 10 Feb 2021 11:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9sgj-0000yA-OA for guix-patches@gnu.org; Wed, 10 Feb 2021 11:50:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45692] [PATCH 0/4] Even Better ZFS Support on Guix Resent-From: raid5atemyhomework Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Feb 2021 16:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45692 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Danny Milosavljevic , "45692@debbugs.gnu.org" <45692@debbugs.gnu.org> Received: via spool by 45692-submit@debbugs.gnu.org id=B45692.16129758013716 (code B ref 45692); Wed, 10 Feb 2021 16:50:01 +0000 Received: (at 45692) by debbugs.gnu.org; 10 Feb 2021 16:50:01 +0000 Received: from localhost ([127.0.0.1]:57097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9sgi-0000xr-N4 for submit@debbugs.gnu.org; Wed, 10 Feb 2021 11:50:00 -0500 Received: from mail4.protonmail.ch ([185.70.40.27]:13189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9sgh-0000xd-KP for 45692@debbugs.gnu.org; Wed, 10 Feb 2021 11:50:00 -0500 Date: Wed, 10 Feb 2021 16:49:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1612975792; bh=OYp5BBpXT+pt7UqkRkTUinLGi8WDuTPB5HNigwwIfwc=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=qULyoRUncvnNzZX0J8eqrrLZKGy0l3huoilU5Cv2tfJId7XNjB2gEsu53soaol+uP QOdbmRsSLOR9Iv8Lej1GJL6xJQcbc8Y8YRnOgW5mwT4F8Qw62wLNXB1scRMgufAfTT o7rBfP1fF8FmKOBCopvbbKoAId6dPF4X9uGyuJJo= Message-ID: In-Reply-To: <87zh0c53m6.fsf_-_@gnu.org> References: <2yOs7mxigs8_Vx_yi858pxAkoyXmU8IidizK5grcmX4M92O5QK-_Ywo9nrHMHvzLGj4U7B9ysl26eNbiPmzmeOQsuFvp5VjouVptRfwxKng=@protonmail.com> <87zh0c53m6.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: raid5atemyhomework X-ACL-Warn: , raid5atemyhomework via Guix-patches From: raid5atemyhomework via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=qULyoRUn; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 94FE49402B3 X-Spam-Score: -2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: RZZTSq5bRKrD > > +;; Configuration for the kernel builder. > > +(define-record-type* kernel-builder-con= figuration > > > > - make-kernel-builder-configuration > > - kernel-builder-configuration? > > - this-kernel-builder-configuration > > - > > - (kernel kernel-builder-configuration-kernel (default #f)) > > - (hurd kernel-builder-configuration-hurd (default #f)) > > - (modules kernel-builder-configuration-modules (default '()))) > > How about instead? > > In general, throughout the project, we do not use =E2=80=9Ckernel= =E2=80=9D and =E2=80=9CLinux=E2=80=9D > interchangeably. Since this is a Linux-only feature, let=E2=80=99s call i= t that > way and remove the =E2=80=98hurd=E2=80=99 field (the Hurd has no notion o= f in-kernel > modules since pretty much everything happens in user-space.) The `operating-system` record uses `kernel-loadable-modules` as the record = field name. I suggest changing that first, if you truly want to differenti= ate "kernel" from "linux" "throughout the project". Or deprecate it entire= ly and instead use the new `linux-loadable-modules-service-type`, in princi= ple the only field needed in `operating-system` should be `services`. > > > +(define kernel-loadable-module-service-type > > > > - (service-type (name 'kernel-loadable-modules) > > Same here: =E2=80=98linux-loadable-module-service-type=E2=80=99. > > But=E2=80=A6 it=E2=80=99s not clear at first sight how this differs from = the existing > =E2=80=98kernel-module-loader=E2=80=99. Perhaps =E2=80=98linux-build-serv= ice-type=E2=80=99 would be > more accurate? Or am I missing something? `kernel-module-loader` explicitly loads a module at startup, it does not ma= ke a non-Linux-libre-built-in module actually *loadable*. So there is a ne= ed for something to augment the `linux-loadable-modules` record field of `o= perating-system`. Thanks raid5atemyhomework