Re: 01/03: guix-install.sh: Improve prompt_yes_no procedure.

Re: 01/03: guix-install.sh: Improve prompt_yes_no procedure.

[Lars-Dominik Braun]

Hi Maxim,

> commit 6a2e303d3a49baf7c222a70b91f453e9efd456c6
> Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> AuthorDate: Wed Oct 5 21:48:25 2022 -0400
> 
>     guix-install.sh: Improve prompt_yes_no procedure.
>     
>     * etc/guix-install.sh (_flush): New function.
>     (prompt_yes_no): Clear input, then only read the first character, silently.
>     Add the [Yes/no] string to the message.  When a newline is entered by the
>     user, treat it as the default value, which is "yes".
>     (chk_gpg_keyring): Remove "(yes/no)" from the prompt message.
>     (configure_substitute_discovery): Likewise.
>     (sys_authorize_build_farms): Likewise.
I got a report here[1] that this refactoring broke my GitHub action,
which simply pipes `yes` into guix-install.sh. Thus all pipelines
depending on https://github.com/PromyLOPh/guix-install-action are (again)
broken. Shall we revert this or do you have a quick fix at hand?

Lars

[1] https://github.com/PromyLOPh/guix-install-action/issues/16

Re: 01/03: guix-install.sh: Improve prompt_yes_no procedure.

[zimoun]

Hi,

On lun., 10 oct. 2022 at 17:44, Lars-Dominik Braun <lars@6xq.net> wrote:

> I got a report here[1] that this refactoring broke my GitHub action,
> which simply pipes `yes` into guix-install.sh. Thus all pipelines
> depending on https://github.com/PromyLOPh/guix-install-action are (again)
> broken. Shall we revert this or do you have a quick fix at hand?

Oh, indeed.  I was expected that

    bash -c 'yes | bash guix-install.sh'

would still work with ’_flush’.  Hum, why does it pass for
’chk_gpg_keyring’ and then not for ’configure_substitute_discovery’
called by ’sys_enable_guix_daemon’?


Cheers,
simon