From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0JPnIkYw7WPgDgEAbAwnHQ (envelope-from ) for ; Wed, 15 Feb 2023 20:19:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QIUXI0Yw7WM1ZgEAauVa8A (envelope-from ) for ; Wed, 15 Feb 2023 20:19:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F96094A5 for ; Wed, 15 Feb 2023 20:19:34 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSNJG-0002bL-6d; Wed, 15 Feb 2023 14:19:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSNJE-0002ZO-Ew for guix-devel@gnu.org; Wed, 15 Feb 2023 14:19:16 -0500 Received: from hera.aquilenet.fr ([2a0c:e300::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSNJC-0004Ix-GC for guix-devel@gnu.org; Wed, 15 Feb 2023 14:19:16 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 50C951927; Wed, 15 Feb 2023 20:19:10 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b_rLsIaUywrR; Wed, 15 Feb 2023 20:19:09 +0100 (CET) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0:b0aa:56dd:ae73:8afa]) by hera.aquilenet.fr (Postfix) with ESMTPSA id A9FFBA7D; Wed, 15 Feb 2023 20:19:09 +0100 (CET) Date: Wed, 15 Feb 2023 20:19:08 +0100 From: Andreas Enge To: Julien Lepiller , guix-devel@gnu.org Subject: Re: Openjdk (was: Merging core-updates?) Message-ID: References: <20230212100540.2214f16c@sybil.lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: permerror client-ip=2a0c:e300::1; envelope-from=andreas@enge.fr; helo=hera.aquilenet.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676488774; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=DffmMZbPVJZOBBSOGoVEh6r9po5ne8dZSJPKQFxR0bM=; b=t4gIXgb77LeLoxbtHqQpcsFpRTVfKL9TqBAMsFeI5ARwiI+lop7g/xNuDJ5bZCCuh0KqYq XaZsWOArxTGoJHjATGfWng5OTAJ9A/3gEiXgTzdwEnlNklCKayB4MC6svNMsyfFUSWFnZc pMVWsS2CoDwf1gPAlnodEBlqQ9UeP0wfLPCT3/oDUsy9gssy/01JH3p7hQEEdqRYCGL4mZ M3DzyMvJHXpN7xTMhoqM+X4eNtmedtWdF+Cb+FNq49CNgBsdu/fn01DY4SRe+Q6b2hRCOf BrQKOlS2J0W/F47XUzBOeNp1OMF8AKmzuS5TaxgCS35cPBB1+ez1V467en9ZXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676488774; a=rsa-sha256; cv=none; b=jTlSFpHKTNRMIz/DvTO12JkFQZX5P9As0umrKuDoTuDkU/HzkPpyvLghJ26iIz5Fz/2bmX zZtD0LlInIpvl5jKhVQ1vQSm/VUviN5tx0KSkKtq4SLqqZeOH5EJH3yku1ocVIPlaQVqeg pxV2tMTlWThAPlWgOMg1OZ8k86nhlfIjvwYDIyexHVYYEXzCeMOSPDE+oqrBDzYRsnVYci VJM0ud0MQ3pros1jN3tBOXkA1TThDaS/y8w8bNoPt/tLV33RqP+Pl2vhDWy7Rtz2WHxIMa cbItyp1+BgGo/uMOL4HnHSYBtOrI66sh52pUDqn8G1s3IJlrZ9CbsYMHJbe53g== Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.42 X-Spam-Score: -2.42 X-Migadu-Queue-Id: 4F96094A5 X-TUID: FiU/SmR2IhHt Am Wed, Feb 15, 2023 at 07:51:56PM +0100 schrieb Andreas Enge: > Actually the patch has already been applied to openjdk13, if I am not > mistaken. So I do not understand how the source could be built in master > then, while the exact same code (?!) fails on core-updates... Well, there is a somewhat hidden difference. core-updates introduces "openjdk-10-hotspot-pointer-comparison.patch" "openjdk-10-hotspot-stack-size.patch" to openjdk10. openjdk11 is a package of its own without the patch. openjdk12 uses the newly defined make-openjdk to start from openjdk11, overwriting the source together with openjdk-10-hotspot-stack-size.patch in core-updates, and without the patch in master. (And it uses an obscure tarball instead of a git checkout - why?) openjdk13 has the same code in core-updates and master: (define-public openjdk13 (make-openjdk openjdk12 "13.0.13" "0pxf4dlig61k0pg7amg4mi919hzam7nzwckry01avgq1wj8ambji")) So in core-updates it inherits the patch from openjdk12, in master it does not (I think). And then I suppose it passes the patch on to all its descendants. The following seems to work and create source for openjdk13 and later: (define-public openjdk13 (make-openjdk openjdk12 "13.0.13" "0pxf4dlig61k0pg7amg4mi919hzam7nzwckry01avgq1wj8ambji" (source (origin (inherit (package-source base)) (patches '()))))) Okay to push if I manage to build current openjdk with it? Is it necessary to keep all these version of openjdk and to bootstrap version n with version n-1? Andreas