From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WJIqDr/u9GJSkAAAbAwnHQ (envelope-from ) for ; Thu, 11 Aug 2022 13:57:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kOdDDb/u9GKu1QAAG6o9tA (envelope-from ) for ; Thu, 11 Aug 2022 13:57:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AC1F829FD4 for ; Thu, 11 Aug 2022 13:57:50 +0200 (CEST) Received: from localhost ([::1]:33418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oM6ov-0002hE-SO for larch@yhetil.org; Thu, 11 Aug 2022 07:57:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM6oA-0001x5-Qe for guix-patches@gnu.org; Thu, 11 Aug 2022 07:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oM6oA-0005ia-Et for guix-patches@gnu.org; Thu, 11 Aug 2022 07:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oM6oA-0003gt-8s for guix-patches@gnu.org; Thu, 11 Aug 2022 07:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56960] [PATCH] * gnu: Add siglo. References: In-Reply-To: Resent-From: Jean Pierre De Jesus DIAZ Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Aug 2022 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56960 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "56960@debbugs.gnu.org" <56960@debbugs.gnu.org> Received: via spool by 56960-submit@debbugs.gnu.org id=B56960.166021898414114 (code B ref 56960); Thu, 11 Aug 2022 11:57:02 +0000 Received: (at 56960) by debbugs.gnu.org; 11 Aug 2022 11:56:24 +0000 Received: from localhost ([127.0.0.1]:51971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM6nX-0003fa-Nx for submit@debbugs.gnu.org; Thu, 11 Aug 2022 07:56:24 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]:32255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM6nQ-0003f3-Tl for 56960@debbugs.gnu.org; Thu, 11 Aug 2022 07:56:20 -0400 Date: Thu, 11 Aug 2022 11:56:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeandudey.tech; s=protonmail3; t=1660218970; x=1660478170; bh=AuawaSd4LGkrlQ6gQB06SNQSvZKXrXpR+plz3g0UDYw=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=fCYwTH0+Kt4giygaYjnf7T90BJ5Tdr6dpYaUgoUejmJP9RpUjBjpjIMxIGNJ63qa4 J2v1fAf1o5qJP4hagXq8P434fhAz0cDzEtIL3wcxeUtynyKTODjIy8YIly/DPInz3o 4OFd8kpt39lVJ08zJ/y7pUA/gPy0vNghUn/DrPNSU6CX2uIQ2TBISENhS2RpXvivfe LIBI3cPVtJR2nydHYFi+InTjjZMvUfcMrcvNfNERhYO4CqRjkup+e3+TC+/ghVAhC3 EdViuFqO57FdKx2uR0GfhTpadt7Sa/IvsCEt7P1yWkuF3DVVosgS6B1OR3sFkHwfri 4TUuODXzVZNag== Message-ID: Feedback-ID: 20187791:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Jean Pierre De Jesus DIAZ X-ACL-Warn: , Jean Pierre De Jesus DIAZ via Guix-patches From: Jean Pierre De Jesus DIAZ via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660219070; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AuawaSd4LGkrlQ6gQB06SNQSvZKXrXpR+plz3g0UDYw=; b=KJl5duC6RjKh1EdSzEKZv9lpdUzQZpdrZ3klke30aaYjieqrdahAEcRjIeXcbBvowFbLMJ 9DHXt02jZd6k5XaHplg+GO85slCTYpcXk3QNPr4+INIHnkp8/M5oybaWMQYcjxsHB5QvVr xr7A5ujbZnpJnuWQzb4d7Y64ysaK1aZvITJDqrRKAlJ11kG++wKx5uiihPtn1zCa8sNhwV 2tpEQ8HlkoIUpB8K/4RQn5M2XZgDhaa4PJckSdPsnre3uxRupzq+ZZikDjKwJG6L6ssBUW WFfLHAVoE80NZdPYUCSm8tv0kGMNtu8oKiKpez2SvRn7Dt1kimIucaadJ7VjDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660219070; a=rsa-sha256; cv=none; b=nYqz8oN295yzGHpOUkCh1mFt8QMafyDBVT959KODQWrDjkMhTELIhjqlLHJgxJG3zGayH1 uF2GLKjBqldkWI+B+KzhGolOLdCxezMILJahrXbJKJ5cU4eRHfVbtdqlmYL10tbU6iJVDL AN4445lvOW2CJ6Eqqf6XKxPbnUBqR4u4esOMCb8bKIZQfZyrw3Ct6oPRpsPJa8cRmoDfpo myCnP24m4jGL7NWi6ME/LY9mvLkcGsu8MJc33pl3Pd/8OVJNgDj8TdbqE13+cEDua2WT8o Ts9vrlPxydosdYL9GBUyRXWhVMrOksnK4Puk9h2edH/hmzngL5ygRKWYbFto9A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b=fCYwTH0+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b=fCYwTH0+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AC1F829FD4 X-Spam-Score: -1.88 X-Migadu-Scanner: scn1.migadu.com X-TUID: wh16N+91uzgE Hello, Just a quick review. >+ (url (string-append "https://github.com/alexr4535/" n= ame "/")) `name' is discouraged from being used on the source URL. If the package name changes, the URL does too. Can't recall where I saw it = if on the documentation or IRC. >+ (arguments >+ `(#:glib-or-gtk? #t >+ #:phases >+ (modify-phases %standard-phases You'll probably want to use a list (argument (list ...)) instead of quasi-quoting, and also, use G-Expressions, see (guix)G-Expressions: https://guix.gnu.org/manual/en/html_node/G_002dExpressions.html As the method used for the package is being phased out. For example: (arguments (list #:glib-or-gtk? #t #:phases #~(modify-phases %standard-phases ...))) >+ (wrap-program (string-append (assoc-ref outputs "out") >+ "/bin/siglo") After using G-Expressions, this can be simplified to: (wrap-program (string-append #$output "/bin/siglo") ...) >+ (synopsis "GTK app to sync InfiniTime watch with PinePhone") GTK is an implementation detail, no need to be specified, and if necessary, better suited for the description. See (guix)Synopses and Descriptions: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html For example, variations could include: * "Application to synchronize InfiniTime with PinePhone" * "Synchronize InifniTime with PinePhone" * "Smartwatch synchronization application" * etc. Keep in mind that synopsis !=3D description. Probably someone with more exp= erience than me could correct me on this topic. >+ (description "@code{siglo} is a graphical tool to flash InfiniTime firm= ware to >+watches running the InfiniTime operating system, via bluetooth. flash -> update (non-technical term). watches -> PineTime watches (or PineTime smartwatches). bluetooth > Bluetooth. >+Users can also sync the time of their watch to the time of the device run= ning >+@code{siglo} as well as check the battery charge of their watch or what v= ersion >+of firmware their watch is running. sync -> synchronize. Maybe @itemize or @enumerate could be used to list the features provided, l= ike so: Siglo (or @code{siglo}) provides the following features: @itemize @item Retrieve the version of the InfiniTime firmware running. @item Check the battery charge. @item Synchronize the time. @end itemize >--- a/gnu/packages/flashing-tools.scm >+++ b/gnu/packages/flashing-tools.scm Not entirely sure if this belongs in this category. Or if there's another a= pplicable. =E2=80=94 Jean-Pierre De Jesus DIAZ