From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8P/LEVUs1V+YRQAA0tVLHw (envelope-from ) for ; Sat, 12 Dec 2020 20:47:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uJCBDVUs1V9rdwAAbx9fmQ (envelope-from ) for ; Sat, 12 Dec 2020 20:47:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 873F494014B for ; Sat, 12 Dec 2020 20:47:16 +0000 (UTC) Received: from localhost ([::1]:48472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koBnP-00081J-Gv for larch@yhetil.org; Sat, 12 Dec 2020 15:47:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koBN5-0004FT-Vl for guix-patches@gnu.org; Sat, 12 Dec 2020 15:20:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1koBN4-0003fF-II for guix-patches@gnu.org; Sat, 12 Dec 2020 15:20:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1koBN4-0001S7-DG for guix-patches@gnu.org; Sat, 12 Dec 2020 15:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44762] [PATCH 37/37] gnu: Add ripgrep-all. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Dec 2020 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Joseph LaFreniere Received: via spool by 44762-submit@debbugs.gnu.org id=B44762.16078043645519 (code B ref 44762); Sat, 12 Dec 2020 20:20:02 +0000 Received: (at 44762) by debbugs.gnu.org; 12 Dec 2020 20:19:24 +0000 Received: from localhost ([127.0.0.1]:46788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koBMS-0001Qx-Ae for submit@debbugs.gnu.org; Sat, 12 Dec 2020 15:19:24 -0500 Received: from flashner.co.il ([178.62.234.194]:41420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1koBMP-0001Qj-SK for 44762@debbugs.gnu.org; Sat, 12 Dec 2020 15:19:22 -0500 Received: from localhost (unknown [31.210.180.46]) by flashner.co.il (Postfix) with ESMTPSA id A99464033F; Sat, 12 Dec 2020 20:19:15 +0000 (UTC) Date: Sat, 12 Dec 2020 22:19:12 +0200 From: Efraim Flashner Message-ID: References: <20201120142716.41949-1-joseph@lafreniere.xyz> <20201120142716.41949-37-joseph@lafreniere.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bfRtNn6WgjaAy4wJ" Content-Disposition: inline In-Reply-To: <20201120142716.41949-37-joseph@lafreniere.xyz> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44762@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 873F494014B X-Spam-Score: -3.90 X-Migadu-Scanner: scn1.migadu.com X-TUID: +n7gNXqFdh+w --bfRtNn6WgjaAy4wJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I've had reviewing these patches on my TODO for a while, finally made it around to it. On Fri, Nov 20, 2020 at 08:27:16AM -0600, Joseph LaFreniere wrote: > * gnu/packages/rust-apps.scm (ripgrep-all): New variable. > --- > gnu/packages/rust-apps.scm | 80 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 79 insertions(+), 1 deletion(-) >=20 > diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm > + (add-after 'unpack 'enable-unstable-features > + (lambda _ > + (setenv "RUSTC_BOOTSTRAP" "1") > + #t))))) Is this necessary, or is it because we were using an older version of rust for building packages? > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("xz" ,xz))) > + (propagated-inputs > + `(("ffmpeg" ,ffmpeg) > + ("pandoc" ,pandoc) > + ("poppler" ,poppler) > + ("ripgrep" ,ripgrep) > + ("sqlite" ,sqlite) > + ("tar" ,tar) > + ("unzip" ,unzip) > + ("zip" ,zip))) We prefer to not propagate packages, and in particular I try not to use pandoc as an input because it limits the package to architectures that can build haskell programs. Looking through the code a bit it looks like it shells out to the commands. So it'd be better to substitute the commands to the full path name of the package (what I'd suggest for ripgrep) and/or adding a note to the description suggesting that people also install some of the other packages for more features. > + (home-page "https://github.com/phiresky/ripgrep-all") > + (synopsis "Wrapper around @code{ripgrep} with support for rich file = types") > + (description > + "ripgrep-all (rga) is a line-oriented search tool that allows you t= o look > +for a regex in a multitude of file types. rga wraps @code{ripgrep} and > +enables it to search in @file{pdf}, @file{docx}, @file{sqlite}, @file{jp= g}, > +movie subtitles (@file{mkv}, @file{mp4}), etc.") > + (license license:agpl3+))) > + > (define-public rust-cbindgen > (package > (name "rust-cbindgen") > --=20 > 2.29.1 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --bfRtNn6WgjaAy4wJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl/VJbwACgkQQarn3Mo9 g1GYMg/9G9iZqNI58TkkdiW9hZeU8iO5So6J4l8N4bvvmHE3E8tV6q3DWoBrLo8s tDD1aTW3R+Xh1Rsw60pqdpQQ4G2WcuUCtgbelzteZN67K4y4fX1T2GFKXuRMx7r2 flgu10mwfd5kaOkP01nT15JkUYL+mA+BihClalwZCQ3a6xQxXhVkJlt5CY1jTX7h x5ov7BHMjT08n4C1iBE9yJtY0AxfsrSlFSkgV2K3yXinN7iFOIYfThuybPgVh4ic yOueIgC0WP07csFWvY+YgO1WP2+eaFQCBW7lqJdbIQDWh0JzW76fEE7j4haYpFOk 85b3Ot+2LV98CEySYhOvfNjU7njGGfOgcjbWhKuddCggEGFoqW1qBUvtVhul53Fz qRvVfM6P0LY/kcUNVACrxv3QEOMBxvgOv2UwDXhgc5ToAW9kKbmd7gRDCKs0SNYa IyaRaGMnVvYn7NwLo9l7mlKUFGZin4LI/+bIn4JoFUxKwYFox7fxj7BcYws0TZTJ ignDsXhdyefhtq1Z1JPFFdV65eGpMmLbv36+5bYLvxS7zn5CbfOC7554b0lhXTEj srTbanO89bpyPWjouvZ/uxq112We/O/4vRcwkGgCMX2b9ZUNRldu6Zsx68skT0SI kbuqoikS3bZyKh6PdaJ9nK8g5tErkycw5YmhYUmQzrKI9FyHxMs= =sTaX -----END PGP SIGNATURE----- --bfRtNn6WgjaAy4wJ--