bug#45058: Duplicate inputs with Crate importer

bug#45058: Duplicate inputs with Crate importer

[Nicolas Goaziou]

Hello,

I noticed the Crate importer sometimes returns duplicate inputs. For
example

    guix import crate bat

returns

    ...
    (arguments
      `(#:cargo-inputs
        (("rust-ansi-colours" ,rust-ansi-colours-1)
         ("rust-ansi-term" ,rust-ansi-term-0.12)
         ("rust-atty" ,rust-atty-0.2)
         ("rust-clap" ,rust-clap-2)
         ("rust-clap" ,rust-clap-2)
         ...

Regards,
-- 
Nicolas Goaziou

bug#45058: Duplicate inputs with Crate importer

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

On Sat, Dec 05, 2020 at 10:03:45PM +0100, Nicolas Goaziou wrote:
> Hello,
> 
> I noticed the Crate importer sometimes returns duplicate inputs. For
> example
> 
>     guix import crate bat
> 
> returns
> 
>     ...
>     (arguments
>       `(#:cargo-inputs
>         (("rust-ansi-colours" ,rust-ansi-colours-1)
>          ("rust-ansi-term" ,rust-ansi-term-0.12)
>          ("rust-atty" ,rust-atty-0.2)
>          ("rust-clap" ,rust-clap-2)
>          ("rust-clap" ,rust-clap-2)
>          ...

As noted here¹ rust-clap-2 is listed as both a dependency and a
build-dependency. For the sake of completeness, there are also packages
which require the same crate+version for cargo-dev-input and a looser
version requirement for cargo-input. It seems worthwhile to deduplicate
the cargo-inputs, since it's a combination of 'dependencies' and 'build
dependencies', but I'm not sure about removing duplicates when they
appear in both cargo-inputs and cargo-development-inputs.


¹ https://crates.io/crates/bat

> 
> Regards,
> -- 
> Nicolas Goaziou
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]