From: Leo Famulari <leo@famulari.name>
To: EuAndreh <eu@euandre.org>
Cc: 44821-done@debbugs.gnu.org
Subject: bug#44821: [PATCH v4] gnu: Add diff-so-fancy.
Date: Sat, 5 Dec 2020 12:56:56 -0500 [thread overview]
Message-ID: <X8vJ6E85QxSPkzc8@jasmine.lan> (raw)
In-Reply-To: <20201205115542.15427-1-eu@euandre.org>
On Sat, Dec 05, 2020 at 08:55:42AM -0300, EuAndreh wrote:
> From: Leo Famulari <leo@famulari.name>
>
> * gnu/packages/version-control.scm (diff-so-fancy): New variable.
> ---
> Thanks for the revised patch. The only thing missing was the proper
> escaping of the substituted path:
> (string-append "use lib '" lib "';\n")))
>
> The lib path had to be between quotes, with a final semicolon.
>
> I've taken yours and only fixed this part. I've tested it, and it works.
Great! Pushed as 32a3367930844b242b57ea634c2de43e4ea3b57b
prev parent reply other threads:[~2020-12-05 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <871rg5o26c.fsf@euandre.org>
2020-12-04 20:08 ` [bug#44821] [PATCH v3] gnu: Add diff-so-fancy EuAndreh via Guix-patches via
2020-12-05 5:14 ` Leo Famulari
2020-12-05 11:55 ` [bug#44821] [PATCH v4] " EuAndreh via Guix-patches via
2020-12-05 17:56 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8vJ6E85QxSPkzc8@jasmine.lan \
--to=leo@famulari.name \
--cc=44821-done@debbugs.gnu.org \
--cc=eu@euandre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.