From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4IZQDAfOyl+RTwAA0tVLHw (envelope-from ) for ; Sat, 05 Dec 2020 00:02:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8MkQCAfOyl/qIQAAbx9fmQ (envelope-from ) for ; Sat, 05 Dec 2020 00:02:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DCE4E940484 for ; Sat, 5 Dec 2020 00:02:14 +0000 (UTC) Received: from localhost ([::1]:50156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klL1h-0006Kl-NZ for larch@yhetil.org; Fri, 04 Dec 2020 19:02:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klL1X-0006KU-Co for guix-patches@gnu.org; Fri, 04 Dec 2020 19:02:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klL1W-0005PL-Lc for guix-patches@gnu.org; Fri, 04 Dec 2020 19:02:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klL1W-0000lv-JH for guix-patches@gnu.org; Fri, 04 Dec 2020 19:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44913] [PATCH] gnu: ruby-rubocop-ast: Update to 1.2.0. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Dec 2020 00:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44913 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44913@debbugs.gnu.org X-Debbugs-Original-To: =?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn_?= =?UTF-8?Q?Fern=C3=A1ndez?= via Guix-patches via X-Debbugs-Original-Cc: 44913@debbugs.gnu.org Received: via spool by 44913-submit@debbugs.gnu.org id=B44913.16071265022932 (code B ref 44913); Sat, 05 Dec 2020 00:02:02 +0000 Received: (at 44913) by debbugs.gnu.org; 5 Dec 2020 00:01:42 +0000 Received: from localhost ([127.0.0.1]:46183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klL1C-0000lD-Cs for submit@debbugs.gnu.org; Fri, 04 Dec 2020 19:01:42 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klL1B-0000kp-BW for 44913@debbugs.gnu.org; Fri, 04 Dec 2020 19:01:41 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 139885C00EB; Fri, 4 Dec 2020 19:01:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 04 Dec 2020 19:01:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=+bBnLYLd7KIBarbkSAQjiUlqH0gcE6y6pibweNA3FFs=; b=KFm9KIIN/lBK cW0YmP/OggDXlvyEr/1seo0V7jewAHlcCiASuAZhk9MIbSeWDNQ0YrxudFCL+Pm8 /UvAgxRy4uPJSVtNM6MENIM9jDPOjYCZ8aKbcLAyKZz000+qQ4DVOvDox262cZnF ahdWMJsyuUyH/4ZqGuKs88ZLqKOrE2o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+bBnLYLd7KIBarbkSAQjiUlqH0gcE6y6pibweNA3F Fs=; b=eDARVooYbB8eh+P8nTlLpl0OasxXkiL3qM5Y3M7/LF/V1zSdLIjWNfgdF bq+JTqWz3uZlrqXTlz5If8sMLCAcBv6e2pvNU8Qsq6zNbZcLnbf1yGz0JmwS4hti T+BAOYrnTpUyknBInNF0AI3Aro22wB+VHi7kKta7BSkZVCXkUH6oSLQcQYnb0am5 P9Vebak39nhQQhR4N9bWI4AlcOjAZV1IqBkckdJC2qMK8oAkRZ+Kd1Tpaprem1h7 BkHc7xuRcy80B2Eqc6xyVFTwRvRqoe0Ov8et1rcO+YD91bvQTwRZm7K3NlUTavTe VIAUcGjoRreOHbs734CM0R89H1T/A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeiledgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtudenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepveevgfdvjeffudffleeuueegtedvvdfgteejffefteffteffudeugeekgfdt tddvnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeefrddugedurdduvd ejrddugeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 43B081080059; Fri, 4 Dec 2020 19:01:35 -0500 (EST) Date: Fri, 4 Dec 2020 19:01:33 -0500 From: Leo Famulari Message-ID: References: <42cadfd1-f719-ac23-924b-c964775dad1d@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <42cadfd1-f719-ac23-924b-c964775dad1d@mailbox.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=KFm9KIIN; dkim=fail (headers rsa verify failed) header.d=messagingengine.com header.s=fm1 header.b=eDARVooY; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DCE4E940484 X-Spam-Score: -1.29 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: 3QNKd5BGVQCo On Fri, Nov 27, 2020 at 11:22:44PM +0100, Tomás Ortín Fernández via Guix-patches via wrote: > * gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0. Thanks! > (source > (origin > - (method git-fetch) ;no test suite in distributed gem > - (uri (git-reference > - (url "https://github.com/rubocop-hq/rubocop-ast") > - (commit (string-append "v" version)))) > - (file-name (git-file-name name version)) > + (method url-fetch) > + (uri (rubygems-uri "rubocop-ast" version)) > (sha256 > (base32 > - "1ycf6qcj8nbzk2js72priim4642lkn56w5kbny1nlryjkckxgm04")))) > + "0q0kdi89ad7dd1xmzrdf5ikk32bllzr68hf4x8fd7azcv5jnch2l")))) > (build-system ruby-build-system) > (arguments > - `(#:test-target "spec" > - #:phases (modify-phases %standard-phases > - (add-after 'unpack 'disable-bundler > - (lambda _ > - (substitute* "Rakefile" > - (("Bundler\\.setup.*") "nil\n")) > - #t)) > - (replace 'replace-git-ls-files > - (lambda _ > - (substitute* "rubocop-ast.gemspec" > - (("`git ls-files(.*)`" _ files) > - (format #f "`find ~a -type f| sort`" files))) > - #t))))) > + '(#:tests? #f)) ; tests not included in gem The commit message should describe the changes to the code. For example, I might write it this way: ------ gnu: ruby-rubocop-ast: Update to 1.2.0. * gnu/packages/ruby.scm (ruby-rubocop-ast): Update to 1.2.0. [source]: Fetch source from rubygems. [arguments]: Remove obsolete 'disable-bundler' phase. Skip the test suite. ------ This helps communicate your intentions to reviewers (and everyone else). For example, why does the patch remove the 'disable-bundler' phase? If that phase is no longer needed, it helps to describe it as obsolete in the commit message. The code comment about why the tests are skipped is really useful, for the same reason. But we can't add comments about code that is removed :) Does that make sense? Can you send a revised patch with a complete commit message? It's fine to copy what I wrote if it is accurate.