From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aBEKGMOjyl+YdQAA0tVLHw (envelope-from ) for ; Fri, 04 Dec 2020 21:01:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sOXTE8Ojyl/sJAAA1q6Kng (envelope-from ) for ; Fri, 04 Dec 2020 21:01:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1F7D9404CC for ; Fri, 4 Dec 2020 21:01:54 +0000 (UTC) Received: from localhost ([::1]:55884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klIDB-0001Nv-HP for larch@yhetil.org; Fri, 04 Dec 2020 16:01:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klH0o-0007Nu-To for guix-patches@gnu.org; Fri, 04 Dec 2020 14:45:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klH0o-0003X1-HW for guix-patches@gnu.org; Fri, 04 Dec 2020 14:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klH0o-0000nq-Fs for guix-patches@gnu.org; Fri, 04 Dec 2020 14:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44882] [PATCH] gnu: ruby-solargraph: Update to 0.39.17 and add two dependencies Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Dec 2020 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44882 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44882@debbugs.gnu.org X-Debbugs-Original-To: =?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn_?= =?UTF-8?Q?Fern=C3=A1ndez?= via Guix-patches via X-Debbugs-Original-Cc: 44882@debbugs.gnu.org Received: via spool by 44882-submit@debbugs.gnu.org id=B44882.16071110662992 (code B ref 44882); Fri, 04 Dec 2020 19:45:02 +0000 Received: (at 44882) by debbugs.gnu.org; 4 Dec 2020 19:44:26 +0000 Received: from localhost ([127.0.0.1]:45911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klH0D-0000m5-OX for submit@debbugs.gnu.org; Fri, 04 Dec 2020 14:44:26 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:43727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klH06-0000le-6N for 44882@debbugs.gnu.org; Fri, 04 Dec 2020 14:44:18 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 561A482C; Fri, 4 Dec 2020 14:44:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 04 Dec 2020 14:44:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=nowiZ90Dmsl+SgFiGE7/YQhbpPYvWapAVB7lhKBqgg4=; b=uZSkgwnj7A6Y fOP2o3A+5NqW8eIn+SUv5go+4/8pnvN+UzOVMTy6+ThQDTxB9pqqtcGC/YyvtkYo 0xeacYDfxPN2dP2NOL6UbF+xdnMbcaFZzFiJiMLmgjNLlR5KQSZhjifqLU8DL70t GHBSJoXGTAoo19hy3ZfDQM4LRFcDbZU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=nowiZ90Dmsl+SgFiGE7/YQhbpPYvWapAVB7lhKBqg g4=; b=RtVCPwheQME2/+h/No8Rdtcev7CEL6BMABdD3yl0qxdHDCPLZHGXlZgvs /KJ45fMjCm4JzDml17RqlQuhV2m7Msf6rC8SNjQOvDXopNaJ8oLRh5qndwpeWge7 SH5wWGYMcHBnuarMOgitXkMdxHiz4poyy0c4aQx1FxNAyp5aDnSyyszXmZxXhYjR TRUGXHGiSB1WBxFcbuRaaIGK0y9IwhXzYNg2CQQ4Aa+aF31uAvyDlBoWNVRNt7Xw D9LitmRCpAXXS06RevTfJyPuYZx99/oQFrmDcjiGx41Go5RrwEtZi/khH7iEWNMG V0FyApmCdhdKa5v5mNAdcTaIojr/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeikedguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggugfgjsehmkeerredttddunecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeevjeelhfejvdekvefgkefguedtgfekudfgteevffejfeelvdfgjeetueet teffffenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghm vg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 72480108005B; Fri, 4 Dec 2020 14:44:10 -0500 (EST) Date: Fri, 4 Dec 2020 14:44:08 -0500 From: Leo Famulari Message-ID: References: <55bea941-e029-69b7-0603-5548567659ef@mailbox.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="v0pLRUu/sp2Bh2wb" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55bea941-e029-69b7-0603-5548567659ef@mailbox.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.29 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=famulari.name header.s=mesmtp header.b=uZSkgwnj; dkim=fail (headers rsa verify failed) header.d=messagingengine.com header.s=fm1 header.b=RtVCPwhe; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D1F7D9404CC X-Spam-Score: -0.29 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: 3svWZe9rXiqC --v0pLRUu/sp2Bh2wb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Nov 26, 2020 at 11:02:11AM +0100, Tomás Ortín Fernández via Guix-patches via wrote: > * gnu/packages/ruby.scm (ruby-solargraph): Update to 0.39.17. > * gnu/packages/ruby.scm (ruby-e2mmap): New variable. > * gnu/packages/ruby.scm (ruby-benchmark): New variable. Thanks! I read your followup email but I'm also replying with some advice about this patch. First, this patch should be split into 3 patches. Each new package should be added in its own patch, and then the solargraph update should be the third patch. > +(define-public ruby-e2mmap > + (package > + (name "ruby-e2mmap") > + (version "0.1.0") > + (source > + (origin > + (method url-fetch) > + (uri (rubygems-uri "e2mmap" version)) > + (sha256 > + (base32 > + "0n8gxjb63dck3vrmsdcqqll7xs7f3wk78mw8w0gdk9wp5nx6pvj5")))) > + (build-system ruby-build-system) > + (propagated-inputs > + `(("bundler" ,bundler))) Is this 'bundler' really used? If so, is it used only at build time? In that case, it would be a native input. I checked that the built ruby-e2mmap doesn't keep a reference to bundler, and thus wouldn't be able to find it at run-time: ------ $ guix gc --references $(./pre-inst-env guix build --no-grafts ruby-e2mmap) /gnu/store/8ql9jjzl8q291ghsxlkm1wn5bpdvgcqw-ruby-2.6.5 /gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16 ------ > + (description > + "Module for defining custom exceptions with specific messages.") Descriptions should be "complete sentences". For example, this could be written as "This package provides a Ruby module for defining custom exceptions with specific messages." I've attached a revised patchset to show what I mean. I was going to push these revised patches until I read your followup message. --v0pLRUu/sp2Bh2wb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename=solargraph-patches Content-Transfer-Encoding: 8bit >From 50a2b025fade3fc2a305cd78d1611c516fe47510 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Ort=C3=ADn=20Fern=C3=A1ndez?= Date: Fri, 4 Dec 2020 14:16:15 -0500 Subject: [PATCH 1/3] gnu: Add ruby-e2mmap. * gnu/packages/ruby.scm (ruby-e2mmap): New variable. --- gnu/packages/ruby.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index 8fc228f6ed..939a686114 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -23,6 +23,7 @@ ;;; Copyright © 2020 Maxim Cournoyer ;;; Copyright © 2020 Nicolas Goaziou ;;; Copyright © 2020 Michael Rohleder +;;; Copyright © 2020 Tomás Ortín Fernández ;;; ;;; This file is part of GNU Guix. ;;; @@ -11637,6 +11638,26 @@ checking.") (home-page "https://solargraph.org/") (license license:expat))) +(define-public ruby-e2mmap + (package + (name "ruby-e2mmap") + (version "0.1.0") + (source + (origin + (method url-fetch) + (uri (rubygems-uri "e2mmap" version)) + (sha256 + (base32 + "0n8gxjb63dck3vrmsdcqqll7xs7f3wk78mw8w0gdk9wp5nx6pvj5")))) + (build-system ruby-build-system) + (arguments + `(#:tests? #f)) ;; There is a rakefile but no tests + (synopsis "Define custom exceptions for Ruby") + (description "This package provides a Ruby module for defining custom +exceptions with specific messages.") + (home-page "https://github.com/ruby/e2mmap") + (license license:bsd-2))) + (define-public ruby-wayback-machine-downloader (package (name "ruby-wayback-machine-downloader") -- 2.29.2 >From d1868eddf03ae24fc7ffbeb920e95a06838f6a8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Ort=C3=ADn=20Fern=C3=A1ndez?= Date: Fri, 4 Dec 2020 14:16:49 -0500 Subject: [PATCH 2/3] gnu: Add ruby-benchmark. * gnu/packages/ruby.scm (ruby-benchmark): New variable. --- gnu/packages/ruby.scm | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index 939a686114..bc1ca15d67 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -11658,6 +11658,24 @@ exceptions with specific messages.") (home-page "https://github.com/ruby/e2mmap") (license license:bsd-2))) +(define-public ruby-benchmark + (package + (name "ruby-benchmark") + (version "0.1.0") + (source + (origin + (method url-fetch) + (uri (rubygems-uri "benchmark" version)) + (sha256 + (base32 + "0jadlpsl504ql436a6bx8ihp0bkg3rvxg7fbi4r1bmra3cqz0h88")))) + (build-system ruby-build-system) + (synopsis "Performance benchmarking for Ruby") + (description "This package provides methods for benchmarking Ruby code, +giving detailed reports on the time taken for each task.") + (home-page "https://github.com/ruby/benchmark") + (license license:bsd-2))) + (define-public ruby-wayback-machine-downloader (package (name "ruby-wayback-machine-downloader") -- 2.29.2 >From 9c8dd05ef67013b4599be78e21976b618b4d7e97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Ort=C3=ADn=20Fern=C3=A1ndez?= Date: Fri, 4 Dec 2020 14:17:09 -0500 Subject: [PATCH 3/3] gnu: ruby-solargraph: Update to 0.39.17. * gnu/packages/ruby.scm (ruby-solargraph): Update to 0.39.17. [propagated-inputs]: Add ruby-benchmark and ruby-e2mmap. --- gnu/packages/ruby.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index bc1ca15d67..146263e0af 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -11587,19 +11587,20 @@ application.") (define-public ruby-solargraph (package (name "ruby-solargraph") - (version "0.36.0") + (version "0.39.17") (source (origin (method url-fetch) (uri (rubygems-uri "solargraph" version)) (sha256 (base32 - "0b93xzkgd1h06da9gdnwivj1mzbil8lc072y2838dy6i7bxgpy9i")))) + "06fby6dpq1jcq30x8ladig4dvz8j2pxd08mkrad3d41jx33zd2hg")))) (build-system ruby-build-system) (propagated-inputs `(("ruby-backport" ,ruby-backport) ("bundler" ,bundler) - ("ruby-htmlentities" ,ruby-htmlentities) + ("ruby-benchmark" ,ruby-benchmark) + ("ruby-e2mmap" ,ruby-e2mmap) ("ruby-jaro-winkler" ,ruby-jaro-winkler) ("ruby-maruku" ,ruby-maruku) ("ruby-nokogiri" ,ruby-nokogiri) -- 2.29.2 --v0pLRUu/sp2Bh2wb--