[bug#45232] [PATCH] gnu: Add python-pdftotext.

[bug#45232] [PATCH] gnu: Add python-pdftotext.

[Z572]

[-- Attachment #1: python-pdftotext.patch --]
[-- Type: text/x-patch, Size: 1290 bytes --]

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index a06f351aae..817c6a27c8 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -21,6 +21,7 @@
 ;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
 ;;; Copyright © 2020 Timotej Lazar <timotej.lazar@araneo.si>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
+;;; Copyright © 2020 Zheng Junjie <873216071@qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -309,6 +310,25 @@ When present, Poppler is able to correctly render CJK and Cyrillic text.")
 Poppler PDF rendering library.")
     (license license:lgpl2.1+)))
 
+(define python-pdftotext
+  (package
+    (name "python-pdftotext")
+    (version "2.1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pdftotext" version))
+       (sha256
+        (base32
+         "19la1cw1hmkcr8big04gm2dd5fw0y0z97g930aiy29s1gaqbiblq"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("poppler" ,poppler)))
+    (home-page "https://github.com/jalan/pdftotext")
+    (synopsis "Simple PDF text extraction")
+    (description "Simple PDF text extraction")
+    (license license:expat)))
+
 (define-public libharu
   (package
    (name "libharu")

[bug#45232] [PATCH] gnu: Add python-pdftotext.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2188 bytes --]

This looks good, I've been looking for more options for viewing test
from PDFs. A couple of comments inline in the patch:

On Mon, Dec 14, 2020 at 11:34:41AM +0800, Z572 wrote:
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index a06f351aae..817c6a27c8 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -21,6 +21,7 @@
>  ;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
>  ;;; Copyright © 2020 Timotej Lazar <timotej.lazar@araneo.si>
>  ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> +;;; Copyright © 2020 Zheng Junjie <873216071@qq.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -309,6 +310,25 @@ When present, Poppler is able to correctly render CJK and Cyrillic text.")
>  Poppler PDF rendering library.")
>      (license license:lgpl2.1+)))
>  
> +(define python-pdftotext

This should be define-public, otherwise we won't be able to find the
package. Also, this looks like you can rename it to just pdftotext, the
python part of the name doesn't look necessary to me.

> +  (package
> +    (name "python-pdftotext")
> +    (version "2.1.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "pdftotext" version))
> +       (sha256
> +        (base32
> +         "19la1cw1hmkcr8big04gm2dd5fw0y0z97g930aiy29s1gaqbiblq"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("poppler" ,poppler)))

This shouldn't be propagated. If the output references poppler than a
regular input is fine. If it doesn't then the source should be patched
to use the package from the store.

> +    (home-page "https://github.com/jalan/pdftotext")
> +    (synopsis "Simple PDF text extraction")
> +    (description "Simple PDF text extraction")

This should be a full sentence.

> +    (license license:expat)))
> +
>  (define-public libharu
>    (package
>     (name "libharu")
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#45232] [PATCH] gnu: Add python-pdftotext.

[Z572]

[-- Attachment #1: Type: text/plain, Size: 51 bytes --]


Sorry, I missed this email. This is a new patch.


[-- Attachment #2: 0001-gnu-Add-python-pdftotext.patch --]
[-- Type: text/x-patch, Size: 1971 bytes --]

From cd5bd94991327a12715431e75e0c19f68ad48183 Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Fri, 25 Dec 2020 13:56:16 +0800
Subject: [PATCH] gnu: Add python-pdftotext.

---
 gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index acde5a5e5e..9d9c298076 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -93,6 +93,7 @@
 ;;; Copyright © 2020 Diego N. Barbato <dnbarbato@posteo.de>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler@student.tugraz.at>
 ;;; Copyright © 2019 Kristian Trandem <kristian@devup.no>
+;;; Copyright © 2020 Zheng Junjie <873216071@qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -158,6 +159,7 @@
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages openstack)
   #:use-module (gnu packages pcre)
+  #:use-module (gnu packages pdf)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages photo)
   #:use-module (gnu packages pkg-config)
@@ -4861,6 +4863,25 @@ algorithm.  Patiencediff provides a good balance of performance, nice output for
 humans, and implementation simplicity.")
     (license license:gpl2)))
 
+(define-public python-pdftotext
+  (package
+    (name "python-pdftotext")
+    (version "2.1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pdftotext" version))
+       (sha256
+        (base32
+         "19la1cw1hmkcr8big04gm2dd5fw0y0z97g930aiy29s1gaqbiblq"))))
+    (build-system python-build-system)
+    (inputs
+     `(("poppler" ,poppler)))
+    (home-page "https://github.com/jalan/pdftotext")
+    (synopsis "Simple PDF text extraction")
+    (description "Pdftotext is a Python library of PDF text extraction.")
+    (license license:expat)))
+
 (define-public python-pyparsing
   (package
     (name "python-pyparsing")
-- 
2.29.2

bug#45232: [PATCH] gnu: Add python-pdftotext.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

Thanks! Patch pushed.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]