From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55454) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hk1GL-00026i-8i for guix-patches@gnu.org; Sun, 07 Jul 2019 03:07:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hk1GK-00040U-43 for guix-patches@gnu.org; Sun, 07 Jul 2019 03:07:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47270) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hk1GK-00040Q-0e for guix-patches@gnu.org; Sun, 07 Jul 2019 03:07:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hk1GJ-0005ds-QA for guix-patches@gnu.org; Sun, 07 Jul 2019 03:07:03 -0400 Subject: [bug#35810] [PATCH] Add RMassBank (r-massbank) [CLOSING THIS ONE] References: <0Wmcjgq-bpYQvMH_nhfAPRc8siXsADDFk0tfLvj-4onlp3m2aBbTJXEwrtdpbwWpgQnzn7-P8Hc6Gpq32B4rMmOq1GV8MkP75J2YJxSVMVs=@protonmail.com> In-Reply-To: <0Wmcjgq-bpYQvMH_nhfAPRc8siXsADDFk0tfLvj-4onlp3m2aBbTJXEwrtdpbwWpgQnzn7-P8Hc6Gpq32B4rMmOq1GV8MkP75J2YJxSVMVs=@protonmail.com> Resent-Message-ID: Date: Sun, 07 Jul 2019 07:06:24 +0000 From: Todor =?UTF-8?Q?Kondi=C4=87?= Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Todor =?UTF-8?Q?Kondi=C4=87?= Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: "35810@debbugs.gnu.org" <35810@debbugs.gnu.org> Too much time has passed and the number of mass spec packages in our channe= l https://git-r3lab.uni.lu/eci/eci-pkg-menu.git grew. Will issue a new patc= h request once I am sure how to integrate so many packages at once into gui= x. Thanks, Todor =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Friday, 24 May 2019 17:59, Ludovic Court=C3=A8s wrote: > Hello Todor, > > Tk tk.code@protonmail.com skribis: > > > Some of us at ECI (Environmental Cheminformatics), LCSB, University of = Luxembourg > > are in love with Scheme, GNU, Guile and Guix. > > Heh, cool. :-) > > > At ECI, there is a lot of mass spectrometry going on and there are plen= ty of > > R tools -- some written by us -- to analyse and annotate such spectra. = Anyway, > > this is our first contribution to Guix -- RMassBank (r-massbank package= ). > > I have decided to create a separate package group for mass-spectrometry= and > > include r-massbank in it. I could imagine packages defined here to end = up in > > chemistry.scm, or under a new subpath, chemistry/mass-spectrometry.scm.= Once > > this first submission enters Guix, some more will follow. > > The packages themselves have been generated using > > `guix import cran -r --archive=3Dbioconductor RMassBank` and minimally = altered > > to build successfully and not bother guix lint too much. > > Looks good to me. Ricardo, WDYT? > > > As this is my first contribution to guix, I am very much looking forwar= d > > to feedback. > > The file is OK as-is, but could you send directly the output of =E2=80= =98git > format-patch=E2=80=99? That makes it easier for us to apply the patch whi= le > preserving authorship information. > > Also, bonus points if you can come up with a commit log that follows our > conventions. :-) > > https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.= html > > Anyway, glad to see more scientists join! You might be interested in > https://guix-hpc.bordeaux.inria.fr/ too. > > Welcome! > > Thanks, > Ludo=E2=80=99.