From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oKTLHKJL5mWeDgEAqHPOHw:P1 (envelope-from ) for ; Mon, 04 Mar 2024 23:30:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id oKTLHKJL5mWeDgEAqHPOHw (envelope-from ) for ; Mon, 04 Mar 2024 23:30:58 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=incana.org header.s=gm1 header.b=THyRKip7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1709591458; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=GVz4EPDxP003SrM8aIyeS8WeeTskojIyoQviyQ/r2pY=; b=EGDMyJoMSlkv/BpLni/HtnRG97XRJgnlG9QXJ7w29jsLtwdiILwJ3mWwSjijagtUvGSj0c SU6X+V/QdmpX5Gw+OjrCeHc12HVFvcD72H9/DTkW4c5dK6xHJrlMtKn1ccCdSE0wCcIFk4 vgGWnOzdAmFAwx8mCVYiQyY3PPX2il98vkQECNxEE1O+z5eQj8XnkByPrI2U+0s4xsHEoG HGaR8rmgU2GcNUVlqFjgQWAXJ3b6QAIQ9kVwxKMzB2BaVjEbiTdEEHQwbcpcsYnH/HQcdu KiLx3dJ+ppezpzMtC5UR23KAio9EG3/0OKTWCDcHw7LEde/6EYtgKVKJZD9sMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=incana.org header.s=gm1 header.b=THyRKip7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1709591458; a=rsa-sha256; cv=none; b=tso8NKAL6/fSUdynFsqZLLxt3qtufD2o/6cDsjU/fl1GA9Mu94FTlY8dA9aAMR4BQxu0az DaQvGzLwGrgnsjda2mUn8aLXXWgSqZt+Vr+QQFSRqEktfZjF9dczUiyaBj8r68exAekoy5 HHSJzj97wCMqlay+4P1j/t+5YR2o+V367FgCN7QfRtblctaCJq8/QDnzYYRVTfkJI73oE5 LlzOePy0vYW3vrMlGS1dYd10ZC0uK67RVSMl8Z6Rwehw3tqwyQ0tt5p+tebXYJU0ctKy0K /rbY8k0aYss6F4VtPK/hfDF0ypbO74JcO9o0CkD99I0MtSm0s8TFQ4sKSanFUQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 64ED766F16 for ; Mon, 4 Mar 2024 23:30:58 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhGpa-0003Bw-Fg; Mon, 04 Mar 2024 17:30:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhGpN-0003AF-1W for guix-patches@gnu.org; Mon, 04 Mar 2024 17:30:33 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhGpM-0006HS-NL for guix-patches@gnu.org; Mon, 04 Mar 2024 17:30:32 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rhGpq-0004Bx-HQ for guix-patches@gnu.org; Mon, 04 Mar 2024 17:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69552] [PATCH 2/2] gnu: Add cyclone. References: In-Reply-To: Resent-From: Juliana Sims Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Mar 2024 22:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69552 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: takev@disroot.org Cc: 69552@debbugs.gnu.org Received: via spool by 69552-submit@debbugs.gnu.org id=B69552.17095914097641 (code B ref 69552); Mon, 04 Mar 2024 22:31:02 +0000 Received: (at 69552) by debbugs.gnu.org; 4 Mar 2024 22:30:09 +0000 Received: from localhost ([127.0.0.1]:45178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhGoy-0001xg-Jl for submit@debbugs.gnu.org; Mon, 04 Mar 2024 17:30:09 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:45879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhGov-0001Y4-F2 for 69552@debbugs.gnu.org; Mon, 04 Mar 2024 17:30:06 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2822F40004; Mon, 4 Mar 2024 22:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=incana.org; s=gm1; t=1709591369; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=GVz4EPDxP003SrM8aIyeS8WeeTskojIyoQviyQ/r2pY=; b=THyRKip7GuoPcKg4kB7dj6iP3sOBpy16Ko388hEK+5y0P4IjOaMdZHSRQoEqY1xxbrOq2i WB2RBrv4IhE6assSFuXsBqjV6rkseN2rWUF2eHNbd2RA9GSIW4dSgV+dLqRgacuSB56TVX qZ5OtBNHrrUUYhTwblGDeBXhkbH9D1u4kLrPpyV4xKUKwB/2e2j9XiDKNIJPgYJJSrEZRY PHuNSZrm4sbR7ulF8Kr6XX1kk+FOz4oX7IxpljoalENluwpn5r0p6Z19AyWgdtjVFgJdec tUnkJpYWhQVRpYuC6r3DnkYgmgd2tRuCbP+qMGMEUXJdaqcIStAnBlNh61/fHg== Date: Mon, 04 Mar 2024 17:29:17 -0500 From: Juliana Sims Message-Id: X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-GND-Sasl: juli@incana.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: d5fdc31b60a312330fa23039ad8c9a4b153667f8.1709580311.git.takev@disroot.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.37 X-Spam-Score: -2.37 X-Migadu-Queue-Id: 64ED766F16 X-Migadu-Scanner: mx13.migadu.com X-TUID: 9b4ECM+AGaob Hello, Thanks for this patch! It's always good to get more Scheme into Guix :) From a purely technical perspective, there's nothing wrong with these patches. They build fine, are reproducible, and seem well-enough-styled for all practical purposes. Make sure to run `guix lint` over the patches; I get a couple warnings when I do that locally. As a sidenote, Cyclone fails to build on a supported architecture (aarch64) because the `ck` package fails to build there. Interestingly, it builds fine on 32-bit ARM (armhf). I note this merely for posterity and anyone interested in fixing `ck`. Everything builds just fine on x86(_64). What follows is largely stylistic feedback. First patch: > ;; cyclone is self-hosted. To build it, we require the bootstrapped compiler. I would capitalize "Cyclone" here and elsewhere; it seems to be capitalized in the project's prose about it. Also, this is the "bootstrap" compiler -- the "bootstrapped" compiler would be the compiler compiled with this one. > (synopsis "Install Cyclone Scheme on your machine.") This is inaccurate as this package does not install Cyclone Scheme on the user's machine. Perhaps simply "Cyclone Scheme bootstrap compiler" or "Bootstrap Cyclone Scheme" would work? Synopses are, notably, not meant to be complete sentences and thus should not have final punctuation. > (description "Bootstrap the generate the cyclone scheme compiler") This description is a bit short. I would just combine the first two paragraphs of the project README into one with minor edits to get the following description string: "Cyclone Scheme is a brand-new, R7RS Scheme-to-C compiler that uses a variant of Cheney on the MTA to implement full tail recursion, continuations, and generational garbage collection. This package uses intermediate code generated by compiling the Scheme source files to build and install Cyclone Scheme. The compiler is self-hosting and cannot be built directly on a system without Cyclone binaries installed." Strictly speaking, "brand new" does not need a hyphen, but that's the way the project writes it so I've left it as-is. You probably also want to add a linebreak after `description` so the string starts on its own line; imo this makes the line alignment more esthetically pleasing when complying with the 80-column width limit. Second patch: > ;; the bootstrapped compiler and final compiler share most build reqs "bootstrapped" -> "bootstrap" > (synopsis "Fast R7RS scheme which compiles to C") Capitalize "Scheme." This could also just be "Fast R7RS Scheme-to-C compiler" if you want. > (description > "A brand-new compiler that allows practical application > development using R7RS Scheme. We provide modern features and a stable > system capable of generating fast native binaries.") I would restore the README's full "Cyclone Scheme is a" at the beginning of this; the description can refer to the package in the third person. Also, first-person language should probably be avoided here. "We" in a Guix package description would most directly imply the Guix project; this is inaccurate. Perhaps replace "We provide" with "Cyclone provides." It may also be fruitful to cut the second sentence entirely and enumerate some of the compiler's said features. I would try to modify the language of the second paragraph in the project's README (replacing passive voice with active voice, for example), and/or add a list highlighting some (all would be a bit too long I think) of the "Features" section of the aforementioned README. They seem very proud of the "Cheney on the MTA" algorithm so make sure to highlight it. Other than those stylistic notes, this patch series looks good to me! Thanks, Juli