From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yNOUEJ0QeWK7TgAAbAwnHQ (envelope-from ) for ; Mon, 09 May 2022 15:01:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eCerD50QeWLIPwAAG6o9tA (envelope-from ) for ; Mon, 09 May 2022 15:01:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D414AB7FA for ; Mon, 9 May 2022 15:01:15 +0200 (CEST) Received: from localhost ([::1]:50904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no30k-0005kF-Ur for larch@yhetil.org; Mon, 09 May 2022 09:01:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no2qs-00048J-0X for guix-patches@gnu.org; Mon, 09 May 2022 08:51:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34402) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no2qr-0002Ih-OU for guix-patches@gnu.org; Mon, 09 May 2022 08:51:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no2qr-00073z-IZ for guix-patches@gnu.org; Mon, 09 May 2022 08:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55242] [PATCH 08/10] guix: import: go: Modules in a subdir and prefixed tags. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 May 2022 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55242 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55242@debbugs.gnu.org Received: via spool by 55242-submit@debbugs.gnu.org id=B55242.165210065427139 (code B ref 55242); Mon, 09 May 2022 12:51:01 +0000 Received: (at 55242) by debbugs.gnu.org; 9 May 2022 12:50:54 +0000 Received: from localhost ([127.0.0.1]:56532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no2qj-00073d-OY for submit@debbugs.gnu.org; Mon, 09 May 2022 08:50:54 -0400 Received: from mail-4022.proton.ch ([185.70.40.22]:18224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no2qh-00073O-5Y for 55242@debbugs.gnu.org; Mon, 09 May 2022 08:50:52 -0400 Date: Mon, 09 May 2022 12:50:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail3; t=1652100643; bh=6onuwvgB5k5E04r/r8C+dOm23LWCRsCGuFdYB4nqNIM=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=lqvNGg+58Ju/YAcc3+zUW3cSmKlIvi5024mczehuxxv2uxdxujxPBFd0J8U3G4y1Z EevE1LTqrHRqlAe1ijxf3kVHBzTxR33NP9I1TMHEibr7bvpCjTHpdyCAJovd9eZvRz UeNNAvFwOR6kQUZxpE1oitnVRuYDCbslTtnqn0ekOwX5MT/RKSfSDSV9greZyL8DQV AHdN1mq4rrC47uV2zVY4lJSkBTHuj0s9/1zqScx2iamAvRTG7e3RlBMZRPUtTqBfuL iCMOQWp5dauUw4wyB0Xxtdl2qTBi0MJdzjUAj+u/n/b4HMrY9b5KIT3lMINLp6AF8i QjlQ7Mds9fnEw== From: Attila Lendvai Message-ID: In-Reply-To: <849ca73cf56763c56faa2a98ea744f678f233d1b.camel@telenet.be> References: <20220503114301.9524-2-attila@lendvai.name> <20220503114301.9524-8-attila@lendvai.name> <849ca73cf56763c56faa2a98ea744f678f233d1b.camel@telenet.be> Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652101275; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6onuwvgB5k5E04r/r8C+dOm23LWCRsCGuFdYB4nqNIM=; b=tvU9G2wB0Qoqe1O6Yaxyz7hLiOMR8vhRLsV9ut5a8CsR4d1m0Zgh2cEMH+DL1Xo1ZL06Ks ihMiFyGcP8edPa3rcFlZHfiIwGElKtxViFxKAyGM53kJLXhMEITQvszMnZ4aTbX0IowCTm DrDdW6xvJl59/nuLHLwrolweRM2VcLPWjpsgKZQ7J5fAujs9eOe3DYvneJriKVCyzmyj5w HDKSpO6jhEQo7+tieqwuV+2rehIFRRbBg4KkWnSCyef5OCgFeZOH5ZjIxs4UOol4539P3J DCbERSPVEoP/S+tv1+/mUOaNe9METzX+nKEzua/ARbCxqXEnJqsCPFTCEllFmw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652101275; a=rsa-sha256; cv=none; b=jfRUqddLU0YDc0LUnfg1MTyAKBlKjiXbvKivEWoEY9VLJ9O6i+HAR9vW+GVKpeIX32+nXo 5Xs2HUt9aVSu9fuCzgpJ6/wUUGt5hi2FV6uNmaFCxr5eduW6iMdlt8BL+joysIh1jPBWXi oF998JCDGBrHOn34M594GEDub+n4VlhhkszT97jpkrKMHaBffUYy1rrcFjfo4R6o2QTaxm z9YlK6MsXFJ4oYzegR5gsOY/TmQSbhOWdh60jDyRpNXdgmPszSIYahis6RNwiEMuXwDBC9 dyTJsDIvD9XbiNyOfE5JvxlwP1UNASytKgSmp76y8wbiWMBXpK28oTEmwE3y5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail3 header.b=lqvNGg+5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail3 header.b=lqvNGg+5; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D414AB7FA X-Spam-Score: 1.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: pGRiY/q83jqw > > +=C2=A0 (log.info "~%Processing go module ~A@~A" module-path version) > > > Why a newline at the beginning instead of the end? Also, why the it makes the log more readable. > logging? If I do "guix import go foobar", wouldn't I know in advance > it will process the foobar module? And in case of --recursive, > wouldn't I know after the fact which modules were processed? here's how i was working on this codebase: RUN=3D12 clear && ./pre-inst-env guix import go -r --pin-versions github.com/ethersp= here/bee@v1.5.1 > >(tee -a ~/workspace/guix/importing/bee-run-${RUN}.scm) 2= > >(tee -a ~/workspace/guix/importing/bee-run-${RUN}.log >&2) && beep RUN=3D36 clear && ./pre-inst-env guix import go -r --pin-versions github.com/ethereu= m/go-ethereum@v1.10.17 > >(tee -a ~/workspace/guix/importing/go-ethereum-ru= n-${RUN}.scm) 2> >(tee -a ~/workspace/guix/importing/go-ethereum-run-${RUN}= .log >&2) && beep IOW, i was repeatedly firing long-running imports whose output i stored in = versioned files. when a run was finished, i inspected the log and the outpu= t file (containing hundreds of packages). whenever i had to understand what went wrong -- which often manifested in s= uccessfull runs producing broken output (i.e. no errors/backtraces) --, i a= dded log statements to see what's happening. i could have deleted the print= fs, and then re-add them again a gazillion times, or just leave them there = for the upcoming programmers (which includes me), conditionally compiled in= with the help of a macro. background: in my lisp codebase emacs colors the log statement gray, and th= e logging lib i'm using in CL has a separate compile-time and a runtime log= level. IOW, i can eliminate the entire runtime logging overhead, and most = of the code readability overhead. -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CAssociate yourself with people of good quality, for it is better t= o be alone than in bad company.=E2=80=9D =09=E2=80=94 Booker T. Washington (1856=E2=80=931915)