From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8EndGqeifGNjVwEAbAwnHQ (envelope-from ) for ; Tue, 22 Nov 2022 11:21:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IJDQGqeifGN0mwAA9RJhRA (envelope-from ) for ; Tue, 22 Nov 2022 11:21:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03F2614AC8 for ; Tue, 22 Nov 2022 11:21:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxQOn-0007nI-1F; Tue, 22 Nov 2022 05:21:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxQOk-0007n9-JR for guix-patches@gnu.org; Tue, 22 Nov 2022 05:21:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxQOk-0004Uy-Ao for guix-patches@gnu.org; Tue, 22 Nov 2022 05:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxQOj-0008Dj-PQ for guix-patches@gnu.org; Tue, 22 Nov 2022 05:21:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#57608] Upstreaming KDE Plasma and rest of packages Resent-From: phodina Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Nov 2022 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57608 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Marius Bakke Cc: maxim.cournoyer@gmail.com, ludo@gnu.org, maximedevos@telenet.be, mail@brendan.scot, leo@famulari.name, marekpasnikowski@protonmail.com, h.goebel@crazy-compilers.com, 57608@debbugs.gnu.org Received: via spool by 57608-submit@debbugs.gnu.org id=B57608.166911245231563 (code B ref 57608); Tue, 22 Nov 2022 10:21:01 +0000 Received: (at 57608) by debbugs.gnu.org; 22 Nov 2022 10:20:52 +0000 Received: from localhost ([127.0.0.1]:49911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxQOZ-0008D0-R1 for submit@debbugs.gnu.org; Tue, 22 Nov 2022 05:20:52 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:46313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxQOY-0008Cn-0d for 57608@debbugs.gnu.org; Tue, 22 Nov 2022 05:20:50 -0500 Date: Tue, 22 Nov 2022 10:20:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1669112442; x=1669371642; bh=RyfPaWMDZMmT1MBgDiJHXMipzlPhiFpLDr3j1xxfits=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=RFCEDbeoxKLLSjsqPGJ/RNMqZwZ2jAsH9v8Gsj0WzfhAbl9Oqrmi8Q3iMDtXZed01 7sk9SuvVHDW2VVYTRtid32ggyKOexrgZevrTadbCLIjWFa5P0qRKI1LebWY+tDRZYq NasN55m8Jym0Qtryv0ppJPAjnsoCLFLcGGow3fi53QiiuXrynIVZNKjIL5Km2uoFan DLCVJJegACWixDH2R3s/rmM3cL+KvpDdcoklrMKcTSee/ibYOOzJoTomX4bq+VgpqH ap7zvaS87vWmpWWuAxj/PG21jHzBed1qOFBAdPk5uNzh1sA7AUeGEs4TX+UqR1cTne xRRnvR4DOc5mw== Message-ID: In-Reply-To: <87zgckypvd.fsf@gnu.org> References: <87h70wap7m.fsf_-_@gnu.org> <_9i_X2elmnmVduuEMWiqx4qwh8Jlu6wffrzRfrk0M2boZ-SINJbuBmUDidz8oMTRJhaeeNmsNGvDgNTbPRLyCy1EcDAYVk6nwNlliDDWy6M=@protonmail.com> <87zgckypvd.fsf@gnu.org> Feedback-ID: 14143818:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: phodina X-ACL-Warn: , phodina via Guix-patches From: phodina via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669112487; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RyfPaWMDZMmT1MBgDiJHXMipzlPhiFpLDr3j1xxfits=; b=qPYOI0+M9NFBc+7ZblSMIMRqdgwK34x7EqA7QNrOddAu4S90nXktU4/s7jL5S+Cm5FV3UL JZ+6uJAVIv+6HxlgaJwf4/umB1eLCIP3fo1a64raR9iQsw3E3Ssp08zrDXDIqo4xBqPtbb S62uTZfY0vq/kIliohbN/h8ZNNWIgA4zHNpdF2mFiDOE978DEi2rQcWgDLCf1GsBJ8sRvn djqEqBGqPge7WEA6X0iTbM++fU0QDI7GVjdSVfHmS863FeCn96iyKQryneokAR18S7s4tc SWIfwWdB1wicMa5TnRuSFvc3HvCWuAArZNxengLhpNCSPbDPoDXHzwpI+A9rkQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669112487; a=rsa-sha256; cv=none; b=bfHuvhIwjetOdjff2+eK7WT7yScxvTCxpYSA66JY9beznhPGTbu35vdPmljgupin/PeZJd +7lC2MenaF4hoMOoCqw0RD1rrB/fGT+GflvPVtrxKt5bwQa6S+6LybuvrULck7pZhFno8t 4XRNKXXEmu4IayPft4TCyFZWDkDApztX8g4kFQPHRUWM3QxjSZhQAzstxd2rPfQyXBLUdR ndZ1UyIOyKSEEKn/YhCRcgO6pRgeFno3EzlXHe8wKajLd0ZtVZ2B8nEfYNx+truovuQdXS KI2g/JQ/Yp3q0Qe7kckisCjK7z0ktySCUlBU5FGje6KvjvXjWUILrJ0zv7Cm5Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=RFCEDbeo; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.21 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=RFCEDbeo; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 03F2614AC8 X-Spam-Score: -1.21 X-Migadu-Scanner: scn0.migadu.com X-TUID: OXUsj5fCjuKy Hi Marius, Thanks for the review and push to master! > Awesome work Petr. :-) >=20 > I went through the branch and applied most of the patches. With a few > changes: >=20 > * shortened multi-line URLs Sorry I used the formatter ('guix style') and it set the URLs as such). > * added (file-name ...) for git sources > * removed knetworkmanager -- AFAICT it is identical to networkmanager-qt > * switched to git-fetch for packages that were downloading tarballs from > the KDE GitLab. This is because such autogenerated tarballs are not > stable: they may get regenerated with a different hash. Is this issue somewhere described? I've lately used more tarballs to git do= wnload on other packages. Is the issue connected with any Gitlab/Forge or j= ust the KDE and the release scripts? > * dropped the !! commits > * Minor tweaks to synopses and descriptions My apologies as I noticed there were few packages with wrong license or mis= sing description. > * A few commits had a random edit to a different package: I reverted > those edits. An example: > https://github.com/phodina/guix/commit/5eaa9c49a78eed419db7847668a55c079b= ad5b71 Caused due to rebasing and working on a large patchset. I'll split it next = time and sent it by smaller parts. > * Removed use of direct variable references, i.e. #$qtbase. Always use > (search-input-file ...), (search-input-directory ...) or as a last > resort #$(this-package-input "foo"). Thanks for the hint. I'll fix all the packages where I use this syntax! =20 > * Skipped commits that would trigger a lot of rebuilds, e.g. gpgme. I'll submit it in new ticket. > * Skipped cosmetic commits such as using G-expressions in Qt packages; > mainly because of rebuilds, but also because they were not indented > properly. Some also introduced direct #$variable references. I'll fix the issues and submit it as a new ticket. > * Dropped the plasma-desktop-service since it was not working for me. Should we keep this ticket open to package also the plasma-desktop-service? I'll try it now and see what causes the Plasma not to work. > For later reference, when adding patches, please add a sentence or two > at the top of the patch describing what it does. I did not edit the > patches (except for a long file name), because I did not know what it > was for. Presumably you did; future you will thank you! >=20 > Pushed to 'master' as fe3be8d5e0..82804298ad ! Sorry I didn't intend to add so many changes and it's been a challenge that= taught me some new lessons. I'll definitely add more description for the reviewers and keep it smaller = so I doesn't take long time to review. ---- Petr