From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qELFIkcE9WLm/QAAbAwnHQ (envelope-from ) for ; Thu, 11 Aug 2022 15:29:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QHzaIkcE9WJndgEA9RJhRA (envelope-from ) for ; Thu, 11 Aug 2022 15:29:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 38C6AA256 for ; Thu, 11 Aug 2022 15:29:43 +0200 (CEST) Received: from localhost ([::1]:53374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oM8Fq-0007Oj-DJ for larch@yhetil.org; Thu, 11 Aug 2022 09:29:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM7dS-0004t6-HP for guix-patches@gnu.org; Thu, 11 Aug 2022 08:50:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34040) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oM7dS-0006gv-8N for guix-patches@gnu.org; Thu, 11 Aug 2022 08:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oM7dS-00055T-4h for guix-patches@gnu.org; Thu, 11 Aug 2022 08:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57111] [PATCH 00/56] gnu: crates-io: Allow build of various rust packages. Resent-From: Jean Pierre De Jesus DIAZ Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Aug 2022 12:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57111 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 57111@debbugs.gnu.org X-Debbugs-Original-Cc: "guix-patches@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.166022215719492 (code B ref -1); Thu, 11 Aug 2022 12:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Aug 2022 12:49:17 +0000 Received: from localhost ([127.0.0.1]:52022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM7ci-00054K-LX for submit@debbugs.gnu.org; Thu, 11 Aug 2022 08:49:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:33594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM7ce-00054A-4s for submit@debbugs.gnu.org; Thu, 11 Aug 2022 08:49:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM7cd-0003ti-S8 for guix-patches@gnu.org; Thu, 11 Aug 2022 08:49:11 -0400 Received: from mail-40136.proton.ch ([185.70.40.136]:57945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM7cb-0006Xp-4G for guix-patches@gnu.org; Thu, 11 Aug 2022 08:49:11 -0400 Date: Thu, 11 Aug 2022 12:48:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeandudey.tech; s=protonmail3; t=1660222143; x=1660481343; bh=2nkjzLZsapU23nQGEfAZBgPfhDkODdvOur9c/Qycj9I=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=Phv7EXUo1m6YPYx/Qv9jvPq87lD2Yz7EhxBsWYT6AcFe6UifCTOHHw0qD6rq6JDFd R4GBNbEYLYWL2Jfr7oUXTw81vAY3ob3YGNwXxNU/gzJhowt+QITbwBzBXqdQKAhLFG 3HXDGWao0NEKKeHpaAQmiLhP2ZYPU8e+aFpQ3zVRw1+gmFBO9lw5PysWPNDxc/3xaY ewvudjXxdoS5DFNmH9VWeMJkM5ZGMInwyaySzRrMNjnF1AmGDgAUvz+c4z9AKtvTFF ugFKrNfWrPcpWSnIF3LtZYna9DNtHHbGx5pmOSvl2/JQuB7egJfU1AcocXEZUUaxES 8lvaXCM9NHDtg== Message-ID: In-Reply-To: <4b00077f-2939-3094-6fd6-c1baa2513c6c@telenet.be> References: <4b00077f-2939-3094-6fd6-c1baa2513c6c@telenet.be> Feedback-ID: 20187791:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.136; envelope-from=me@jeandudey.tech; helo=mail-40136.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Jean Pierre De Jesus DIAZ X-ACL-Warn: , Jean Pierre De Jesus DIAZ via Guix-patches From: Jean Pierre De Jesus DIAZ via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660224583; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2nkjzLZsapU23nQGEfAZBgPfhDkODdvOur9c/Qycj9I=; b=Cd8u+lCbI1k4J76OMKPAUE1liacrylRpgKBeNkmCVpRoSrzUfV1sgVF3FbrPKQyYx19IaG rqidOHOWoPz1jAQ4lYxoz3RAS22Y1sOGAxU4xL1I+cQXV/+drRlSxvWl5HUzrZQicN85ig 72FzSwLqzcHWvd11fIHzUZ5RPGo7cOG8GO9hVr/EQ8JpIYlnHOuXTwog0I/BtRPW6brRiC lftivzhg+9JUktfWyS5CBtzNGwuJw3F4EcC8PvZMO6PtnOnW6tkXN4EIAsXoESMVlR2o0O fCnwUgfDtkxHgXUYt45H/71vFd31i63+gmpJqIY2AwxONcCsycEkvaIPLvY1pg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660224583; a=rsa-sha256; cv=none; b=IVlpZXEJOibP+EfaVL5DDCDKesUIXKUWC4K4VVQR3ZjLPmz6pTFJSwnL6ecRf8EKtZ/d8u TfqybGIkMyJQk266CL/kYsJ4Ze6v0k9PlLRnmApu6G+r7qtPx6e1Hp+EvDTqKN57Rb/sYs TvQdsdJDLLcMy5gkuDC6bfk6u1vYdWhm7BK7m6dOhhXfuLXOo0kDv3u5Oynw51sfEit/HR O952D1c1pc7dUcDHvGDutKUbPDSMGtBSqPLPmhDeZjgjY7OGBomc2TB8Ae09I7imNQWLOq MCUt5X0kI4unrksT+aNhtlyygOnba/mp8xNxcgdVQ728/i/wvXMn2GPDr27SYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b=Phv7EXUo; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.58 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b=Phv7EXUo; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 38C6AA256 X-Spam-Score: -3.58 X-Migadu-Scanner: scn1.migadu.com X-TUID: Cl4rWhnyU4ay >We currently skip-build? #t to reduce build time with the inefficient=20 >cargo-build-system. To avoid wasting energy, I recommend delaying such=20 >patches until we have a matching _efficient_ build system. This should be written somewhere IMHO if not done already, thought of removing the `#:skip-build?` for the crates I could find to solve build and dependency issues where possible as that's the intention of the (guix)Rust Crates section of the manual: https://guix.gnu.org/manual/en/html_node/Rust-Crates.html =E2=80=94 Jean-Pierre De Jesus DIAZ Senior Software Engineer ------- Original Message ------- On Wednesday, August 10th, 2022 at 8:32 PM, Maxime Devos wrote: >=20 > On 10-08-2022 13:48, Jean Pierre De Jesus DIAZ wrote: >=20 > > This patch series allows cargo-build-system to fully build and test > > some of these packages. These are small rust packages though. > >=20 > > Probably were added without verifying if the crate could get built or > > not. So these patches are mostly one liners removing `#:skip-build? #t'= . > > [...] > > Maxime I've CCed you as this could relate to antioxidant (as it > > requires crates to build, am I right?). >=20 >=20 > We currently skip-build? #t to reduce build time with the inefficient > cargo-build-system. To avoid wasting energy, I recommend delaying such > patches until we have a matching efficient build system. >=20 > In antioxidant, I've noticed there are often missing dependencies > (test-only or otherwise), I have a list '%extra-inputs' that contains > the required information for adding them Small sample: >=20 > ;; TODO: add these (upstream) or teach "guix style" to add them. > ;; Keep it sorted to find things in it easily! > (define %extra-inputs > =C2=A0 `(("alacritty" ; forgot the reason for adding the dependency > =C2=A0=C2=A0=C2=A0=C2=A0 (("rust-structopt" ,(p rust-structopt-0.3)))) > =C2=A0=C2=A0=C2=A0 ("castor" ;; TODO: add them in upstream Guix > =C2=A0=C2=A0=C2=A0=C2=A0 (("rust-gio" ,(@ (gnu packages crates-gtk) rust-= gio-0.14)) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [...])) > =C2=A0=C2=A0 [...])) >=20 > Currently, 95% of the rust packages compile (and test successfully, > except for tests I've manually disabled), according to the antiox jobset > at ci.guix.gnu.org. >=20 > As such, you are kind of duplicating work already done. >=20 > If you want to help with fixing the build inputs, I recommend using the > information (currently 1498 lines) I've already gathered in > antioxidant-packages.scm (%extra-inputs), by teaching "guix style" to > automatically add dependencies listed in %extra-inputs. Also keep > %removed-dependencies and %disable-tests in mind, sometimes crates must > not be added, to avoid cycles (those cycles are resolved in > cargo-build-system, but cannot be in antioxidant). >=20 > Greetings, > Maxime.