From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gCb4ATck9mK20gAAbAwnHQ (envelope-from ) for ; Fri, 12 Aug 2022 11:58:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qIzYATck9mKadwEA9RJhRA (envelope-from ) for ; Fri, 12 Aug 2022 11:58:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A50F128C56 for ; Fri, 12 Aug 2022 11:58:14 +0200 (CEST) Received: from localhost ([::1]:38480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMRQj-00037a-BA for larch@yhetil.org; Fri, 12 Aug 2022 05:58:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMRQY-00036s-J7 for guix-patches@gnu.org; Fri, 12 Aug 2022 05:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37718) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMRQY-0001mV-3D for guix-patches@gnu.org; Fri, 12 Aug 2022 05:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oMRQX-0005Mf-QB for guix-patches@gnu.org; Fri, 12 Aug 2022 05:58:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57146] [PATCH] gnu: polkit: Fix cross-compiling Resent-From: Jean Pierre De Jesus DIAZ Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Aug 2022 09:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57146 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "57146@debbugs.gnu.org" <57146@debbugs.gnu.org> Cc: Mathieu Othacehe , "andrewpatt7@gmail.com" Received: via spool by 57146-submit@debbugs.gnu.org id=B57146.166029824220575 (code B ref 57146); Fri, 12 Aug 2022 09:58:01 +0000 Received: (at 57146) by debbugs.gnu.org; 12 Aug 2022 09:57:22 +0000 Received: from localhost ([127.0.0.1]:55700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMRPu-0005Lm-Dt for submit@debbugs.gnu.org; Fri, 12 Aug 2022 05:57:22 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]:37623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMRPs-0005LY-1b for 57146@debbugs.gnu.org; Fri, 12 Aug 2022 05:57:20 -0400 Date: Fri, 12 Aug 2022 09:57:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeandudey.tech; s=protonmail3; t=1660298233; x=1660557433; bh=K8smlakWLfoVQOj/kQXuItAgIoGMeBqq7hniSVqb3zM=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=TUMudVDrKQ1kSfkgZJrng+gHiW2u6du/Za5RpSWmtPVZXRC81i7lq8LacisA8G/Yx Vuk/vubsYjyQZAVqca43CuuJk6KuqEAcQePcUvbvjHucMNm9XDIwIpcWTbGtU7+Sd8 9/RBZX0BSCjBGpAty1/+OieWOazyHDcDal53qcQUokuQ2gSRnqyWhtB1MwxpVAOV6D fGDqESZ1h5DdtWEQnHa2LuALXQtoms9mewt5gEVc9/GA0v+5YjPrJkJnjNqDXGxcQk lUupKQbMnNhkirlsZVzSN1iJ92yP2+kLcuO5IfYyVJgf56LtCqKGRajJ2xIne6NnZK 9o/ok9DWDqAag== Message-ID: In-Reply-To: References: Feedback-ID: 20187791:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Jean Pierre De Jesus DIAZ X-ACL-Warn: , Jean Pierre De Jesus DIAZ via Guix-patches From: Jean Pierre De Jesus DIAZ via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660298294; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=K8smlakWLfoVQOj/kQXuItAgIoGMeBqq7hniSVqb3zM=; b=RTa2tElQnlD5cfsITYXqMzI5tde2GOpM61F4Wz9Y0MpE5jrJqx1crJ/SyCDF8ZWKgxQXz8 9QW87OmpWnnHrujHocuRj0AEHbUUI4/cybGhIZc4xYzPJheTFXsNOrHpkz57bJ5WWyJ5L+ zqUGUZtYPdP8/6uc2BtCjaH+KE4OKtrajqjiH2XJBf+B3vizFp80IlFrqQJqeyRxHK4quk YdR7c/talNeWFOPXsGBA/rSvNlqbcZmzdk5IcHk8tAQGw6KUx9E6UERf08aYsggfktQ1Ox +hOloJ//mQva/hs0ZD3M3ZgAOqpYL1/UZ5y++cgOwYW6M8mtPGxYbW+gG6j4EA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660298294; a=rsa-sha256; cv=none; b=Wxaij8xkr9yqcrtsUjiWLeFmTUZPs2NQGa6JqoHAhYzfnOd2wxs5o/pYE7GbpHkv/hreAM 2Hnl9Thki1rJ8q1MINyzsz/Cx4zfJ1z6ga8MHcKNFeuRNe71/e6w2LS9ZqNRIlPl2wMQPw YoEY2UinxrIzMf0rcTFEl/vuFWicBVJLKgTgjaEMRoLeywpzntgtITmYRZ9Urbc4lXqbyf Wcy/rTt0PRyrBFUV4Hdyni3P2US3BNQXjTXPE9eFPdNQ0g9mV8lZLyi6lzNiXPutMokCf6 qvPrYVorpVNPhtR3s13yNkbOiVjOQ79ym0iiqpWahvk4mGp0rswJ/yZVtOBjMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b=TUMudVDr; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jeandudey.tech header.s=protonmail3 header.b=TUMudVDr; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A50F128C56 X-Spam-Score: -3.97 X-Migadu-Scanner: scn0.migadu.com X-TUID: FWSJR09RN8UW However, the patch to introduce G-Expressions is welcome as I did only fix the inputs/native-inputs usage. >+ (let ((out (assoc-ref outputs "out"))) Can be removed probably, and replace `out' here: >+ (string-append "sysconfdir=3D" out "= /etc") >+ (string-append "polkit_actiondir=3D"= out >+ "/share/polkit-1/acti= ons") By #$output. But, rethinking it again, I would investigate if this phase can be removed and instead use `#:make-flags' if possible directly as make-flags can be specified as a G-Expression. >+ (lambda* (#:key outputs #:allow-other-keys) >+ (let ((out (assoc-ref outputs "out"))) >+ (substitute* (find-files "." "Makefile.in") >+ (("@INTROSPECTION_GIRDIR@") >+ (string-append out "/share/gir-1.0/")) >+ (("@INTROSPECTION_TYPELIBDIR@") >+ (string-append out "/lib/girepository-1.= 0/")))))) Same here. And then: >+ (lambda* (#:key outputs #:allow-other-keys) Is just then: --8<---------------cut here---------------start------------->8--- (lambda _ ...) --8<---------------cut here---------------start------------->8--- >+ (list #:configure-flags `(list "--sysconfdir=3D/etc" "--enable-man-p= ages" >+ ;; Prevent =E2=80=98configure: error:= cannot check for >+ ;; file existence when cross compilin= g=E2=80=99. >+ ,@(if (%current-target-system) >+ '("--with-os-type=3Dunknown") >+ '())) G-Expressions can be used here too, e.g: --8<---------------cut here---------------start------------->8--- (list #:configure-flags #~(list "--sysconfdir=3D/etc" "--enable-man-pages" ;; Prevent =E2=80=98configure: error: cannot= check for ;; file existence when cross compiling= =E2=80=99. #$@(if (%current-target-system) '("--with-os-type=3Dunknown") '())) --8<---------------cut here---------------start------------->8--- =E2=80=94 Jean-Pierre De Jesus DIAZ ------- Original Message ------- On Friday, August 12th, 2022 at 11:42 AM, Jean Pierre De Jesus DIAZ wrote: > This issue is already solved: >=20 > https://issues.guix.gnu.org/56252 >=20 > > Pushed to 'staging' in 7767d30f55, thanks! >=20 >=20 > Was fixed for both polkit-mozjs and polkit-duktape. >=20 > =E2=80=94 > Jean-Pierre De Jesus DIAZ