From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kM/0BRYk02NXEwEAbAwnHQ (envelope-from ) for ; Fri, 27 Jan 2023 02:08:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YPMfBRYk02Ov+gAAG6o9tA (envelope-from ) for ; Fri, 27 Jan 2023 02:08:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 888A642036 for ; Fri, 27 Jan 2023 02:08:37 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLDDz-00086E-Qg; Thu, 26 Jan 2023 20:08:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLDDm-00084J-IO for guix-patches@gnu.org; Thu, 26 Jan 2023 20:08:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLDDm-0006Um-62 for guix-patches@gnu.org; Thu, 26 Jan 2023 20:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLDDl-0003h6-Lr for guix-patches@gnu.org; Thu, 26 Jan 2023 20:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61067] [PATCH 2/3] gnu: wine: Build more reproducibly. Resent-From: Kaelyn Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 Jan 2023 01:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61067 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 61067@debbugs.gnu.org Received: via spool by 61067-submit@debbugs.gnu.org id=B61067.167478167414186 (code B ref 61067); Fri, 27 Jan 2023 01:08:01 +0000 Received: (at 61067) by debbugs.gnu.org; 27 Jan 2023 01:07:54 +0000 Received: from localhost ([127.0.0.1]:36449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLDDd-0003gj-LG for submit@debbugs.gnu.org; Thu, 26 Jan 2023 20:07:53 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:45921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLDDb-0003gW-G1 for 61067@debbugs.gnu.org; Thu, 26 Jan 2023 20:07:52 -0500 Date: Fri, 27 Jan 2023 01:07:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1674781665; x=1675040865; bh=tYv1QCrUJFzsnE0cpD8rp0H4akXQU5oQffdilsyR1S8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=oIsFqRXxj+fCRg9v5uyAk9+hvQPR55JR1y2sKZnnryjDGARSIcwsLtT9lgs/SfngC GVSX4ABE3l6MyNlnYArgNp97pdBEbGgZiu28iQSd8PoEjhfbjF06EWCS3XxPvlD30R Lpi6UmLXtCHiqEwHIiRFaNZgQ/vXYpSTd3H3lDNy7QtVzZgJ8hdZKkznvVD4piv8y+ /VcnVqTUdb9FfkBsev3yS89oykr5dLRnEnMQbYBgJUpWZ3EpQ410b1h6T906xqMdun Hh6CBDQ/PgH9hORo59fTHchY0NOcJA6gK5/2ByzvisAmrLl9bUPnQEgKEwteh68tEp Qukw0KIK6accA== Message-ID: In-Reply-To: <5f9118b2e770ad5e9e6d38249de08dddf1ea0fef.camel@gmail.com> References: <5be364a38001818326d78d586a918938c0da0c81.1674691809.git.kaelyn.alexi@protonmail.com> <5f9118b2e770ad5e9e6d38249de08dddf1ea0fef.camel@gmail.com> Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Kaelyn X-ACL-Warn: , Kaelyn via Guix-patches From: Kaelyn via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674781717; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tYv1QCrUJFzsnE0cpD8rp0H4akXQU5oQffdilsyR1S8=; b=g2MUqZegxiMFrwXynbppOpSOaWr77Gj7L86EXa15x76lej2RPZTtSbYOnWqftjmN8HQLuY 3VzTjCOyPArTZQWMDX3aRrF6Dg25UIex9wx0b5nhi1IQUW32AQAuWuhpx38I+yF9oi7yCp BjSIVi/oBEPhAYfzhD58uBlwfFKKZMyOWtdepkmurUIRP0mZ94fc5CIUswoXG7T8NIvbbj XF5sQZtpm/+IAdv89yP0SzIFNvgfUYVTc2lvmXDNlpWFWjpD160zxwUey9d1sCBA08vroY 3oEe1csGdlrg72EA8OYGDUsvXdBf/tm0SGtJYjcCvJw570/lAL4isjVJUHVL2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=oIsFqRXx; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674781717; a=rsa-sha256; cv=none; b=KPJVepUF3y1tMd8ImOBLoizxgin9l/kidae3q0e5Z04wxsBlIZmAfjpP+vCeTNvLnUoNKn NnIxn3yZC1k6ZK4mspTGukTLTWmR75FiNz+4tqLkZANTgp6ww/cjC+2xoXz8QU9CPRRO1b MYTY3umIxF5Td7iNRGC0F5t3kcviRYQYa//2Ye2q8ENew/Gn/mSdfX1TCKxAbP4MMfUC4n cysJRWO38s9zjD1n1tWmjLAjBlL0PM8tHsd3VvYvSSncL2PPPvjdqLA7X+38ELwZb+z04K R11LhTy2dxrVhkPhKXErMM8Gv52GkSvGd+5SnOZt9kkBhRfh6aKhUef4Hp0jjQ== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=oIsFqRXx; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.87 X-Spam-Score: -2.87 X-Migadu-Queue-Id: 888A642036 X-TUID: S1yAm1Bg3YA3 ------- Original Message ------- On Thursday, January 26th, 2023 at 9:09 PM, Liliana Marie Prikler wrote: >=20 >=20 > Am Donnerstag, dem 26.01.2023 um 20:46 +0000 schrieb Kaelyn: >=20 > > ------- Original Message ------- > > On Thursday, January 26th, 2023 at 7:28 PM, Liliana Marie Prikler > > liliana.prikler@gmail.com wrote: > >=20 > > > Hi, > > >=20 > > > Am Donnerstag, dem 26.01.2023 um 00:24 +0000 schrieb Kaelyn Takata: > > >=20 > > > > * gnu/packages/wine.scm (wine)[phases]: Add a new 'set-widl-time- > > > > override phase. > > >=20 > > > You're doing this for three packages, so there should be three > > > packages > > > in the ChangeLog as well. > >=20 > > I wasn't quite sure how to handle the changelog for the three > > packages since the various packages are variations of the same piece > > of software. If separate changelogs are desired, the existing can be > > copied and pasted for each of the three with the package name tweaked > > accordingly. >=20 > You can simply write (wine, wine64, wine-minimal)[#:phases]. It's just > to mark all the places that have changed. >=20 > > > On that note, it's somewhat odd that the wine packages can't share > > > some common phases. Perhaps we should refactor them a little to > > > make that possible. > >=20 > > I agree they could and should be refactored to share more of the > > phases--I just haven't been brave enough to try because of the weird > > mixed-architecture nature of the builds. >=20 > I feel you. I can try to figure something out and reply to this thread > or open another one once I'm done. I felt a bit of inspiration, and tried my hand at unifying the phase lists.= I'll be mailing the v2 patches momentarily. I _think_ the new version of t= he package definitions is equivalent to the old, but I also appreciate all = of the extra eyes and testing those changes can get. :) Thank you for the review and feedback! Cheers, Kaelyn >=20 > Cheers