From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id kHkqMFnhgma/agAAe85BDQ:P1 (envelope-from ) for ; Mon, 01 Jul 2024 17:03:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id kHkqMFnhgma/agAAe85BDQ (envelope-from ) for ; Mon, 01 Jul 2024 19:03:21 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=OUTLOOK.ES header.s=selector1 header.b="qHyTuD/B"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=outlook.es (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719853401; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Q4H4WRuVxKrXj23K1q1M0hEb3S4kYyBuz6CniKIlhog=; b=F2AZy2DEhHmZ+2oEGvUGN9Vak29+84Wk9egqJmfLvIEZC6amkp09RtRmToFY8qwAsfjGLe 6rHT7AbwUUqhZEPsmFvyzLHwx3AA3jkfHOXvW7cm5A47reF8OlCW30h2PVBixJDJ7+kOBV vW/7Ffycy5Voi0mrLl0ilofRJW4G0DEs68W+lnvTWI3JPdqWIE1a0VW0TQ6dmKhOeWhmd3 qyHogKLhnNOb31Wor2pqr9TQFBM+vgyBtkWECbkVDG9iBNOuCJ5IfdGyV8fVjliHn4ZPGQ iWOYkAGobmMuvNvFM+XlOnd+tKzWcIRvSab2FPftQWj6kwVSqUiVXFpLSLl4ig== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=OUTLOOK.ES header.s=selector1 header.b="qHyTuD/B"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=outlook.es (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1719853401; a=rsa-sha256; cv=fail; b=KBS2bsKMIvbiJ9tPK2MvCQjamHY277nV5VWplpoPu/ymMXm7RBoNFnWlJsQqSHijQ15nkm 3DM+73qah14fFxov8pH6j0MNzNs7MFiwwSGASpFYPsXWuT8SRZAamGR2IrCLfXtIDtzxQN KKc9h+JguWszx/TAoqVXLxczyTBjG8QAkIu2IRjphs/HQTPs2VeEd4mInl75GWBQTGfVES NXTjQ4wC99GrPLWckk+ND9H7pljaydojSN8aHqcl3C3WSl5dykCib3++mi1zMXnV57fzHy sj6f0y5WQpnBap5TErieaSbe4sBX9/F6CCH+krlz8hPrksgoS4rnlboQW/mpFw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7BCE750832 for ; Mon, 1 Jul 2024 19:03:21 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOKQj-00014V-1t; Mon, 01 Jul 2024 13:03:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOKQf-00013G-Jp for guix-patches@gnu.org; Mon, 01 Jul 2024 13:03:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sOKQf-0006Vl-Bt for guix-patches@gnu.org; Mon, 01 Jul 2024 13:03:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sOKQf-0004kv-NA for guix-patches@gnu.org; Mon, 01 Jul 2024 13:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#67755] [PATCH] gnu: Add imhex. Resent-From: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 Jul 2024 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67755 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart , 67755@debbugs.gnu.org Received: via spool by 67755-submit@debbugs.gnu.org id=B67755.171985336718246 (code B ref 67755); Mon, 01 Jul 2024 17:03:01 +0000 Received: (at 67755) by debbugs.gnu.org; 1 Jul 2024 17:02:47 +0000 Received: from localhost ([127.0.0.1]:34316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOKQQ-0004kD-IU for submit@debbugs.gnu.org; Mon, 01 Jul 2024 13:02:46 -0400 Received: from mail-vi1eur03olkn2052.outbound.protection.outlook.com ([40.92.57.52]:13664 helo=EUR03-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOKQN-0004jq-QN for 67755@debbugs.gnu.org; Mon, 01 Jul 2024 13:02:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XM1vp1oem3H4XmkipaK0MQ/EgnRCqy9AO8FoiGtNSsA8d8rPiQfLpzjdFtBnn/BFsKy8vJwZrsV88LqjcasEzseSJI1vVV+Aq2G590wp1TEnK643kig1MF+ff/90MEytMutZu0V+CH7dhtilhalwtV2gHQLZpF3wBCima6r18tqset/upMS4pa9YMLpVVDsQ1H0sBwa+37EIaNRM21T4IhtbN9ChITJbImMSfnX6+IuWtqDinG0fxAs2kBvU9gwJnQvhFbIoDuZBihH+nwj471hkscYxmMEqh3LX7ip5dlrr5PwbyQGsUpxAtsqdg5U2ZS9CEvIaqF4kugBH0KIcLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q4H4WRuVxKrXj23K1q1M0hEb3S4kYyBuz6CniKIlhog=; b=aUdoGE5oBhOBfR1iIWeLQP97bGxsX/G0Eb1+sgJ3H8G5TN3MUnBlWEIUvqVzrvdMz9Pl+UiMfi5w6WWQLSsI7ob2au0ib5UvTh8FdCtqRAWfKTxZ8RRnxLlBT6pvencOLsbq9smk/UoWrUxvS78K+n1G4patsUxGm/R9g0JEhfBtRQucAnJFA0+lgQNZ/N3k12ygn0stvlQPW+oSvWL6jPsAtJi4guDHDveY+/MkjtTOF6Y2QI/x067hbSFCN5xK9nzZw9lq6F+I0QCBCev0wWWKF77bAAKcsGpBos9Cx9VwdjFRs4dzTmA3cKlDrp8UKwfHKMC9ARkKpX3xN/DszA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=OUTLOOK.ES; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q4H4WRuVxKrXj23K1q1M0hEb3S4kYyBuz6CniKIlhog=; b=qHyTuD/BsuphSRtkdvEOY0ib/jbnfYhUd7wyfVH0Qqn+aCukPbyy5fHlIy7MNqt1zMEFb8GHg3f5bTU89wd9aNB4PbhTRaN6+wcu+lu5ww5zKXeim4sn54RI59YEvfLXJ46JVzgY6dKynJwnwImgWQ7enVbtgJgIQHH2Qskr/nnI82CtfwZpELtF4zGBx3hfhPhjlQWbE3ZzwgMDaNLwDvDJ7pSGFCZfCmiBwWVP3M0TTXdpg4LFSQG+Gkb77A08bW6FhOmDMKFBDIbkuTJMXG9CnTlCHONxoFArAxHOM/1+pRc8BTV3dL9x8suXiK1wb43hx4YmjxLx/vgSSy4ySw== Received: from PAXP251MB0348.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:20b::10) by GV2P251MB0946.EURP251.PROD.OUTLOOK.COM (2603:10a6:150:aa::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.32; Mon, 1 Jul 2024 17:02:28 +0000 Received: from PAXP251MB0348.EURP251.PROD.OUTLOOK.COM ([fe80::1f4f:1f6b:1817:f03f]) by PAXP251MB0348.EURP251.PROD.OUTLOOK.COM ([fe80::1f4f:1f6b:1817:f03f%7]) with mapi id 15.20.7719.029; Mon, 1 Jul 2024 17:02:28 +0000 From: Sergio Pastor =?UTF-8?Q?P=C3=A9rez?= In-Reply-To: <87r0ceqign.fsf@dismail.de> References: <87r0ceqign.fsf@dismail.de> Date: Mon, 01 Jul 2024 19:02:25 +0200 Message-ID: Content-Type: text/plain X-TMN: [chPe0M4LiiCpLaQrXgRNmGnGm4GW7hEw] X-ClientProxiedBy: MA4P292CA0014.ESPP292.PROD.OUTLOOK.COM (2603:10a6:250:2d::7) To PAXP251MB0348.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:20b::10) X-Microsoft-Original-Message-ID: <84o77hhwpq.fsf@outlook.es> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXP251MB0348:EE_|GV2P251MB0946:EE_ X-MS-Office365-Filtering-Correlation-Id: 4eb4906f-d3ae-4ee4-e2c8-08dc99ef964d X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|461199028|440099028|3412199025; X-Microsoft-Antispam-Message-Info: fLFJIwMZ85ZazhBXCof3/Ith5zt24eJoLBu2Ks3qdElbnX7k2e+L2s5lq8Mwh/rSCiMM+oJlGRtLBrQMmCLMRHVC3NjNjQvqjFn2u94Z9GC1NK69Mrwq7hcoPexjuL81uYJO1pNejGHzo5rWbxW1YfS+bGoUnDRvScfiYoj6rhDL3r7lHXkOudttTeIvf7h/e0huLe7q8sdIahtc9W/iCrpRtqcYVgteUYdSIhQm5rfLWD6Oosm7npHw9j0Dm24MTHix7rq5Y/RFgBnkWVlkVnDPmwal8WwHk928cmIqGzOEnF7LVSCPMpXCER95IIa+ZcxNGO1F0oCWpk+Vv4kH5qCt3m0iia7Kr8oq0tHHrrAjvKq0wDo+REDPAn7sTxQnsmudYntj/oQ/U7b4ZmnApVWjF62KzMVdj9vML6ze1m03JC7Jmpb0+APMh6x8vLg7H4OLkvmlSa7zl0wBTP4MY4jCGjgCCCqRvgGdSk1LTCzsIjms2yHtotb0VCKa+gzcApheHUBijwoRnFHP4mtNXoI4/wxlUBT0ApjdBTiT+Vg3mvZLasw5d17EUFjHDVrYiMner0lKFkY0Q2b9QiKZ+RWPLNnwEXGKo6PtoCvYY+VVEJT4WL6c3EonOZTkyOIM X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JeqxeXOnWiDoXTwwK3AAIFhg3UZj9u31BIFBBKEKTCB368TnYhq3YR3crBqHhFYOAEmI2UCPWH3eEnGV0D7+FfeLw2t4QGbXWgKJzfibQpcV7fP1TyyY0gpmgTOJ+NVunAatKVk4/9DWpOnzwT5P/BkmobUy4aRPCs/jcxayPx++IKRyJMnqDgLFHXBoF4ne116qRkqdzF4dlrt26TLqDmhept/a9C/7TwzpxOiTEOV2+ytxYPOGmG4ymcxZ4V528Z+b0I4Nn6MMdkRAS1qaeQi/vEbKBZ4Mg7SbU/+CBPV5blggM71/TCioldIX7iuOPm+nI0jR2c+Oy9+Ix4jAinUZcA/hmQQQ1yvuMx79iTXdhIHMK2jtONTEN5ztbKmx6c4UmRrHOkI2f1Unf2BEXOoqtuS44LHtPoa3rFNT4aGQkWtu/EsjIBL+U1mlRVPTatVdRycvvwlyZHJFwtH5eaOmJH/pZp8LofVkpxYh/MMjgkHWhD1USExVTJy3HX9QaUqXuvp6DWgatq3cKwO8Ah+aAE+5rlUU2cnfvBD7NUpze/coFlAdQSUXe/aHFyEdaOytwa6JVPwgT2MEDVs7ffL+Hks0Chhapj70wkDR55UOqh73bE7+TeAZJhHZS1/496njDPYebEETwsxeW3b9JW7huURFk/3UZKXL5DTBi82WYRxST1l2wFywonrnwrqLpDpHveZ1Sw+7/fTEiX80NVziphnE9wo28++HbJUDcjUS6/3XBMOxw22SbyolhS/j+hpg9rK5bhUNbS8R5xhiwRgJxhmSN86YrOTCMIuX3zPKWksgu9vlMNNhVQfSXEQVGT9n1IYyT9Girw1RMsw49mxOsM4yqUMNTJlvfbG94+QnUi2h+pQkIB0iYrJG26dQzXqYR/mEF9pgR+6WtB892yuohUsOAbRB0C35zAuCJmBKOzu8gXVg0o0BLfzLkeHQ F1/pu6oZDb/K+V8ciPSFq7rVVLUj/gQQRLtQrHqxAWLQuZ+o8w8bjF+9BX05ywQL4jJ5fs9wWbC+BW5aTrWhTOWOA1KB9TXbTqlUrNr58oaMgULRI52ZdJobLqVhH5aKrK/HuqWDqLd6GqS5HLnG3n1oKJPlZhXgtI40dyZtlET5hS6Lv+dBVbT1l3eTR4HQPVtSHjtwCQNikJJKKYU6JJRBYUfE5jOuIBgumsAxZ6upr9/2kR3vxIiUUz/mlLaY/ZmIytnT7JHJYZXbQpQMvn7CoXhjQ4x5goGzkiRtSmGVJ06LlBGJlW6JcCLozbew X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-00b75.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 4eb4906f-d3ae-4ee4-e2c8-08dc99ef964d X-MS-Exchange-CrossTenant-AuthSource: PAXP251MB0348.EURP251.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2024 17:02:28.1530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2P251MB0946 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 7BCE750832 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.28 X-Spam-Score: -4.28 X-TUID: Q+pfyJQTWoL0 Hi! Thanks for taking a look. jgart writes: > Are you planning on resolving those TODO items soonish? This is what I was explaining on the version 2 of the patch. It's not something that should be fixed at the package level. I've discussed it with the maintainers, until they don't implement a proper way of externalizing the handling of libraries we should be using the submodules. Having said that, I think the package is ready, is there any reason why you don't find it adequate, aside from the bundled libraries? We can remove the comments if that's what worries you. As a side note, I tried to un-bundle the libraries and the amount of patching that it requires is unreasonable, every library requires it's own CMAKE find file, which is responsibility of the software developers. This is why I say that this should be done upstream. I suggest to merge it as it is and I will update the package definition once ImHex properly supports using system libraries. I don't think the maintainers have this on their priority list so I don't know how long it could take. I will send a v3 of this patch without the comments and without the redundant flags. > If you'd like to make this package easily available to others before its > ready for upstream I would recommend creating a channel for it. I have it already available on my channel. Thanks for your time! Have a good evening, Sergio.