From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQ0zX-0002t7-4K for guix-patches@gnu.org; Sun, 12 May 2019 22:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQ0zW-0004Fe-3U for guix-patches@gnu.org; Sun, 12 May 2019 22:47:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58506) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQ0zW-0004FU-0a for guix-patches@gnu.org; Sun, 12 May 2019 22:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQ0zV-0008Iz-Sz for guix-patches@gnu.org; Sun, 12 May 2019 22:47:01 -0400 Subject: [bug#35611] [PATCH 1/2] gnu: cross-base: Allow using non-default glibc. Resent-Message-ID: Date: Mon, 13 May 2019 02:46:39 +0000 From: Carl Dong Message-ID: In-Reply-To: <87woivs660.fsf@gnu.org> References: <87woivs660.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Carl Dong Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: "35611@debbugs.gnu.org" <35611@debbugs.gnu.org> Hi Ludovic, > Really a detail, but for clarity I would change =E2=80=9Cxlibc=E2=80= =9D to =E2=80=9Clibc=E2=80=9D, because > this argument denotes a C library, not a cross-compiled C library. > > Ditto in other places. > > You can send an updated patch or I can make this change on your behalf if= you > prefer, let me know! Ah yes! That does make it more clear. Could you make this change for me? Th= anks! > This procedure is starting to look weird. :-) I wonder if we should inlin= e it > at the call sites, but we can look into it later. Haha that's what I thought too... Inlining would probably make the most sen= se. I'll submit another patch to this effect at some point! Thank you so much for your help. Have an excellent day! Cheers, Carl Dong accounts@carldong.me "I fight for the users"