From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eNhlNftIUmEi2wAAgWs5BA (envelope-from ) for ; Tue, 28 Sep 2021 00:43:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id MJshMftIUmGRIQAA1q6Kng (envelope-from ) for ; Mon, 27 Sep 2021 22:43:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0F6BF268 for ; Tue, 28 Sep 2021 00:43:07 +0200 (CEST) Received: from localhost ([::1]:48430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUzL0-0006p2-UL for larch@yhetil.org; Mon, 27 Sep 2021 18:43:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUzKw-0006ok-16 for guix-patches@gnu.org; Mon, 27 Sep 2021 18:43:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUzKv-0000Cy-PV for guix-patches@gnu.org; Mon, 27 Sep 2021 18:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUzKv-0000it-MC for guix-patches@gnu.org; Mon, 27 Sep 2021 18:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49619] [PATCH v3 1/2] gnu: Add python-very-pretty-table. Resent-From: phodina Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Sep 2021 22:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49619 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49619@debbugs.gnu.org Received: via spool by 49619-submit@debbugs.gnu.org id=B49619.16327825312721 (code B ref 49619); Mon, 27 Sep 2021 22:43:01 +0000 Received: (at 49619) by debbugs.gnu.org; 27 Sep 2021 22:42:11 +0000 Received: from localhost ([127.0.0.1]:43081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUzK6-0000ho-Of for submit@debbugs.gnu.org; Mon, 27 Sep 2021 18:42:11 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:10560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUzK4-0000hW-Fd for 49619@debbugs.gnu.org; Mon, 27 Sep 2021 18:42:09 -0400 Date: Mon, 27 Sep 2021 22:41:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1632782518; bh=bFc+6zAK7ims/O0lXkwTa6yiZFZCPvSWKLPJh0oujnY=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=lxIP3i+CGS84venOlJJzSuZRCLmBKwx4KLJqVbHhfJSNzWniwDHKKzXnd9IVBHcmT xvUzNcKE8pqHW5G3RclaroAhylNDi704sj4b3DXW+pHluCeTC7GEi6srXRL+h0NkXK 9Jw9n3i6AOfrfxA3dfacGEVqlwIEfkGoyAH/TXvM= Message-ID: In-Reply-To: <8635pxxpke.fsf@mgsn.dev> References: <8635pxxpke.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: phodina X-ACL-Warn: , phodina via Guix-patches From: phodina via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: B0F6BF268 X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: ypj5+f88/s+i On Wednesday, September 22nd, 2021 at 5:21 AM, Sarah Morgensen wrote: > Hi, > > phodina phodina@protonmail.com writes: > > > Hi Sarah! > > > > Are these fixes now compliant to upstream the patch? > > It's pretty good. I went ahead and made a few changes (attached below): > > I tweaked the descriptions, I changed very-pretty-table to > > veryprettytable so the python importer can find it in the future, I > > changed pirate-get's propagated-inputs to inputs since it's an end-user > > package, and I changed the license of pirate-get to AGPL-3. > > - Package review checklist (WIP) > > Lack of a check is not proof of noncompliance. > > 1. [X] Package builds (guix build package) > > [X] x86_64 [ ] aarch64 [ ] armhf [ ] powerpc64le > > [ ] i686 [ ] i586 [ ] mips64le > 2. [X] Build is reproducible (guix build --rounds=3Dn package) > 3. [X] Tests enabled (if available) or disabled with in-source comment > 4. [X] No extraneous dependencies (guix size package) > 5. [X] No unnecessary pre-built binaries/blobs > 6. [X] Dependencies unvendored when available in Guix > 7. [X] Cross-compile friendly (cc-for-target, patches with inputs) > 8. [X] License matches source > 9. [X] No problematic lints (guix lint package) > 10. [X] Formatting follows guidelines > - [X] Lines wrap at 80 characters > - [X] Indentation passes etc/indent-code.el > - [X] Two spaces used between sentences > > For new packages: > 11. [X] Source url is robust > - mirror:// used with url-fetch when possible > - No auto-generated archives from source repo (prefer cloning) > 12. [X] Synopsis is short, descriptive, and meaningful to a wide audienc= e > 13. [X] Description is objective, takes 5-10 lines, uses full sentences, > Thanks for the list! I'll follow it next time I'll submit a package or prop= ose a change :-) > and provides the information users need to decide whether the > > software fits their needs. > > I also gave it a spin, and it works fine as long as the SSL_CERT_DIR > > environment variable is defined (I think that's beyond the scope of t= his > Well I also thought about the certificates but as you mentioned that's prob= ably out of scope and it would be good to handle it by default in the build= script so that we don't have to do it for the packages requiring network c= onnectivity. > package). LGTM. > > Thanks for your work! You're welcome. Guix is the exact distribution I've been looking for and po= rting tools I use is a nice way to get familiar with the Guile programming = language and the ideas behind Guix (and Nix :) > > -- > > Sarah