From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aJ3UKpZe+mZDugAA62LTzQ:P1 (envelope-from ) for ; Mon, 30 Sep 2024 08:17:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id aJ3UKpZe+mZDugAA62LTzQ (envelope-from ) for ; Mon, 30 Sep 2024 10:17:26 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=o0Ks1pXw; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail2 header.b=rwnqtBRi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=lendvai.name (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727684246; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/okA4gdlk1uPaaNHUL7+3cYbDStukrqXMhdzxvsmSXQ=; b=Um2U6GhbdABrTypBP0ihgp3irnJyuLmXREbbaieiZGLOa4lFOm0f8g84ztgeCc8jSIjqOg D8i6FAhVXRYMxuN53uDAyZVXctiw3MWsNs8gM7fz2cijC58SvNhm+pCljRJqJnCVkarppe KtqeN/ZtI6Mm3XEnsk/lhpRhk3UeMLFtBGvYOnD+oi1oSNd21RgzaV1SAzjhCzCkJD9+Pk NnnCOYrteEYaS+GEAzBdX24yKMMBSpWLpp24HHQk9kMElTYW+JunqdnHMC3x6lUGlVwEsy AcNz6ycGZoyx+3ZUeO8WwXVr4pHLk2hD9yuGVQ63EXQh8NI8z6nbFkNu4/Bpig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727684246; a=rsa-sha256; cv=none; b=c9IZZQRBbSY7w23FM99Nru3qWYPaNzeUv0eE9dz5PoLRAZ2bOLZ/4b7j7EWLqPxB9GziIZ pzNuWTtPjIGh3QCfg5X3J86UtYV3MD3JBSrsw1jWqKqI13wBj/GSAKaA2DSrsn+X7T3zbH m5yVj2DAHio+l4aXskqtTcPGdd5nBAOn4viF8+Zwgl7io6YNZLy12aLLAbuR384Dxjk2xz nHS9bjpIKl9cy+9XVE8b4fGGhV6IMA8B7wGhAM3xKYZ19X6twmhAh3RK0ZqRpK994vfHin fK5R3VYdI7zp3zZJ1goBiIk6P2zOtyW0+i3WnPaMQgJZ8KVMes+7kOUpidgbZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=o0Ks1pXw; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail2 header.b=rwnqtBRi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=lendvai.name (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2868784BEA for ; Mon, 30 Sep 2024 10:17:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svBZA-00029J-7S; Mon, 30 Sep 2024 04:15:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svBZ5-00020K-LF for guix-patches@gnu.org; Mon, 30 Sep 2024 04:15:31 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svBZ4-0005dG-CD for guix-patches@gnu.org; Mon, 30 Sep 2024 04:15:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=/okA4gdlk1uPaaNHUL7+3cYbDStukrqXMhdzxvsmSXQ=; b=o0Ks1pXwTOHPT8E/xugcSlJVnlcRKOWG3Jkl+6RQgzjLNL1OyS6TOQGcq5p695S64fyvEMG0T29hcm2c2cSP7B1dohMe8B+/OllvUv2w19pTkgh19xBFZTUWHcAutVj3ZAhhsPBeYE4HD4AsNx60p1nePTM+eP2KIQpcQLiD250TTU2gEXZCPOPtI1x2uctFk9ykUwsiUyv4BcYTtFVzXn7143voZN9iBUbIN+zY1q8hKHM1DygX83ZhM3MGhTMqiv+mhf36L4u0tmuv8RKCxLin9ZmVhHcEHdHRmzK5rU9rBLIzLcMLovIs7RURegPl5KYNIjPAP8AjuSVlvY8zbw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svBZa-0001xJ-Ar for guix-patches@gnu.org; Mon, 30 Sep 2024 04:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73529] [PATCH core] gnu: patchelf: Build from git sources. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Sep 2024 08:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73529 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Z572 Cc: attila.lendvai@gmail.com, 73529@debbugs.gnu.org Received: via spool by 73529-submit@debbugs.gnu.org id=B73529.17276841046999 (code B ref 73529); Mon, 30 Sep 2024 08:16:02 +0000 Received: (at 73529) by debbugs.gnu.org; 30 Sep 2024 08:15:04 +0000 Received: from localhost ([127.0.0.1]:44660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svBYe-0001op-4m for submit@debbugs.gnu.org; Mon, 30 Sep 2024 04:15:04 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:50647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svBYa-0001oF-Qo for 73529@debbugs.gnu.org; Mon, 30 Sep 2024 04:15:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail2; t=1727684061; x=1727943261; bh=/okA4gdlk1uPaaNHUL7+3cYbDStukrqXMhdzxvsmSXQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=rwnqtBRidhQh6x7B/SS5uPsCGBbbEY6c+G6Cx5C9glb4f+EBHlZmBbla5e75l9Zff DB3UneCU6sLqxTfmhdJkGHs7TbVh8Tnd2biFtxPaGXlXKt7V1VPRPUvm0/UWYgX6he 3qost8ZgDIB37XFGAS021OUyYgypKRv1NWH0q9zcapbIzyWvdQucoWBAG3+pgX4V06 r0y5AqP2ZX6VWBYkN5y0kSEmfk5ayDqy8bp677+IILUE9NDB7TNSznMekJiGApakba aDrHB77jFc59wR2sVoOoyUwnjxXOvFTEolvTdaF37A2imCmxXVRLqia1Y0GHORUydt 5eAQLlhBXS6YQ== Date: Mon, 30 Sep 2024 08:14:17 +0000 From: Attila Lendvai Message-ID: In-Reply-To: <87r0928mms.fsf@iscas.ac.cn> References: <91e06adbec896b8e685d7bc2501da3e7dc932233.1727525522.git.attila@lendvai.name> <87r0928mms.fsf@iscas.ac.cn> Feedback-ID: 28384833:user:proton X-Pm-Message-ID: 93d38beaca186b61f5ccae251dea875df47fa2ba MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 2868784BEA X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -1.33 X-Migadu-Spam-Score: -1.33 X-TUID: i6A8rup9nYHd > > + (file-name (git-file-name "patchelf" version)) >=20 >=20 > i think should "(git-file-name name version)" ? hrm. i tried that at first, but it errored out with `name` being undefined.= i retried it just now to double check, and now it works. i must have been = confused by something. the updated patch will have `name` in there. > > + (sha256 > > + (base32 > > + "1v5mh8wdax4a97hw79nvzy0dixkbs0h487xkskkljkkdamq4rj5z")))) > > (build-system gnu-build-system) > > (arguments > > '(#:phases > > (modify-phases %standard-phases > > - (add-after 'unpack 'fix-tests > > + (add-after 'bootstrap 'fix-tests >=20 >=20 > Just a question, why do you need to change to bootstrap here? because the last substitute* touches `tests/Makefile.in` which is generated= by the bootstrap phase (by the auto* tools). but now that you asked, i've changed it to target `tests/Makefile.am` inste= ad. > > (native-inputs > > - `(("gcc:lib" ,gcc "lib"))) > > + (list > > + autoconf > > + automake > > + (list gcc "lib"))) >=20 >=20 > It would be nice to mention removing labels and adding new dependencies > in the submission, and etc/committer.scm maybe useful. ok, i'll send an updated patch soon. BTW, etc/committer.scm broke on this package. i've sent a patch to fix that= : https://issues.guix.gnu.org/73562 --=20 =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CWhere there are rulers, there are no rules, only interest-serving = opinions enforced by violence. To want rulers is to beg for chaos.=E2=80= =9D =09=E2=80=94 Brandon Roark