From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id i8o0Ml0YMmH88AAAgWs5BA (envelope-from ) for ; Fri, 03 Sep 2021 14:43:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id AEWcLV0YMmE2fgAAB5/wlQ (envelope-from ) for ; Fri, 03 Sep 2021 12:43:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F65520EB8 for ; Fri, 3 Sep 2021 14:43:09 +0200 (CEST) Received: from localhost ([::1]:42806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mM8XE-0006pt-6D for larch@yhetil.org; Fri, 03 Sep 2021 08:43:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM8X9-0006na-5y for guix-patches@gnu.org; Fri, 03 Sep 2021 08:43:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mM8X8-0007sF-Uf for guix-patches@gnu.org; Fri, 03 Sep 2021 08:43:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mM8X8-0000Uk-Cu for guix-patches@gnu.org; Fri, 03 Sep 2021 08:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#45692] [PATCH v4 3/3] gnu: Add ZFS service type. Resent-From: raid5atemyhomework Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Sep 2021 12:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45692 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , Efraim Flashner Cc: "45692@debbugs.gnu.org" <45692@debbugs.gnu.org> Received: via spool by 45692-submit@debbugs.gnu.org id=B45692.16306729321840 (code B ref 45692); Fri, 03 Sep 2021 12:43:02 +0000 Received: (at 45692) by debbugs.gnu.org; 3 Sep 2021 12:42:12 +0000 Received: from localhost ([127.0.0.1]:43268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM8WK-0000Tb-0U for submit@debbugs.gnu.org; Fri, 03 Sep 2021 08:42:12 -0400 Received: from mail-4318.protonmail.ch ([185.70.43.18]:34747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM8WH-0000TO-9g for 45692@debbugs.gnu.org; Fri, 03 Sep 2021 08:42:10 -0400 Date: Fri, 03 Sep 2021 12:41:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1630672921; bh=CfmColcHtExzctjfoPwVCCLr1NstiiH+evlsrqtWeW0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=AyyR0kbbyXUrHWOHzCeP4mXMrFoAlS7HeM/5t0R0HyybWjlEPeAYtUy2QM4nqJIq6 phM4t6TFFSq/qwKfioGRZyEFFeOB6Aja0cT5ut5g+Tp4iFvWvIFXlqgDP8w8XJF552 8dZUQWzp/o+UVcWnKdHlnouudkhqvsXjEw0IzAYA= Message-ID: In-Reply-To: References: <2020c2223378c7eb3635defb27e6b4545e048b9f.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: raid5atemyhomework X-ACL-Warn: , raid5atemyhomework via Guix-patches From: raid5atemyhomework via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630672989; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CfmColcHtExzctjfoPwVCCLr1NstiiH+evlsrqtWeW0=; b=UahQPMv7e6PMTpenBxN1I/UYgytgzp6VJi9TQoo+oaiIEa4SjeEbvP96YgYsFjWwBzoCbG 3WZv+HRHgneJcTfW4JMz+V42jpsOSHZENtQNGKJiG3DlMNIGZ6xQ0A7nS2lIzHqhBBZ2K3 6QT0eCAU9vaxpvLjbC6NdW7GsrvWeQF+/jF3mlBDDTzG/81gEa/lFkYctfniUXsfWl2fPE 7cYNgXGl20cTHX5HxIN06YZGMTy91VtwkYTSCCNtwnvcgA9LhR36vRKJmIy1nwsNB/0Sa3 vPKcN6bU/kGL40ADvwNJNagHw+W6cnN1o8VPI5mw6b4wSAcm/hil9M0oFuGKAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630672989; a=rsa-sha256; cv=none; b=CdtjuGFFD8h1bN0yNcJFsZ1k+hFNHL0SEi3ahLq4/7eJ/HTECXT8O9aQuwafF+jRjJ1oOU L2xqnv2uYx82g2iKf9yEf9AliRjd4Nw6mhg0xtqMojfQGZG6pySP7SdG0PNF51lMRIXpid XdRFgVtrRTwDv0CFJgtjAK3bpI+dpAeSZwGCeMfsqVpf/9oVaMJTPpHrs9WOlOhyji1WMe IxcyEShQIr6yLLfp56pnp76Sq4wJQmwEq7UtDVVoI/2Eyk4mnNNytcaYiplt8MiczLMTA7 0SVf9HeY09HwgPZWRzwvYe2uRI0XZcEUw8DaMhM1RV+iGqqcI9LxxHW1Eyt94Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=AyyR0kbb; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=AyyR0kbb; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3F65520EB8 X-Spam-Score: -2.92 X-Migadu-Scanner: scn1.migadu.com X-TUID: TOkqHs61ZEhk Greetings Maxime, > Maxime Devos schreef op do 02-09-2021 om 22:57 [+0200]: > > > Hi, > > Some comments on the code. Spoiler: the code is presumably good, > > but there's a GPL violation. > > Nevermind, it's apparently less of an issue than I expected? > See the links to IRC at https://issues.guix.gnu.org/50347. Note that this patch does ***not*** add ZFS to the Guix project. Instead, this patch creates a convenient service that uses the existing `zf= s` package and builds the user system so that the user downloads the ZFS so= urce code, compiles it, and links it to the kernel on the system. In #50347, you refer to this analysis: https://sfconservancy.org/blog/2016/= feb/25/zfs-and-linux/ I quote this part: > ## Is The Analysis Different With Source-Only Distribution? > > ... > > Pure distribution of source with no binaries is undeniably different. Whe= n > distributing source code and no binaries, requirements in those sections = of > GPLv2 and CDDLv1 that cover modification and/or binary (or =E2=80=9CExecu= table=E2=80=9D, as > CDDLv1 calls it) distribution do not activate. Therefore, the analysis is > simpler, and we find no specific clause in either license that prohibits > source-only redistribution of Linux and ZFS, even on the same distributio= n > media. This is in line with the analysis already quoted in the documentation added= : https://www.fsf.org/licensing/zfs-and-linux Guix does ***not*** distribute any binaries; see the file `gnu/packages/fil= e-systems.scm` in the **current** `master` branch of Guix: > `(;; The ZFS kernel module should not be downloaded since the license > ;; terms don't allow for distributing it, only building it locally. > #:substitutable? #f Note that the above code ***predates*** this patch: fe338d7f009 (Efraim Fla= shner 2019-12-19 11:47:49 +0200 1188) Also CCing Efraim here --- presumably he had some choice arguments about ho= w `zfs` got into `gnu/packages/file-systems.scm` in the first place. If the CDDL-GPL incompatibility is problematic, then why is it only being b= rought up now, why did it not get brought up in 2019, when Efraim was submi= tting the patch that put the ZFS package into Guix in the first place? The code in this patch does not do anything that the user cannot do with th= eir own scripts (indeed, I prototyped much of the code in my own `configura= tion.scm`). The code in this patch also does not link, directly or indirectly, into the= ZFS kernel module. At worst, the code in this patch executes the binaries that are the output = of compilation, but since it is invoked as a separate binary running in a s= eparate process, there is no legal basis for considering this as "linking",= as opposed to merely invoking a separate program (if merely invoking a sep= arate program was enough to "link", then Windows cannot run any free softwa= re). Your referred document then makes some speculation that even source distrib= ution might be problematic. However, Guix does *not* even distribute sources, by my understanding --- t= he Guix build downloads from https://github.com/openzfs/zfs/releases/ witho= ut going through any Guix servers, so this should be even less of a problem= . If anyone is at legal risk, it is github, not Guix, for distributing the so= urces --- and it would be very strange for Oracle to not go after github fo= r distributing source code that is intended to be linked to GPL code, but g= o after Guix; Guix is a much more niche project than the openzfs/zfs projec= t on github. (my understanding is that Oracle implicitly allows the existence of openzfs= /zfs, even has some maintainers of the project on their payroll, so it woul= d be very strange to go after software that just downloads the source code = from that project, compiles it, links it, and does ***not*** distribute it = (`#:substitutable? #f`)) My understanding (and my argument) is that the already-existing code introd= uced in fe338d7f009 does not represent a distribution of any ZFS code, not = even source: * The existing fe338d7f009 code tells Guix to download from a github server= , not from Guix. * The existing fe338d7f009 code specifically tells Cuirass to not provide a= binary substitute, so Guix end-users must download from github, not from a= ny Guix servers. * Thus, even if source distribution is legally problematic, Guix does not= even distribute the source; the existing fe338d7f009 code just downloads i= t from an existing distributor. * That Oracle tolerates the continued existence of https://github.com/ope= nzfs/zfs undermines any legal argument Oracle might make if somebody else b= uilds a script that downloads ZFS from https://github.com/openzfs/zfd and c= ompiles it and links it to GPL code locally without redistributing; that pr= oject already contains human-readable instructions on how to download, buil= d, and link ZFS to a Linux kernel, the existing fe338d7f009 code merely tra= nslated that text to a machine-readable program. If Oracle thinks this is legally problematic, they should have demanded= shutdown of the https://github.com/openzfs/zfs project first, a much more = popular project than Guix. * The actual code in this patch does not directly invoke the ZFS kernel mod= ule. * The actual code in this patch does link the ZFS kernel module to the ke= rnel of the *local* system, but does not make this linked version available= to others; it is only available locally on the system of the user that inv= okes this actual code. Again, this is merely a translation (to machine-readable text instructi= ons) of human-readable text instructions on how to link the ZFS kernel modu= le to the Linux kernel, text available publicly on https://github.com/openz= fs/zfs. * The actual code in this patch invokes the ZFS tools as separate program= s, thus does not link with them. Thanks raid5atemyhomework