bug#52791: nextcloud-client not building on master

bug#52791: nextcloud-client not building on master

[Nicholas von Klitzing]

Hello Guix,

nextcloud-client has been broken in recent updates to guix and is no longer building:

https://ci.guix.gnu.org/build/238676/details

All the errors are in the form of
```
/tmp/guix-build-nextcloud-client-3.1.3.drv-0/build/src/gui/nextcloud_autogen/YCDLW3T4OG/qrc_theme.cpp
In file included from /gnu/store/qqs98rxwjrji6aaf6dqwp7q4m545g2sn-glib-2.70.0/include/glib-2.0/glib/glib-typeof.h:39,
                 from /gnu/store/qqs98rxwjrji6aaf6dqwp7q4m545g2sn-glib-2.70.0/include/glib-2.0/glib/gatomic.h:28,
                 from /gnu/store/qqs98rxwjrji6aaf6dqwp7q4m545g2sn-glib-2.70.0/include/glib-2.0/glib/gthread.h:32,
                 from /gnu/store/qqs98rxwjrji6aaf6dqwp7q4m545g2sn-glib-2.70.0/include/glib-2.0/glib/gasyncqueue.h:32,
                 from /gnu/store/qqs98rxwjrji6aaf6dqwp7q4m545g2sn-glib-2.70.0/include/glib-2.0/glib.h:32,
                 from /tmp/guix-build-nextcloud-client-3.1.3.drv-0/source/src/gui/cloudproviders/cloudprovidermanager.cpp:16:
/gnu/store/vakvgvrb839igv16jkif4lmx11d25jqb-gcc-10.3.0/include/c++/type_traits:56:3: error: template with C linkage
   56 |   template<typename _Tp, _Tp __v>
      |   ^~~~~~~~
/tmp/guix-build-nextcloud-client-3.1.3.drv-0/source/src/gui/cloudproviders/cloudprovidermanager.cpp:15:1: note: ?extern "C"? linkage started here
   15 | extern "C" {
      | ^~~~~~~~~~
```

They see to be directly related to an issue patched in more recent versions of Nextcloud Desktop:

https://github.com/nextcloud/desktop/pull/2972

Kind regards,
Nicholas von Klitzing

bug#52791: possible patch

[Nicholas von Klitzing]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

Updating the package to 3.2.0 (the version where the PR was merged) solves the issue. This patch is attached.

I'll see if I get to updating it to 3.4.1

Kind regards,
Nicholas von Klitzing

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-nextcloud-client-Update-to-3.2.0.patch --]
[-- Type: text/x-patch; name=0001-gnu-nextcloud-client-Update-to-3.2.0.patch, Size: 1128 bytes --]

From a1d28e218ac38d656d90de3b5346f21ea2423a4c Mon Sep 17 00:00:00 2001
From: Nicholas von Klitzing <nicholas@nvk.pm>
Date: Sat, 25 Dec 2021 20:14:13 +0100
Subject: [PATCH] gnu: nextcloud-client: Update to 3.2.0.

* gnu/packages/sync.scm (nextcloud-client): Update to 3.2.0.
---
 gnu/packages/sync.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm
index ce815ed5c7..165be17e4c 100644
--- a/gnu/packages/sync.scm
+++ b/gnu/packages/sync.scm
@@ -71,7 +71,7 @@ (define-module (gnu packages sync)
 (define-public nextcloud-client
   (package
     (name "nextcloud-client")
-    (version "3.1.3")
+    (version "3.2.0")
     (source
      (origin
        (method git-fetch)
@@ -82,7 +82,7 @@ (define-public nextcloud-client
        (file-name
         (git-file-name name version))
        (sha256
-        (base32 "15ymk3gvfmgwzmqbhlw7jjy9y65ib3391h1dlmpll65iaj2miajk"))
+        (base32 "137h65sn4ixspbblvn0r2ngg8234yk582bppkkr87c3krfp21gx4"))
        (modules '((guix build utils)
                   (ice-9 ftw)
                   (srfi srfi-1)))
-- 
2.34.0

bug#52791: nextcloud-client not building on master

[Brice Waegeneire]

Hello Nicholas,

Nicholas von Klitzing <nicholas@nvk.pm> writes:

> Updating the package to 3.2.0 (the version where the PR was merged) solves
> the issue. This patch is attached.
>
> I'll see if I get to updating it to 3.4.1

> * gnu/packages/sync.scm (nextcloud-client): Update to 3.2.0.
> ---
>  gnu/packages/sync.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thank you for fixing that failing build, pushed as
27eb4ac9f506f9f06061d79548de5da53ac03bfa.

If you want to update it to it's latestet version, don't forget to run "guix
lint" on it and add your copyright to the file if it's a non trivial change.

Cheers,
- Brice