From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4Cf3Gby/E2IafgEAgWs5BA (envelope-from ) for ; Mon, 21 Feb 2022 17:37:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CO7ZFry/E2IunwAA9RJhRA (envelope-from ) for ; Mon, 21 Feb 2022 17:37:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E8FDB40BF3 for ; Mon, 21 Feb 2022 17:37:15 +0100 (CET) Received: from localhost ([::1]:54640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMBgY-0004MQ-Kn for larch@yhetil.org; Mon, 21 Feb 2022 11:37:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMBgN-0004JI-39 for guix-patches@gnu.org; Mon, 21 Feb 2022 11:37:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMBgM-0000Dt-GJ for guix-patches@gnu.org; Mon, 21 Feb 2022 11:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMBgM-0000V6-De for guix-patches@gnu.org; Mon, 21 Feb 2022 11:37:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53015] [PATCH 0/4] Add mangohud (update dear-imgui) Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Feb 2022 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53015 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: "53015@debbugs.gnu.org" <53015@debbugs.gnu.org>, Nicolas Goaziou Received: via spool by 53015-submit@debbugs.gnu.org id=B53015.16454614141907 (code B ref 53015); Mon, 21 Feb 2022 16:37:02 +0000 Received: (at 53015) by debbugs.gnu.org; 21 Feb 2022 16:36:54 +0000 Received: from localhost ([127.0.0.1]:38793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMBg5-0000UX-O2 for submit@debbugs.gnu.org; Mon, 21 Feb 2022 11:36:54 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:11221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMBg2-0000UF-OR for 53015@debbugs.gnu.org; Mon, 21 Feb 2022 11:36:44 -0500 Date: Mon, 21 Feb 2022 16:36:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1645461394; bh=wta8UAy7ZdpGdllwz1YDjWbzOvbi+djS+a3twFRe1to=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=OF1ahkO+zK1smcAhReZpiGtnKHYo0279xd/NgP2qoG2o7xSLwUbxGbYr13dCxItO9 MJWywwD5DdEd/FW0Hb7a7O9i/NS/zWTCiwPrZvzXUbf5UJN+lS84zdBW00P4lQ+svF LrcBkFUstT2zGIABg8BuWHijTx36iuY6gQECxd5yqWJ/gKokFxtFF4azQJHjXtMttK P2UlAQ5YyyMj/nFtxhSbvN5UNW0KvoaOTDR3KY7EwPMk8wao6iO7BVtqGm6VIYWqgs 2YKb2Xdy8HsAc46uXgQG0F18tdqQrUptEHZA2QMMroi145WYSHBHnD2diuQbDeKT78 TljkVcrJkiStw== Message-ID: In-Reply-To: <87czjgq2np.fsf_-_@gmail.com> References: <20wqWzWXCQm8C64APXWiUBQfFY0dYThLJMM9eoq7iiTvAoYra7wo97BUbAZwwW8O8PUdY5JNx_7gdA6QIAv-x6-dU3QsnkXKGW7V6mJjpaY=@protonmail.com> <87czjgq2np.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645461436; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wta8UAy7ZdpGdllwz1YDjWbzOvbi+djS+a3twFRe1to=; b=QM9S4UT46tiDtxD3iuqdre+2zKhex4uxwPQVWpBD0WE80Dy+EOmRm9b3o+zzjvMzHQx5Pi 5hPgCYPxjj9hq+yJkYGfson1USDRmKTpmki7qErk0Vr85PziTJjaGk275jOnuBd6nqwNz0 lbMk0FpdL/+cxeNM4TAgyg5M00ynXfLLSgreISNfwgCYfGgz5aoUpkIOhiq+mmQXgGa7eK YcinWI5Zl1rGlWG0d9UMyNRC43EQgFO2h66fqDLJ5Ia20wanpSkbRg5B67M7rHAqVoxsDD SXEZUQeW7Z/nFX4cnoAIyZxucX86ZcKgehfm7u5uV71OXlReXsTBjmjaBspCoA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645461436; a=rsa-sha256; cv=none; b=VQErPAhYRF2w+DQ9ao3nkezaM0qzshdwC+OwD95N6yA2j0m9+zVvLjCvvoqGxbHdUtHzVc rpJAQ3Yu+xZzudhWrT6ZujJa3lJo587nBlJiw+7uaye1M0c/toNNqc3uTSXGRdb59T2PXr R1YsxHJUj0ftr5cJGHtIvNrQdpH2yzhOebkUq5mzbtm+eNGI1A/26i9g3VvWdrhzdaE227 a7kYzns/dqGMeEkqc0YHMcO6IuzlK5fPKim5rly30iHbIHXi8ji/QfNAHkDGqFNTqm1yZ2 +wfjvCygvsCKnGC3ySTD0x+02vqnvX8p+EQnLYBkULs4+k3Xzy+KQzr4odgGhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=OF1ahkO+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=OF1ahkO+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E8FDB40BF3 X-Spam-Score: -4.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: GeS26WpJLs9p Hi Maxim, ------- Original Message ------- On Sunday, February 20th, 2022 at 11:11 PM, Maxim Cournoyer wrote: > Hi John, > > John Kehayias john.kehayias@protonmail.com writes: > > > Hello, > > > > This patch (2/4 build option for spdlog, part of the MangoHud patch > > series) may be superseded by > > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3Db1542d59606919d= 0da04914fa6916b85354e2f89 > > (CCing Nicolas, hope that's okay!) I've built MangoHud with the shared > > spdlog before, seems to work. > > That should solve the problem, yes! > > > However, given what spdlog has in its documentation, I wonder if it > > would be better to default to the static version as before? I think > > the "-fpic" build option would also work for shared linking in > > general? Or does that not work for nheko, which this change was for I > > believe? > > Do you mean this: > https://github.com/gabime/spdlog/wiki/How-to-use-spdlog-in-DLLs ? > Yes, that's what I meant. I'm not familiar with spdlog, but was just going = based on that and seeing packages build a static spdlog to use. > > I'm not really sure though, nor have a strong opinion, just going > > based on spdlog's info and that some projects (like MangoHud) build > > spdlog as a static library by default when bundling. I'm guessing it > > is for performance reasons, though I don't know if that is realized. > > Typically in Guix the libraries are offered as shared objects by > default; and when desirable a static output can be added to which the > static objects are copied. > > You could add a static output if you have such a need :-). > Got it. Personally, it doesn't matter much to me, I'm only assuming project= s use the static version due to what upstream says and/or for performance r= easons (no idea if that is realized though). In the interest of moving this forward, I'm definitely fine leaving spdlog = as it was updated. We could add a note that upstream and other projects pre= fer a static build and leave that to add as a TODO. I did take a stab at it= some time ago, but it got slightly messy in trying to do it all together (= I suppose I could just run the build a second time, but I think it also req= uired modifications to other files to make the static build work separately= ? I forget now.) Any thoughts on the imgui details? For me, I'd go for keeping both current = (old) dear-imgui as hidden for ogre, adding the one I have here (hidden too= ? though useful Debian additions in the build) for mangohud, and consolidat= ing to one up to date version once everything can use that. We could use th= e imgui you added for that, or wait for the more complete Debian build file= s we are using for dear-imgui right now (the pkg-config, for instance, is h= elpful). Finally, the pciutils hardware data pci.ids came up in a new patch: https:/= /issues.guix.gnu.org/54069 I commented on that issue about doing something = similar here. I think we can figure out what to do in a core updates change= (due to pciutils dependents). In the meantime, a pciutils variant and/or a= separate hwdata package would be helpful. Funny enough, this is the last n= on-trivial change in this patch series, brought up by someone else. I guess= the repeated work shows this would be useful though. Would love to finally get this merged, with whatever changes we decide for = imgui and pciutils. WDYT? Thanks! John