all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 38755@debbugs.gnu.org
Subject: bug#38755: icecat retains reference on clang
Date: Sun, 29 Dec 2019 00:05:28 +0100	[thread overview]
Message-ID: <FD59D6BF-035A-4F2A-9E48-17176405D0C4@lepiller.eu> (raw)
In-Reply-To: <20191228194740.GR23018@E5400>

Le 28 décembre 2019 20:47:40 GMT+01:00, Efraim Flashner <efraim@flashner.co.il> a écrit :
>On Sat, Dec 28, 2019 at 01:25:50AM +0100, Ludovic Courtès wrote:
>> Hi,
>> 
>> Ricardo Wurmus <rekado@elephly.net> skribis:
>> 
>> > This should do the trick:
>> >
>> > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
>> > index d5d9839e1a..e9458037a5 100644
>> > --- a/gnu/packages/gnuzilla.scm
>> > +++ b/gnu/packages/gnuzilla.scm
>> > @@ -1023,7 +1023,11 @@ from forcing GEXP-PROMISE."
>> >                 (format #t "configure flags: ~s~%" flags)
>> >                 (apply invoke bash
>> >                        (string-append srcdir "/configure")
>> > -                      flags))))
>> > +                      flags)
>> > +               ;; Remove references to store items
>> > +               (substitute* "toolkit/content/buildconfig.html"
>> > +                 (("/gnu/store") ""))
>> 
>> This should not be a literal “/gnu/store”, though.  Perhaps we should
>> just use ‘remove-store-references’ instead of ‘substitute*’?
>> 
>
>This way we still get a listing of exactly which store items were used
>without needing to refer to them exactly.

It shouldn't be literaly /gnu/store, because one could use a different store path. Can we access the store path from a phase code?

  reply	other threads:[~2019-12-28 23:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-26 20:49 bug#38755: icecat retains reference on clang Ricardo Wurmus
     [not found] ` <handler.38755.B.157739336123029.ack@debbugs.gnu.org>
2019-12-26 23:08   ` Ricardo Wurmus
2019-12-28  0:25     ` Ludovic Courtès
2019-12-28 19:47       ` Efraim Flashner
2019-12-28 23:05         ` Julien Lepiller [this message]
2019-12-29  7:16           ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FD59D6BF-035A-4F2A-9E48-17176405D0C4@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=38755@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.