From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2PXBGut0iWGyCQAAgWs5BA (envelope-from ) for ; Mon, 08 Nov 2021 20:05:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ABhyFut0iWG1ZgAA1q6Kng (envelope-from ) for ; Mon, 08 Nov 2021 19:05:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1551B28A8F for ; Mon, 8 Nov 2021 20:05:15 +0100 (CET) Received: from localhost ([::1]:46978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mk9xC-0003xq-9N for larch@yhetil.org; Mon, 08 Nov 2021 14:05:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mk9x0-0003xJ-3x for guix-patches@gnu.org; Mon, 08 Nov 2021 14:05:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mk9wz-0001YN-Rm for guix-patches@gnu.org; Mon, 08 Nov 2021 14:05:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mk9wz-0002qy-NF for guix-patches@gnu.org; Mon, 08 Nov 2021 14:05:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51538] First Patch Submit Ever: Additions to the Cookbook Documentation Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 08 Nov 2021 19:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51538 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 51538@debbugs.gnu.org, pelzflorian@pelzflorian.de, disseminatedissent@protonmail.com X-Debbugs-Original-To: guix-patches@gnu.org, "pelzflorian (Florian Pelz)" , Disseminate Dissent X-Debbugs-Original-Cc: 51538@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163639827810924 (code B ref -1); Mon, 08 Nov 2021 19:05:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Nov 2021 19:04:38 +0000 Received: from localhost ([127.0.0.1]:59494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mk9wc-0002q8-34 for submit@debbugs.gnu.org; Mon, 08 Nov 2021 14:04:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:48622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mk9wa-0002pz-9t for submit@debbugs.gnu.org; Mon, 08 Nov 2021 14:04:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mk9wa-0003uV-66 for guix-patches@gnu.org; Mon, 08 Nov 2021 14:04:36 -0500 Received: from lepiller.eu ([89.234.186.109]:36068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mk9wX-0001U7-JQ for guix-patches@gnu.org; Mon, 08 Nov 2021 14:04:35 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 7466d97d; Mon, 8 Nov 2021 19:04:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=fUlTImwpBU6w TMs81l+V/5+93SWUS3eLssWxXQr6XY0=; b=dgK5lBCMW/qTPIQMHkCU17gRQJCO 5NXimiHMDctp2jHV3W0CH8ZJoCewGt74a8HVO6NlTYKl3SqH5KAqUDtUZLAgfyuX BxWPDVehqRRbyXR2R9sILK8rAPVhz5aLYFJPPm2PWo9KZR442AVkuewm4bPxg3N0 1cYkMKUaNFcf1c5yuMV7d+5WE1YqdKy+Nrf5erfVCdEBVL+E8tW07RzQvf8bIC/s N3tFWx+5uzvCorStSNErzfNsoN4AJePtL1nq/UyAVSXRwkhQvZxkxXsjbRJ0s9Xy zfiAF9s69vTuqeWRv2Bfmwahx3SHCX5CNcAbikRHMonFstxH+ez3JL1Khg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 6d6ce7af (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 8 Nov 2021 19:04:25 +0000 (UTC) Date: Mon, 08 Nov 2021 14:04:12 -0500 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: <20211108171850.q6pqyiv4g5q2oktr@pelzflorian.localdomain> References: <20211108171850.q6pqyiv4g5q2oktr@pelzflorian.localdomain> Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----YS9O4FDVDMP6HDWL535UWDK16IITY8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=89.234.186.109; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636398315; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=psUySFg/d2sFuAthF7i2Y0ypURkcVFnHnR8xpC8JW0M=; b=QJXL2kwWZU1UwpJ8Pp6P/Yt5nmQjrSaza2P5Wi9+CSjaHEjbmcJmHECAliCqczIGXU56pn xKyGvaCwMX026DlNZY2PN7971nU0FWdI7zxbALfALlYPhfiA29enbT0uvlJTJeu3tJY2qn Yf2WdPJQb05GdzGu6t2k5GFi8xDbau5UnIeeiXvxu53epV6+iW/l+LMGjl4+zgUMPyCos0 SeOElWztcq8FgEF9ASh5anMDNPROBs566Tu4bbPSg3SgGJibTV9rolNdiEvAFecsOiiS9N bQDCAfKI51eShvqQT4s/vWaZRj1Js7UZeLM/hnErUo+ycZ+D43XlcZou6d+iAw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636398315; a=rsa-sha256; cv=none; b=hxEJzI+COFNX24VO0TJp3ieLldLxhNOYlumW+/sVfUkEiBP+W0OfohpEldWL+UBYQQinHV irwMXv+U9DGh61jk9uuXfnPKz4e4eLbPfI7fyopzRoaObDzgXMKYF/QzReUcf5mDTg6XCx YWkmWjMjrtO/W8jiczoLhDlgD83JQc4l6lkTObjgAN6SjutKiCnZGNYsQEHRB4dpbrBKKD +YCWQxGQY0eg4qfD5GAWGqz5zf17lEun654D0bBmOPhIGwdDUmGzZTxEf2pfSn4LP0aOpT LSwPfTJQGbWASVr4NIbr39KeeOzPKWbJd30WZ/FaMFCmT3AXGXzGLJ2k79+3gQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=dgK5lBCM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=dgK5lBCM; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1551B28A8F X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: O7/4QPnPuWsY ------YS9O4FDVDMP6HDWL535UWDK16IITY8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I think this is fine=2E The cookbook should recommend using Ctrl-L and sugg= est you can install clear with the ncurses package=2E We get that question = from time to time, so I think it belongs to a FAQ :) Le 8 novembre 2021 12:18:50 GMT-05:00, "pelzflorian (Florian Pelz)" a =C3=A9crit=C2=A0: >Disseminate, thank you for your work=2E > >On Mon, Nov 08, 2021 at 01:48:39PM +0000, Disseminate Dissent wrote: >> Thanks for the comments Florian, >>=20 >> Added periods and removed whitespace=2E >>=20 >> In my initial Guix setup I was unable to clear the terminal with >> neither `clear` nor C-l=2E Installing ncurses solved that issue and is >> listed as a dependency for GNU Readline=2E > >Bash always enables readline as far as I can see=2E Perhaps you used a >system that disabled C-l in the ~/=2Einputrc file, which would also >disable it for a Guix-installed bash? Some Slackware users complain >about non-working C-l on stackoverflow=2E Anyway I will leave this >patch for experienced guix commiters to decide; IMHO the clear command >should not be needed with Guix and the cookbook so far contains only >what can be done with Guix itself=2E Even though I like the idea of a >FAQ section and am happy about new Guix contributors such as you=2E > >As for the patch: > >On Mon, Nov 08, 2021 at 01:50:20PM +0000, Disseminate Dissent via Guix-pa= tches via wrote: >> Corrected missing periods and whitespace=2E >> > >You have not addressed this latter passive Added instead of Add: > >On Mon, Nov 08, 2021 at 10:29:00AM +0100, pelzflorian (Florian Pelz) wrot= e: >> For the commit message, Guix uses the active voice =E2=80=9CAdd a FAQ s= ection >> with =E2=80=A6=E2=80=9D=2E >>=20 >>=20 >> > * doc/guix-cookbook=2Etexi: Added FAQ section=2E >>=20 >> Here too=2E > >Then: > >On Mon, Nov 08, 2021 at 01:50:20PM +0000, Disseminate Dissent via Guix-pa= tches via wrote: >> @menu >> * Scheme tutorials:: Meet your new favorite language! >> -* Packaging:: Packaging tutorials >> -* System Configuration:: Customizing the GNU System >> +* Packaging:: Packaging tutorials=2E >> +* System Configuration:: Customizing the GNU System=2E >> * Advanced package management:: Power to the users! >> -* Environment management:: Control environment >> +* Environment management:: Control environment=2E >> +* FAQ:: Commonly asked questions=2E > >Your commit should only add the period to your sentence; other >sentences should remain untouched (fixing them belongs in a separate >commit)=2E I should fix such things myself in other commits; probably I >won=E2=80=99t do it=2E > >Other than that, it is a nicely written patch=2E > >It seems the issue when running the commands from >`info "(guix)Building from Git"` is that the other menu > >> +@menu >> +* How do I clear my terminal screen? >> +@end menu > >does not contain double colons followed by a sentence like the other >@menu=2E > >Regards, >Florian > > > > ------YS9O4FDVDMP6HDWL535UWDK16IITY8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I think this is fine=2E The cookbook should recomm= end using Ctrl-L and suggest you can install clear with the ncurses package= =2E We get that question from time to time, so I think it belongs to a FAQ = :)

Le 8 novembre 2021 12:18:50 GMT-05:00,= "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian=2Ede> a =C3=A9= crit=C2=A0:
Disseminate, thank you for your work=2E=


On Mon, Nov 08, 2021 at 01:48:39PM +0000, Disseminate Dissent wrote= :
Thanks for the commen= ts Florian,

Added periods and removed whitespace=2E

In my ini= tial Guix setup I was unable to clear the terminal with
neither `clear` = nor C-l=2E Installing ncurses solved that issue and is
listed as a depen= dency for GNU Readline=2E

Bash always enables readline = as far as I can see=2E Perhaps you used a
system that disabled C-l in t= he ~/=2Einputrc file, which would also
disable it for a Guix-installed b= ash? Some Slackware users complain
about non-working C-l on stackoverfl= ow=2E Anyway I will leave this
patch for experienced guix commiters to = decide; IMHO the clear command
should not be needed with Guix and the co= okbook so far contains only
what can be done with Guix itself=2E Even t= hough I like the idea of a
FAQ section and am happy about new Guix contr= ibutors such as you=2E

As for the patch:

On Mon, Nov 08, 2021= at 01:50:20PM +0000, Disseminate Dissent via Guix-patches via wrote:
Corrected missing periods a= nd whitespace=2E


You have not addressed this latter= passive Added instead of Add:

On Mon, Nov 08, 2021 at 10:29:00AM +0= 100, pelzflorian (Florian Pelz) wrote:
For the commit message, Guix uses the active voice =E2=80= =9CAdd a FAQ section
with =E2=80=A6=E2=80=9D=2E


* doc/guix-cookbook=2Etexi: Added FAQ s= ection=2E

Here too=2E

Then:

= On Mon, Nov 08, 2021 at 01:50:20PM +0000, Disseminate Dissent via Guix-patc= hes via wrote:
@menu * Scheme tutorials:: Meet your new favorite language!
-* P= ackaging:: Packaging tutorials
-* System Configuration= :: Customizing the GNU System
+* Packaging:: Pa= ckaging tutorials=2E
+* System Configuration:: Customizing the GN= U System=2E
* Advanced package management:: Power to the users!
-* E= nvironment management:: Control environment
+* Environment manageme= nt:: Control environment=2E
+* FAQ:: Common= ly asked questions=2E

Your commit should only add the p= eriod to your sentence; other
sentences should remain untouched (fixing = them belongs in a separate
commit)=2E I should fix such things myself i= n other commits; probably I
won=E2=80=99t do it=2E

Other than tha= t, it is a nicely written patch=2E

It seems the issue when running t= he commands from
`info "(guix)Building from Git"` is that the other menu=

+@menu
+* How d= o I clear my terminal screen?
+@end menu

does not co= ntain double colons followed by a sentence like the other
@menu=2E
Regards,
Florian




------YS9O4FDVDMP6HDWL535UWDK16IITY8--