From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUcXw-0006aA-Ef for guix-patches@gnu.org; Sat, 25 May 2019 15:41:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUcVS-0006mb-JO for guix-patches@gnu.org; Sat, 25 May 2019 15:39:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36139) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUcVS-0006mR-DL for guix-patches@gnu.org; Sat, 25 May 2019 15:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hUcVS-0000JC-AE for guix-patches@gnu.org; Sat, 25 May 2019 15:39:02 -0400 Subject: [bug#35813] [PATCH] import: crate: add recursive option Resent-Message-ID: Content-Type: multipart/alternative; boundary="Apple-Mail=_7B162412-3D04-490E-9BB7-DA03F01A5421" Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Ivan Petkov In-Reply-To: <87woifuadk.fsf@gnu.org> Date: Sat, 25 May 2019 12:38:08 -0700 Message-Id: References: <20190520182306.11899-1-Karlwfmeakin@gmail.com> <87woifuadk.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 35813@debbugs.gnu.org Cc: Karl Meakin , Karl Meakin --Apple-Mail=_7B162412-3D04-490E-9BB7-DA03F01A5421 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Karl, Thanks for the patch, overall the implementation looks good to me! > On May 24, 2019, at 8:42 AM, Ludovic Court=C3=A8s = wrote: >=20 > would it be possible to augment =E2=80=98tests/crate.scm=E2=80=99 with = tests for > recursive imports? That would be great. I second Ludo=E2=80=99s comment here, having some tests around this = would be great! Also, have you had a chance to test this by importing a Rust = application? I tried to import hexyl (which has a small dependency closure compared = to other applications), but the final result had some missing crate input = definitions (e.g. Maybe a crate depends on rust-foo, but rust-foo wasn't defined in = the output either). Maybe I did something wrong, but it would be good to = confirm! Also, don't worry about actually trying to build any imported packages = as of yet, you might hit a cycle issue between proc-macro2 and quote. I've got = a patch open[0] for fixing the cargo-build-system to handle this! --Ivan [0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35318 = --Apple-Mail=_7B162412-3D04-490E-9BB7-DA03F01A5421 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi = Karl,

Thanks for the = patch, overall the implementation looks good to me!
On May = 24, 2019, at 8:42 AM, Ludovic Court=C3=A8s <ludo@gnu.org> = wrote:

would it be = possible to augment =E2=80=98tests/crate.scm=E2=80=99 with tests for
recursive imports?  That would be great.

I second Ludo=E2=80=99s comment here, having = some tests around this would be great!

Also, have you had a chance to test = this by importing a Rust application?
I tried to = import hexyl (which has a small dependency closure compared to = other
applications), but the final result had some = missing crate input definitions
(e.g. Maybe a crate = depends on rust-foo, but rust-foo wasn't defined in the
output either). Maybe I did something wrong, but it would be = good to confirm!

Also, don't worry about actually trying to build any imported = packages as of
yet, you might hit a cycle issue = between proc-macro2 and quote. I've got a
patch = open[0] for fixing the cargo-build-system to handle this!

--Ivan

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D35318
=

= --Apple-Mail=_7B162412-3D04-490E-9BB7-DA03F01A5421--