From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oGe7DxlgA2OkagEAbAwnHQ (envelope-from ) for ; Mon, 22 Aug 2022 12:53:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YB+tDxlgA2OsFgEA9RJhRA (envelope-from ) for ; Mon, 22 Aug 2022 12:53:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A0A010073 for ; Mon, 22 Aug 2022 12:53:12 +0200 (CEST) Received: from localhost ([::1]:51898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQ53P-0006fq-8X for larch@yhetil.org; Mon, 22 Aug 2022 06:53:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ53H-0006ff-58 for guix-patches@gnu.org; Mon, 22 Aug 2022 06:53:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQ53G-0008EF-Lg for guix-patches@gnu.org; Mon, 22 Aug 2022 06:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQ53G-0005rO-HP for guix-patches@gnu.org; Mon, 22 Aug 2022 06:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Aug 2022 10:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57070 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 57070@debbugs.gnu.org Received: via spool by 57070-submit@debbugs.gnu.org id=B57070.166116554022476 (code B ref 57070); Mon, 22 Aug 2022 10:53:02 +0000 Received: (at 57070) by debbugs.gnu.org; 22 Aug 2022 10:52:20 +0000 Received: from localhost ([127.0.0.1]:38069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ52a-0005qS-DI for submit@debbugs.gnu.org; Mon, 22 Aug 2022 06:52:20 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ52W-0005qD-OR for 57070@debbugs.gnu.org; Mon, 22 Aug 2022 06:52:18 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 40BB05C005E; Mon, 22 Aug 2022 06:52:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 22 Aug 2022 06:52:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1661165531; x=1661251931; bh=tuWtYxUr8x k+/SJNV5aDAdVOqqWA/gERIBOXwvwBzXo=; b=Xzc667qS8o7v2n+Zuz0j9mg8I1 /ZPHDv3Nla/pGXjBz5URcX4fdRrDCjvBxf0PNjeOEsW/vBjD0RNvoFK+iwWovAAh yCu3p+AEb05Ij5BQEF+p5Df6T/+wLBHnMTSbWL8jD+tOeRNGC8ONWSwt5JmjR4GR B1q78manFRlZ2Ed/afIsY8PV3c4cvkb5L7aLghbCG3qcMO9fdB2ShigRtR9SqAlN sB9h1yIl910cYq8k/OokESD/FLaEv/ys9wD9+8Bn0ak5YprLv2I+C/s8qNv4es0U 2RLwVVw3WdUmEV8dd15f7x5hQ+twaI/mEBYLnJRAQTjJb5EDgtOpmZ1aA6Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661165531; x=1661251931; bh=tuWtYxUr8xk+/SJNV5aDAdVOqqWA /gERIBOXwvwBzXo=; b=QM2yt9UEz4L+/o5t4TgI92nwZYGec6kCMWondp9vh769 VGJms5VyU+tyFis/896E9htRTmoM+ZfQZ/TI7ephUTSYlxj/B3tv32vFzCG3RztD CS1Lgw9O5qx6LmmaxNNM3EZavRPHLf0XER8Up5z7NYz895675HBh97ovOh+gLvGC HkhMEu8fLVxaUu9rA4toVdnhKWBFT1ADa7Xy+rAAhIpGkCTO1mNxGSHBhBmTCwko 1cksbg1blYn3ezHnQX46x4lbbjfzRqxrOyeAKpAky9jAUZFsCqpWmUmL1ev5t9HR O4B8pARpiAzg4Ofnb9NW9lCYfCeRorSzC7F4RcyfOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeijedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdtjeenucfhrhhomheprfgrvhgv lhcuufhhlhihrghkuceophdrshhhlhihrghksehprghnthhhvghrgidrohhrgheqnecugg ftrfgrthhtvghrnhepfefhteeugfekudeuffegkeduteejheelgfetuefhvefffeekieeh fedvuedtleeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepphdrshhhlhihrghksehprghnthhhvghrgidrohhrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Aug 2022 06:52:10 -0400 (EDT) From: Pavel Shlyak Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_4ACFBBE1-9629-4E73-9C20-2FB6ABBA5BE7" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Mon, 22 Aug 2022 13:52:08 +0300 In-Reply-To: <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661165593; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=tuWtYxUr8xk+/SJNV5aDAdVOqqWA/gERIBOXwvwBzXo=; b=PHUsVt2QCSI1hFgPB5A8ieS+rmODHgZBr3WsaDe6iKaQpWiXd4TudAkml7iOi84zO2n0Cb /MighRlBivrKNlF685UZ9malxq1HIhdtuKolevfhHE2P5WMipyMnqYgH2AJ2zJpHvw0/2h VmaE8geIFtIstrdmZ95c5+2lhGQsp7ljhhb6tgzIEjPAdr7RMzMIa0Mok8HImmg2A8Vcwc H3EWOzOunA7PwkDat2EXI4aAVZeKJxg6yca/2OwyPTa3+ezTBTh9kI7+HGYyc4V6ds6Kw5 tirVVosn8njhWtFvkMo53tuVKEpkJeWi/hjE80gRKqX//KCaUBgEDYCBHXEsXw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661165593; a=rsa-sha256; cv=none; b=OQfeyEPkh3MCNUPlcOiVNQcJO1/oZbdnJV1f8zmJasswg2bAixK33pbLwd8r6nRzpcIaM+ vf/jl6guMeKRcYSh6iIK+O8OZXKIeSs3wVtVDhhzhvYzJtp7AzDOXFlAFfmKBJrk6GSWhF SHuj1UZ3R6J124eBUOyb67Eo/KkS14fpMaITKUKHVeeFcwaarw4/rkvb8Suhpqq05xfR4I kiM8Ecg0ZWmaRWQpZfkavKtSRv/0t4O7pWQAY344eiuZxs4hD8vIBad77ONfA9liGaUzPD GLKgDKzZTwBdTk4Nocfd+PgTPQDiJZY0aIm6hpEGPqH6vVkmn4x+Ajq856vs7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm2 header.b=Xzc667qS; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=QM2yt9UE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.08 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm2 header.b=Xzc667qS; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=QM2yt9UE; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5A0A010073 X-Spam-Score: 3.08 X-Migadu-Scanner: scn1.migadu.com X-TUID: B7ZWyq3Z6Iiv --Apple-Mail=_4ACFBBE1-9629-4E73-9C20-2FB6ABBA5BE7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > If the user really wants to choose a different DT, they can customise = their kernel by overriding the sourcce. Yes, unless it=E2=80=99s generated by bootloader. > why not submit the bootloader DT to the kernel? Because it passes board-specific parameters. We cannot submit DTs for = all board revisions, memory sizes etc. > Likewise, if they are equivalent, I don't see the point either. They are not > You write that the system definition can both boot with the = kernel-provided FDT and bootloader FDT, then why are you writing this = patch if things work? It can boot on RPI4b, but not on RPI3b+ or Compute Module 4 > The kernel has multiple DTs. I assume that, somehow, the kernel can = figure out which one. DTs are loaded by the bootloader. Kernel cannot figure anything out. > If you must go for this work-around, you could try porting the logic = that the kernel No, kernel does not include this logic > AFAIK, device tree information is used by the kernel, not the = bootloader. Uboot uses DT on some platforms > I don't see the point if updating the DT in the kernel appears to be = sufficient. I hope dynamic DT with some data that only bootloader can know is = sufficient for you. Again, this is how things work on Raspberry and some = other boards on any distro. We don=E2=80=99t support that - we don=E2=80=99= t support these devices. I personally don=E2=80=99t loose much as we can = apply this patch directly on pantherx channel, making pantherx richer in = device support. However, I do not quite like the idea of me answering = =C2=ABInstall PantherX=C2=BB to the people who cannot get GUIX on their = devices. I would be also happy if someone more competent on the topic joined this = discussion.=20 --Apple-Mail=_4ACFBBE1-9629-4E73-9C20-2FB6ABBA5BE7 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 > If the user really wants to choose a different = DT, they can customise their kernel by overriding the = sourcce.
Yes, = unless it=E2=80=99s generated by bootloader.
> why = not submit the bootloader DT to the kernel?
Because it passes board-specific parameters. We cannot = submit DTs for all board revisions, memory sizes etc.
> Likewise, if they are equivalent, I = don't see the point either.
They are not
> You write that the system definition can both = boot with the kernel-provided FDT and bootloader FDT, then why are you = writing this patch if things work?
It can boot on RPI4b, but not on RPI3b+ or = Compute Module 4
> The kernel has multiple DTs. I assume = that, somehow, the kernel can figure out which one.
DTs are loaded by the bootloader. Kernel cannot figure = anything out.
> If = you must go for this work-around, you could try porting the logic that = the kernel
No, kernel does not = include this logic
> AFAIK, device tree information is used by the kernel, not the = bootloader.
Uboot uses DT on some platforms
> I = don't see the point if updating the DT in the kernel appears to be = sufficient.
I hope dynamic DT with some data that only = bootloader can know is sufficient for you. Again, this is how things = work on Raspberry and some other boards on any distro. We don=E2=80=99t = support that - we don=E2=80=99t support these devices. I personally = don=E2=80=99t loose much as we can apply this patch directly on pantherx = channel, making pantherx richer in device support. However, I do not = quite like the idea of me answering =C2=ABInstall PantherX=C2=BB to the = people who cannot get GUIX on their devices.

I would be also happy if someone more = competent on the topic joined this discussion. 

= --Apple-Mail=_4ACFBBE1-9629-4E73-9C20-2FB6ABBA5BE7--