From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UPi2N07kKGI7lAAAgWs5BA (envelope-from ) for ; Wed, 09 Mar 2022 18:30:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eATWL07kKGLS6wAAG6o9tA (envelope-from ) for ; Wed, 09 Mar 2022 18:30:54 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 898E547C0E for ; Wed, 9 Mar 2022 18:30:54 +0100 (CET) Received: from localhost ([::1]:48934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nS09D-0003x0-US for larch@yhetil.org; Wed, 09 Mar 2022 12:30:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nS08R-0003YF-Vs for guix-patches@gnu.org; Wed, 09 Mar 2022 12:30:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38510) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nS08R-0005TS-NJ for guix-patches@gnu.org; Wed, 09 Mar 2022 12:30:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nS08R-0003Kn-Hu for guix-patches@gnu.org; Wed, 09 Mar 2022 12:30:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Cees de Groot Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 09 Mar 2022 17:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 54304@debbugs.gnu.org Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164684697412709 (code B ref 54304); Wed, 09 Mar 2022 17:30:03 +0000 Received: (at 54304) by debbugs.gnu.org; 9 Mar 2022 17:29:34 +0000 Received: from localhost ([127.0.0.1]:60630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS07y-0003Iv-4N for submit@debbugs.gnu.org; Wed, 09 Mar 2022 12:29:34 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:17630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nS07v-0003Id-FD for 54304@debbugs.gnu.org; Wed, 09 Mar 2022 12:29:32 -0500 Date: Wed, 09 Mar 2022 17:29:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=evrl.com; s=protonmail3; t=1646846964; bh=mqS784/iozdStffEOVLuCQPXoRJKBAI8XdhoCr8B47c=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=LjA08RKuImhYOrw1s53FJ7qxuMCUkwwSxwc4RqQ605h9DQqnI16VXhpHUWGn/PL1e Ml9GjzU31RZSzsKnKGnuJmKgCKBkhkmxEyekwWEqZNY6d/VydpXHrMEBBrEfTx6jvC jkwY2vD0LR3NoLslhRVo4Ln9P6cD7Jsj4OM+a5UcKXv25a0chOdz47qqUs2ciPM1qM P0BPOrexp3umyXWcy2Ko8gesU1NKR8C9ldT4qdo0rzSEq+bNStSpYhL8t4dEWSXzCM S5bm9oKlf7rih1grT3B+tmn2xhOvNZKNxdlB6VklKAy4XnwwRQhC2HHTbAl3IFjCeU yeg3nDo4KswMw== From: Cees de Groot Message-ID: In-Reply-To: <090dccee9fc3834656bbe416364a9a337122a2fb.camel@telenet.be> References: <090dccee9fc3834656bbe416364a9a337122a2fb.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Cees de Groot Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646847054; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mqS784/iozdStffEOVLuCQPXoRJKBAI8XdhoCr8B47c=; b=uhSi8d+EOwkrtTkNwXLHi6xbmENiCoSOiHAVMOKTIc2EV7lTc5mywwsQlKZc1x+NuQtrt5 W6TAqvdPTDGiFLQMUxUfSXnL6LilPp7XoOBplkdnqbFLtCfWz4lx6kNeRxrk5m1AvrpVYh BdR5+CmuBtJ3/icB/CqPt7M4tuqUUX8tqgbBUjIWdqWRWNDYUVnvhPZcpUXtRXU/DXi8wH u/crlbBYNUhgXAVPWhL3F+baRn69OEdbkCl0IQjR143A0ghfj5uttIGZ8lt+irXVuNuFhW EtgVYibodlsNZD4f8PVR1sD+FClXAj/jxaqqgFPTGm1rAJ4JuTVLMBQvZsNKpw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646847054; a=rsa-sha256; cv=none; b=aZW7EKfEeMXfKxZTPrTFo0+u3TpaWJ8Omt/vvd7r9coTPptQFgZLls5MR0chglk9DKxtTp yQxl5HdTaEVuPTUfKdMxdX/5PRsh45ymgYTAIUxZWfr/Ll76D2tqk9vZK1upc5HK75HH+6 unplubuNrbJFvpJXej2Dke/pUdmoQIgz4zy5rpPENk5F33s3Fdyw39uyLswy9PHVzdkFJj QmfAmuVssMuPR52F+aDK798wr9n5kEElPrj9ySX8WB92EfL6soxQNxR1Zsduy1l0ha0aVJ BZEGosoUmypsPDSR3rDTy5EMKBW1wuaFgsfc+BifI2zLmiKMm1lUSAdsrDCgmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=evrl.com header.s=protonmail3 header.b=LjA08RKu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=evrl.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.99 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=evrl.com header.s=protonmail3 header.b=LjA08RKu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=evrl.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 898E547C0E X-Spam-Score: 4.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: d5DRWiknGWX+ >From the docs: ":revision - short Git revision hash. If Git was not available at building = time, it is set to """ (https://hexdocs.pm/elixir/System.html#build_info/0) So if git is not available - either because the executable is not there or = because the build checkout is not from Git, the revision hash is set to the= empty string, which is in accordance with the docs and what the Guix build= has been doing all along (because, as you said, at build time, .git isn't = there). So for build time, cross-compiling or not, we don't need Git. ------- Original Message ------- On Wednesday, March 9th, 2022 at 02:31, Maxime Devos wrote: > Cees de Groot schreef op wo 09-03-2022 om 02:39 [+0000]: > > > > [...] > > > > > > That cannot ever have worked in the first place, since Guix > > > > > > does not save the '.git' directory when downloading elixir's source > > > > > > code. > > > That=E2=80=99s correct and fine. The info is informational at most > > How can being completely broken be correct and fine? > > Greetings, > > Maxime.