From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id Yo/QKopH5WJcHQAAbAwnHQ (envelope-from ) for ; Sat, 30 Jul 2022 17:00:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gIHkKIpH5WIoCwAAG6o9tA (envelope-from ) for ; Sat, 30 Jul 2022 17:00:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 369E12C7C5 for ; Sat, 30 Jul 2022 17:00:26 +0200 (CEST) Received: from localhost ([::1]:52310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHnx2-0004B8-LR for larch@yhetil.org; Sat, 30 Jul 2022 11:00:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHnwg-0004Aw-LI for guix-patches@gnu.org; Sat, 30 Jul 2022 11:00:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oHnwg-00007A-Ad for guix-patches@gnu.org; Sat, 30 Jul 2022 11:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oHnwg-0000Lw-6B for guix-patches@gnu.org; Sat, 30 Jul 2022 11:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56840] [PATCH] FeatherPad package Resent-From: Pavel Shlyak Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 Jul 2022 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56840 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56840@debbugs.gnu.org Received: via spool by 56840-submit@debbugs.gnu.org id=B56840.16591931551252 (code B ref 56840); Sat, 30 Jul 2022 15:00:02 +0000 Received: (at 56840) by debbugs.gnu.org; 30 Jul 2022 14:59:15 +0000 Received: from localhost ([127.0.0.1]:35585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHnvv-0000K8-5Y for submit@debbugs.gnu.org; Sat, 30 Jul 2022 10:59:15 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oHnvr-0000Jp-6w for 56840@debbugs.gnu.org; Sat, 30 Jul 2022 10:59:14 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E3A8D5C00BA for <56840@debbugs.gnu.org>; Sat, 30 Jul 2022 10:59:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 30 Jul 2022 10:59:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1659193145; x=1659279545; bh=Y2sohmj198 VASLIv+kuS+tjLSKSPt40Np6A7QM5unHA=; b=MmTSGv/hCIJ4uVYl5AnYeu4a8v 3LNUpBy+xHANGF0xIN8rPI0ahah0cZ3RRL3kjDRcem8acMQ/NpWSSA5eD2WESifz 0in8ziDQU5hLGAqQNtxL/inIH6tAxdOh9ubkpSIMgfO7ytpCoG789JG/sTlBHjhm bJe8CmsUc6mkQBCopOE3VppXUBC3/cvNtxhwB93RGO2ZZNsRAXdc+rB6+wRS/yUH rstzuKijsHy1BloalBmQPST4tzA3xHRTrUcpUvFxahpu1fwkSL64EHdIz1a83roI ooPBRRRWr7ZfUKgYkOc/ilnn69TK8c4zO7uzO4ydryY0+bKX2LWefH2moLSw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1659193145; x=1659279545; bh=Y2sohmj198VASLIv+kuS+tjLSKSP t40Np6A7QM5unHA=; b=ysPOgm1Ch4XoqT7QdN02w45gTdo4EoS0lD67CLnXx2k/ tYutgat1IE2ucGS4EWueGHUiz3aqE3hjGG0M/M5bSOyi+tu+kxgpwknRR1EsVSXU +FTeeLr3XNfiGlE2a7wGE+E18z+uwIhUTtXuVNJizAnt9Hpcs7Zmf3NIef4B0qZo yYbsex+Tbsi3fIGvE67JFDKr7AItMA0D9h/ti3VyNDUchFLPMD5AUAzFXrMbr7Fc rE9tV8CwGkig7qrfFXCw9rvum3B38D5rldJix+GbszocybPqldVbH6phybNTiuWX 7LN9GMOcOtWwTUTha/1H2gG9D951TIB2rBvr+P96Dw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdduledgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtggguffffhfvjgfkofesmhdtmh erhhdtvdenucfhrhhomheprfgrvhgvlhcuufhhlhihrghkuceophdrshhhlhihrghksehp rghnthhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhephfdtheeguedvkefglefhhf fghfdtteetgfejieevkefhgefgkeeludehgfeuvdeinecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghnthhhvghrgi drohhrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <56840@debbugs.gnu.org>; Sat, 30 Jul 2022 10:59:05 -0400 (EDT) From: Pavel Shlyak Content-Type: multipart/mixed; boundary="Apple-Mail=_8DE6A8E7-4431-4A01-BAED-AD5C981666B1" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Date: Sat, 30 Jul 2022 17:59:00 +0300 References: <302e84b7-b42b-ecc7-072e-d05b92d1b7ef@telenet.be> In-Reply-To: <302e84b7-b42b-ecc7-072e-d05b92d1b7ef@telenet.be> Message-Id: X-Mailer: Apple Mail (2.3696.100.31) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659193226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Y2sohmj198VASLIv+kuS+tjLSKSPt40Np6A7QM5unHA=; b=WbSdqTrmMladmF0okC/s8oAO9j7pCLe1Ft0aZBZUD95cnnxFaaWZ/0DirmW2aTWVUeId86 Nz8jIgJAZ4hs82jti5gtIiCpCjd46nK80X4gr4HQ/b/nFfleKN0tQrhcNnaRtEC6lD2YYk Ki8lCIzQRl4+OG8ZJzp1slkC3Y6sWTtiHoTg+O5fdCSWngJtanFku1pnuN+JpuWO2hiLqk LPlZELVqhr0yXjkspB/MDDUkgv2LuU5Ivz4tYyBIMfOcWE7O7wAMZiA9ioGLPC3XrraDdW LFb+RamQ085x4J24F5J04mLfyhabwFXY3MkwU1MlunkQyNa2u61Oj0Y6Mb+Lhw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659193226; a=rsa-sha256; cv=none; b=E8Or3xgIpIuoxG2KGLaPqaVcdzm0N6PmKskQzmnpc6eZr+FTBc8xv3d9oRuvjZ/AY4T/US DWuhGR5YLFWbmuGqBvUgOFsEE0aV3SZYdoWvpNANc01gQ0B4zw1wzLj0l4AH67/yu9S72Z m/GecsW9FtjvtuwuMvcarFpESIhy0WEQ5OfoSJqqgSFUdseEWu4IPhhkVkBQ/iyrrOJbhw gzBYnExi/Gn1oyOI+taA7ymDWNW9jX4lFTHW7PeUbLqXrFnnySgAB9GLGvLGe3xaLj+vIU xfgamaTef85KoqtRmxWo19KRqxa/c6YBKSzrZGAJH9h7eee3bwaqzAYoYeCSsQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm1 header.b="MmTSGv/h"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=ysPOgm1C; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.67 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pantherx.org header.s=fm1 header.b="MmTSGv/h"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=ysPOgm1C; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 369E12C7C5 X-Spam-Score: 1.67 X-Migadu-Scanner: scn0.migadu.com X-TUID: b5OuRevmAb73 --Apple-Mail=_8DE6A8E7-4431-4A01-BAED-AD5C981666B1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Thank you for your feedback! I have tried to fix the issues you = mentioned and I also added translations. I have edited the package = description in accordance with your recommendations and I kindly asked = app author/maintainer to appear in this thread to comment it. --Apple-Mail=_8DE6A8E7-4431-4A01-BAED-AD5C981666B1 Content-Disposition: attachment; filename=0001-gnu-featherpad-new-package.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-gnu-featherpad-new-package.patch" Content-Transfer-Encoding: quoted-printable =46rom=206f2038d57b543e9fb1df22dcc75e778f3742660c=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Pavel=20Shlyak=20=0A= Date:=20Sat,=2030=20Jul=202022=2013:57:30=20+0300=0ASubject:=20[PATCH]=20= gnu:=20featherpad:=20new=20package.=0A=0A=20=20=20=20*=20= gnu/packages/text-editors.scm=20(featherpad):=20new=20package.=0A---=0A=20= gnu/packages/text-editors.scm=20|=2029=20+++++++++++++++++++++++++++++=0A= =201=20file=20changed,=2029=20insertions(+)=0A=0Adiff=20--git=20= a/gnu/packages/text-editors.scm=20b/gnu/packages/text-editors.scm=0A= index=200c8531cc4d..50ab492c0b=20100644=0A---=20= a/gnu/packages/text-editors.scm=0A+++=20b/gnu/packages/text-editors.scm=0A= @@=20-19,6=20+19,9=20@@=0A=20;;;=20Copyright=20=C2=A9=202021=20Calum=20= Irwin=20=0A=20;;;=20Copyright=20=C2=A9=202022=20= Luis=20Henrique=20Gomes=20Higino=20=0A=20= ;;;=20Copyright=20=C2=A9=202022=20Foo=20Chuan=20Wei=20= =0A+;;;=20Copyright=20=C2=A9=202018=20Fakhri=20= Sajadi=20=0A+;;;=20Copyright=20=C2=A9=202021=20= Reza=20Alizadeh=20Majd=20=0A+;;;=20Copyright=20=C2=A9= =202022=20Pavel=20Shlyak=20=0A=20;;;=0A=20;;;=20= This=20file=20is=20part=20of=20GNU=20Guix.=0A=20;;;=0A@@=20-849,6=20= +852,32=20@@=20(define-public=20editorconfig-core-c=0A=20editors.")=0A=20= =20=20=20=20(license=20license:bsd-2)))=0A=20=0A+(define-public=20= featherpad=0A+=20=20(package=0A+=20=20=20=20(name=20"featherpad")=0A+=20=20= =20=20(version=20"1.3.0")=0A+=20=20=20=20(home-page=20= "https://github.com/tsujan/FeatherPad")=0A+=20=20=20=20(source=20(origin=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20(method=20git-fetch)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(uri=20(git-reference=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(url=20home-page)=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(commit=20= (string-append=20"V"=20version))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(file-name=20(git-file-name=20name=20version))=0A+=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(sha256=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20(base32=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= "1knxf05lfvpfkj4lxi71kidg2f7nfkgsidb45m86h9mnbqmxzjcg"))))=0A+=20=20=20=20= (build-system=20cmake-build-system)=0A+=20=20=20=20(arguments=20(list=20= #:tests?=20#f))=20=20=20=20=20=20=20=20=20=20=20;no=20upstream=20tests=0A= +=20=20=20=20(native-inputs=20(list=20pkg-config=20qttools))=20=20=20=20=20= =20=20=20=20=20=20;=20for=20lrelease=0A+=20=20=20=20(inputs=20(list=20= hunspell=20qtsvg=20qtx11extras=20qtbase-5))=0A+=20=20=20=20(synopsis=20= "GUI=20Plain-text=20editor")=0A+=20=20=20=20(description=20"FeatherPad=20= is=20a=20GUI=20plain-text=20editor.=0A+It=20is=20independent=20of=20any=20= desktop=20environment=20and=20has=0A+syntax=20highlighting,=20session=20= management,=20side-pane=20mode,=20auto-saving,=0A+spell=20checking,=20= drag=20and=20drop=20support,=20instant=20highlighting=0A+and=20automatic=20= detection=20of=20text=20encoding..")=0A+=20=20=20=20(license=20= license:gpl3+)))=0A+=0A=20(define-public=20texmacs=0A=20=20=20(package=0A= =20=20=20=20=20(name=20"texmacs")=0A--=20=0A2.32.1=20(Apple=20Git-133)=0A= =0A= --Apple-Mail=_8DE6A8E7-4431-4A01-BAED-AD5C981666B1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > 30 =D0=B8=D1=8E=D0=BB=D1=8F 2022 =D0=B3., =D0=B2 16:00, Maxime Devos = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ): >=20 >=20 > On 30-07-2022 14:31, Pavel Shlyak wrote: >> Hello! >>=20 >> Here is my patch to add FeatherPad package to guix. I upstream it = from PantherX channel, hence 3 copyright lines. >> I build it against Qt5 as Qt6 support in FeatherPad is experimental = and is not recommended for daily usage yet. >>=20 >> Thank you in advance for your feedback. >> Have a nice day! >>=20 >> + (synopsis "Lightweight Qt5 plain-text editor for Linux") >> + (description "FeatherPad is a lightweight Qt5 plain-text editor = for Linux") >=20 > If it's only for Linux, that needs to be mentioned in the = 'supported-systems'; there is no need to duplicate this information in = the description and synopsis. Also, according to the README, this is = incorrect -- e.g., it mentions 'Haiku OS' support; maybe it supports the = Hurd too. There is also no need to mention implementation details such = as Qt5 -- if the user is interested in that, they can do "guix show = featherpad" to see the list of dependencies. >=20 > Additionally, descriptions are not the same thing as descriptions, yet = you are writing essentially the same thing in both, try mentioning what = FeatherPad can do and its limitations (especially if they are = limitations compared to other text editors or features not implemented = by them, to help the user deciding between them). Marketing talk like = "lightweight" (*) is to be avoided, see (guix)Synopses and Descriptions. >=20 > (*) It's super subjective. Is "lightweight" considering memory usage, = disk usage, CPU usage, ...? I've tested this statement (with disk usage) = for "nano" and the inputs of FeatherPad, and I find that nano takes 86.7 = MiB in total and FeatherPad's dependencies take 1156.5 MiB in total -- = 13.3 times larger! So in a certain sense, it's not lightweight at all, = but heavyweight. If you really want to mention it's lightweight, then be = precise in your exact claim. >=20 > > + (native-inputs (list pkg-config hunspell qtsvg qtx11extras = qtbase-5)) >=20 > Only pkg-config looks like a native-input to me. See (guix)package = Reference for the difference. >=20 >> + (arguments `(#:tests? #f)) >=20 > Tests exist for a reason, don't simply disable them -- if there is a = reason, write down the reason, in a comment. Also, there appears to be = some preference for (list #:tests? #false) -- ` / , is a complicated = construct, and if used, you can get things like ,#~. >=20 >> + (license license:gpl3))) >=20 > Looking at a random source file (featherpad/fpwin.cpp), this appears = to be incorrect -- GPL-3.0 and GPL-3.0+ are different. >=20 >> = https://github.com/tsujan/FeatherPad/blob/master/cmake/Modules/FindHUNSPEL= L.cmake=20 >=20 > Greetings, > Maxime. >=20 > --Apple-Mail=_8DE6A8E7-4431-4A01-BAED-AD5C981666B1--