From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:41558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gw0CE-0007Jv-GZ for guix-patches@gnu.org; Tue, 19 Feb 2019 02:52:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gw0CB-0000BL-26 for guix-patches@gnu.org; Tue, 19 Feb 2019 02:52:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54510) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gw0CA-0000BE-IA for guix-patches@gnu.org; Tue, 19 Feb 2019 02:52:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gw0CA-0007sl-CK for guix-patches@gnu.org; Tue, 19 Feb 2019 02:52:02 -0500 Subject: [bug#34523] Add tetrinet References: Resent-Message-ID: MIME-Version: 1.0 From: Date: Tue, 19 Feb 2019 07:51:30 +0000 (GMT) In-Reply-To: <87va1hyyna.fsf@nckx> Content-Type: multipart/mixed; boundary="----------=_1550562690-21040-19" Message-Id: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 34523 <34523@debbugs.gnu.org> This is a multi-part message in MIME format... ------------=_1550562690-21040-19 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I've attached an updated patch with the modifications suggested so far: - Changed license from expat to public-domain - Changed "No tests" to lowercase "no tests" - Added "no configure file" comment - Install Readme files I indent the package definition in emacs by marking the package definition = (CTRL+Space) and running `M-x indent-region`, I'm not sure what indentation= was wrong with the original patch I submitted, but I ran indent-region on = it again anyway. On Mon, 18 Feb 2019 15:11:37 +0100, Tobias Geerinckx-Rice wr= ote: > pkill -9, Ricardo, >=20 > Ricardo Wurmus wrote: > > pkill9@runbox.com writes: > >> + `(#:tests? #f ; No tests. >=20 > Only nitpicks: >=20 > + `(#:tests? #f ; no tests >=20 > If you're using emacs, running C-M-q on the whole definition will=20 > automatically indent your code. There's a way to do the same=20 > without emacs, but I forget how. >=20 > >> + #:phases (modify-phases %standard-phases > >> + (delete 'configure) >=20 > + (delete 'configure) ; no configure script >=20 > >> + (add-after 'unpack 'fix-install-dir > >> + (lambda* (#:key outputs=20 > >> #:allow-other-keys) > >> + (let ((out (assoc-ref outputs "out"))) > >> + (mkdir-p (string-append out "/bin")) > >> + (substitute* "Makefile" > >> + (("/usr/games") (string-append out=20 > >> "/bin"))))))))) > > > > Can this patching be avoided by passing a make flag instead? >=20 > Nope, it's hard-coded in the Makefile target :-( >=20 > Considering the lack of a man(ual) page, how about adding=20 > something like: >=20 > (add-after 'install 'install-documentation > (lambda* (#:key outputs #:allow-other-keys) > (let* ((out (assoc-ref outputs "out")) > (doc (string-append out "/share/doc/" > ,name "-" ,version))) > (for-each (lambda (file) > (install-file file doc)) > (list "README" "tetrinet.txt")) > #t)))))) >=20 > Thanks! >=20 > T G-R ------------=_1550562690-21040-19 Content-Type: text/x-patch; name="=?UTF-8?Q?0001-gnu-Add-tetrinet.patch?=" Content-Disposition: attachment; filename="=?UTF-8?Q?0001-gnu-Add-tetrinet.patch?=" Content-Transfer-Encoding: base64 Content-ID: <28e799f0ff4450110fb012febeb85895> RnJvbSBiODJiZTgxNmVkOTJhZmQzOTg4ZmZkZWUxMjA2ZWRmZTlhMTk2MTZh IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQa2lsbCAtOSA8cGtp bGw5QHJ1bmJveC5jb20+CkRhdGU6IFR1ZSwgMTkgRmViIDIwMTkgMDc6NDY6 MjkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBnbnU6IEFkZCB0ZXRyaW5ldC4K CiogZ251L3BhY2thZ2VzL2dhbWVzLnNjbSAodGV0cmluZXQpOiBOZXcgdmFy aWFibGUuCi0tLQogZ251L3BhY2thZ2VzL2dhbWVzLnNjbSB8IDQyICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxl IGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUv cGFja2FnZXMvZ2FtZXMuc2NtIGIvZ251L3BhY2thZ2VzL2dhbWVzLnNjbQpp bmRleCBmODJhZjBlOGMuLmU2ZjdmN2I3OSAxMDA2NDQKLS0tIGEvZ251L3Bh Y2thZ2VzL2dhbWVzLnNjbQorKysgYi9nbnUvcGFja2FnZXMvZ2FtZXMuc2Nt CkBAIC0zNiw2ICszNiw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggTWFk YWxpbiBJb25lbC1QYXRyYXNjdSA8bWFkYWxpbmlvbmVsLnBhdHJhc2N1QG1k Yy1iZXJsaW4uZGU+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggQmVuamFtaW4g U2xhZGUgPHNsYWRlQGpuYW5hbS5uZXQ+CiA7OzsgQ29weXJpZ2h0IMKpIDIw MTggQWxleCBWb25nIDxhbGV4dm9uZzE5OTVAZ21haWwuY29tPgorOzs7IENv cHlyaWdodCDCqSAyMDE5IFBraWxsIC05IDxwa2lsbDlAcnVuYm94LmNvbT4K IDs7OwogOzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4LgogOzs7 CkBAIC02MTAyLDMgKzYxMDMsNDQgQEAgdG8gZG93bmxvYWQgYW5kIGluc3Rh bGwgdGhlbSBpbiBAZmlsZXskSE9NRS8uc3RlcG1hbmlhLVguWS9Tb25nc30g ZGlyZWN0b3J5LiIpCiAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly93d3cuc3Rl cG1hbmlhLmNvbSIpCiAgICAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdCkpKQog CisoZGVmaW5lLXB1YmxpYyB0ZXRyaW5ldAorICAocGFja2FnZQorICAgIChu YW1lICJ0ZXRyaW5ldCIpCisgICAgKHZlcnNpb24gIjAuMTEiKQorICAgIChz b3VyY2UKKyAgICAgKG9yaWdpbgorICAgICAgIChtZXRob2QgdXJsLWZldGNo KQorICAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQKKyAgICAgICAgICAgICAi aHR0cDovL3RldHJpbmV0Lm9yLmN6L2Rvd25sb2FkL3RldHJpbmV0LSIKKyAg ICAgICAgICAgICB2ZXJzaW9uCisgICAgICAgICAgICAgIi50YXIuYnoyIikp CisgICAgICAgKHNoYTI1NgorICAgICAgICAoYmFzZTMyCisgICAgICAgICAi MGI0cGRkcXo2aXMxNzcxcW12Y2o4cXFscjRpbjJkamRia2sxM2FndnA5eWhm YWgydjh4NyIpKSkpCisgICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lz dGVtKQorICAgIChpbnB1dHMKKyAgICAgYCgoIm5jdXJzZXMiICxuY3Vyc2Vz KSkpCisgICAgKGFyZ3VtZW50cworICAgICBgKCM6dGVzdHM/ICNmIDsgbm8g dGVzdHMuCisgICAgICAgIzptYWtlLWZsYWdzICcoIkNDPWdjYyIpCisgICAg ICAgIzpwaGFzZXMgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcwor ICAgICAgICAgICAgICAgICAgKGRlbGV0ZSAnY29uZmlndXJlKSA7IG5vIGNv bmZpZ3VyZSBzY3JpcHQuCisgICAgICAgICAgICAgICAgICAoYWRkLWFmdGVy ICd1bnBhY2sgJ2ZpeC1pbnN0YWxsLWRpcgorICAgICAgICAgICAgICAgICAg ICAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyAjOmFsbG93LW90aGVyLWtleXMp CisgICAgICAgICAgICAgICAgICAgICAgKGxldCAoKG91dCAoYXNzb2MtcmVm IG91dHB1dHMgIm91dCIpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICht a2Rpci1wIChzdHJpbmctYXBwZW5kIG91dCAiL2JpbiIpKQorICAgICAgICAg ICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJNYWtlZmlsZSIKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgKCgiL3Vzci9nYW1lcyIpIChzdHJpbmct YXBwZW5kIG91dCAiL2JpbiIpKSkpKSkKKyAgICAgICAgICAgICAgICAgIChh ZGQtYWZ0ZXIgJ2luc3RhbGwgJ2luc3RhbGwtZG9jdW1lbnRhdGlvbgorICAg ICAgICAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyAjOmFs bG93LW90aGVyLWtleXMpCisgICAgICAgICAgICAgICAgICAgICAgKGxldCog KChvdXQgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKGRvYyAoc3RyaW5nLWFwcGVuZCBvdXQgIi9z aGFyZS9kb2MvIiAsbmFtZSAiLSIgLHZlcnNpb24pKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgIChmb3ItZWFjaCAobGFtYmRhIChmaWxlKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGluc3RhbGwtZmlsZSBm aWxlIGRvYykpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGxpc3QgIlJFQURNRSIgInRldHJpbmV0LnR4dCIpKQorICAgICAgICAgICAg ICAgICAgICAgICAgI3QpKSkpKSkKKyAgICAoaG9tZS1wYWdlICJodHRwOi8v dGV0cmluZXQub3IuY3oiKQorICAgIChzeW5vcHNpcyAiTXVsdGlwbGF5ZXIg dGV0cmlzIikKKyAgICAoZGVzY3JpcHRpb24gIlRldHJpbmV0IGlzIGEgbXVs dGlwbGF5ZXIgdGV0cmlzIGdhbWUgd2l0aCBwb3dlcnVwcyBhbmQKK2F0dGFj a3MgeW91IGNhbiB1c2Ugb24gb3Bwb25lbnRzLiIpCisgICAgKGxpY2Vuc2Ug bGljZW5zZTpwdWJsaWMtZG9tYWluKSkpCi0tIAoyLjIwLjEKCg== ------------=_1550562690-21040-19--