bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'

bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'

[pkill9]

For example, if you specify 'glib:bin' as an input, it will add only 'glib' as an input. (It's not recognising a specified output of a package recipe that produces multiple outputs.)

bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'

[Lulu]

I just checked this and failed to replicate it. It happily generates config from
`glib:doc', `glib:bin' and `glib:out' in input fields and complains if there's a
nonexistent `glib:foo' input, as of v1.1.0.

--
Lulu

bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'

[zimoun]

Hi Lulu,

Thank you for working of this.

On Wed, 14 Oct 2020 at 09:12, Lulu <me@erkin.party> wrote:

> I just checked this and failed to replicate it. It happily generates
> config from `glib:doc', `glib:bin' and `glib:out' in input fields and
> complains if there's a nonexistent `glib:foo' input, as of v1.1.0.

Could you provide the commit (hash) of the Guix you are using?
Personally, I do “guix describe” and paste then the short hash
(58af4c9).  Then it is easier to reproduce or replicate or see if it is
fixed in which version.

Then, could you provide the sequence of commands you used for
“replication“?  And the file example you used too.  It eases the process
for confirming or not. :-)


Thanks,
simon

bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'

[Lulu]

The version hash of Guix I tried this on was `26f6bd0403ed20c1d26eca9d4f28a0da519a56ac'.

I used the example JSON file for the `hello' package provided in
"(guix)Invoking guix import". Then, based on the given example of glib, I tried
running `guix import json' with `glib', `glib:bin', `glib:doc', `glib:out'
separately appended to the `native-inputs' array of `hello.json', in order. It
produced an appropriate SXML structure in the `native-inputs` field each time:
("glib" (@ (gnu packages glib) glib-with-documentation))
for standalone `glib' and
("glib" (@ (gnu packages glib) glib-with-documentation) "bin")
for the rest, which appears to fit the package definition syntax.

When I tried with `glib:foo', where `foo' is an erroneous output, it yielded the
following error:
guix import: error: package `glib@2.62.6' lacks output `foo'.

So, it seems like this bug was fixed somewhere along the line.

--
Lulu

bug#31302: `guix import json` doesn't handle inputs with the form 'package:output'

[zimoun]

Dear,

On Sun, 25 Oct 2020 at 20:12, Lulu <me@erkin.party> wrote:

> So, it seems like this bug was fixed somewhere along the line.

Yep, the bug is fixed.  Probably by these:

7cef499bb0 * import/json: json->code: Handle files with more than one definition.
c893432320 * import/json: Use json->code.
16dd764691 * import/json: Add json->scheme-file.


You can close the bug by sending to <31302-done@debbugs.gnu.org> with
the explanations.


Thanks,
simon