From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0NJQL/8KeWKNXgAAbAwnHQ (envelope-from ) for ; Mon, 09 May 2022 14:37:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OF1FL/8KeWJLggAAauVa8A (envelope-from ) for ; Mon, 09 May 2022 14:37:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D59329BF for ; Mon, 9 May 2022 14:37:19 +0200 (CEST) Received: from localhost ([::1]:40648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no2da-0002Xz-EQ for larch@yhetil.org; Mon, 09 May 2022 08:37:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no2bP-0000A4-01 for guix-patches@gnu.org; Mon, 09 May 2022 08:35:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no2bO-00074H-KD for guix-patches@gnu.org; Mon, 09 May 2022 08:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no2bO-0006dH-Dq for guix-patches@gnu.org; Mon, 09 May 2022 08:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55242] [PATCH 07/10] guix: import: go: More resilience wrt network errors; add logging. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 May 2022 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55242 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 55242@debbugs.gnu.org Received: via spool by 55242-submit@debbugs.gnu.org id=B55242.165209970025483 (code B ref 55242); Mon, 09 May 2022 12:35:02 +0000 Received: (at 55242) by debbugs.gnu.org; 9 May 2022 12:35:00 +0000 Received: from localhost ([127.0.0.1]:56518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no2bL-0006cw-KT for submit@debbugs.gnu.org; Mon, 09 May 2022 08:34:59 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:11182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no2bH-0006cb-HA for 55242@debbugs.gnu.org; Mon, 09 May 2022 08:34:58 -0400 Date: Mon, 09 May 2022 12:34:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail3; t=1652099688; bh=mF77ltF8aAY/Nq0AWex7zVcflnZUq6/2q7Qv2oyCgFA=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=B0SERIXo38YFH5Tuj1GwE0eMOs/2L84mb80NFg8IVSX7f0HWaPJbcJup8IBbcq4uG U9hh4HoMXx1Fqbh556difwacatHxTkYtKgLfMkqRgtgO2/vP5n5cSK1ijuvNLjUWAk 4sFCSqtv0T4f3j6/pymTJ88VnfNRr5GBvIHmTPdTMGpgJFtRGHmnDIHT6jDvYVvjRg HOCEuZ2YfJy2H4gNegjWDFjPww4GQ5V+MYTbExY2iMIJPDfwK3E/LWrRm/MTrO/19E NWs8YWNYu/0QbEXLolm/gearO1kEV1t7jeMCy5vVbtYof2TCU16oVNJwStIlx7RU89 To9trgHb+I4Dw== From: Attila Lendvai Message-ID: In-Reply-To: <76510182d505978ad41f5bff88bf7eee7c289558.camel@telenet.be> References: <20220503114301.9524-2-attila@lendvai.name> <20220503114301.9524-7-attila@lendvai.name> <7974a00256e3ee153507f77d6b0a405473e9bbc4.camel@telenet.be> <76510182d505978ad41f5bff88bf7eee7c289558.camel@telenet.be> Feedback-ID: 28384833:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652099839; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mF77ltF8aAY/Nq0AWex7zVcflnZUq6/2q7Qv2oyCgFA=; b=aekj9uZvPBN1a7AP0B9gLJkX9kGwKc6bl9kKxIto8yjC+V+rXlDFwb5BSejm4XA8UR/tKs yb2LtHDTk0xslZThAR/psBx5ayySNhcVJr8mNW8wTG0Xvq+6VlxAiR4ZIKkO0Tu67xJKRc Q4BCP5RTwHtD/hCMvGEuzpTh4SQlvBPF1J/U70hTrrnyexMotwYuc+RjbFaQE+3Di5wWV6 oQqGrstMlIZ2UGYpeVyuAuLabb0IghAieg+FIA/rX9r1ytXLbMOmVSDdxbdO64BW3nJuLj QN5EhfwyIDqU7yASfpfWqUtQ/lxmqKZrmIvMN8gYEh5uz623CkABUC5KYMIBhQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652099839; a=rsa-sha256; cv=none; b=ecFpyx5M9xCGOeDwX9o3rRSHzB8ig3L9Kz4W7IwsLbAyXVL7ryfeJwu0OebDMGfo+1+E1l IRe04ADBa/SkjGx/y64sMMFMDBNoMrgbs6PJ5YcmSwtMOjztLRXBCRb6OjF9IBqt3HTBGo FIGTUqwdmex5mtyhqPiyKw9BMdWTLE4th7isnTXSdB+uufLKqRIBhB0fiui7k97t7FaUPh MlIguSLCa8lWHgSt7fVSpiyREXvD91v10b8XiXT8EoWK/VXwdf843YklJAE/+XE8pUALSw +zl01Rf3A/0gE2loJ/7AS57lGoTzkjqDg2TdbUrShDzipgBiwhR28xp3QG5cag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail3 header.b=B0SERIXo; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.20 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lendvai.name header.s=protonmail3 header.b=B0SERIXo; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4D59329BF X-Spam-Score: 0.20 X-Migadu-Scanner: scn0.migadu.com X-TUID: j8q3ALuzFq9w > ... but if there's some kind of bug,=C2=A0why not just report and fix it? realistically? because there are years old issues, and long bitrotten patches in every project's issue tracker, Guix included. i think an importer, that does proper logging, and finishes with a 99% correct result, is worth much more than one that barks at the first error, and then refuses to continue processing the 100+ remaining entries. this was true even in my own case, when i also had the maintainer hat on, i.e. i was already neck deep into fixing the importer. > > and the user gets 99% of the packages imported, and has to do only > > one package by hand. > > > If the bug is fixed, then no packages need to be done by hand and other > people will benefit as well. Whereas if it's only for 1% and the > backtrace only happens for recursive import and not for non-recursive > or manual import, then I'd think that the chance that the user actually > reports or fixes the bug decreases a lot. the tradeoff is this: what leads to a lower level of overall annoyance of a= ll the parties involved: 1) have a tool that is less useful, and through that it annoys the users to report issues, which then (hopefully) thrusts some people towards improving the tool... or 2) have a tool that does its best to produce the most useful output. short of hard data, this can be argued forever. my intuition is clearly poi= nting towards 2), because i doubt that the choking point of improving the i= mporter is due to not having enough examples on which it breaks. does it make enough sense to justify my proposed behavior? -- =E2=80=A2 attila lendvai =E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39 -- =E2=80=9CCommunism doesn=E2=80=99t work because people like to own stuff.= =E2=80=9D =09=E2=80=94 Frank Zappa (1940=E2=80=931993)