From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wGrPLcupXWINVQAAbAwnHQ (envelope-from ) for ; Mon, 18 Apr 2022 20:11:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gJ7WLcupXWL3oQAAauVa8A (envelope-from ) for ; Mon, 18 Apr 2022 20:11:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 425BA40FF for ; Mon, 18 Apr 2022 20:11:23 +0200 (CEST) Received: from localhost ([::1]:50878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngVqM-0000tY-BP for larch@yhetil.org; Mon, 18 Apr 2022 14:11:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngVq8-0000rr-PN for guix-patches@gnu.org; Mon, 18 Apr 2022 14:11:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngVq1-0002re-Mt for guix-patches@gnu.org; Mon, 18 Apr 2022 14:11:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ngVq1-0006IU-Hx for guix-patches@gnu.org; Mon, 18 Apr 2022 14:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54974] [PATCH] added btop References: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> In-Reply-To: <3D9386AF-4BB9-4C79-B170-A6A2AEC13728@4tii.de> Resent-From: Wil deBeest Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 Apr 2022 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54974 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Greg Hogan Cc: 54974@debbugs.gnu.org Received: via spool by 54974-submit@debbugs.gnu.org id=B54974.165030543424034 (code B ref 54974); Mon, 18 Apr 2022 18:11:01 +0000 Received: (at 54974) by debbugs.gnu.org; 18 Apr 2022 18:10:34 +0000 Received: from localhost ([127.0.0.1]:40681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngVpZ-0006Fa-JO for submit@debbugs.gnu.org; Mon, 18 Apr 2022 14:10:33 -0400 Received: from mail.4tii.de ([178.254.9.173]:47490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngViD-00062P-JJ for 54974@debbugs.gnu.org; Mon, 18 Apr 2022 14:02:58 -0400 Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=4tii.de; s=mail; t=1650304970; bh=7hXJMI1qbYdodmv1kdxT2tHPR1rNwdxtBzJPccX4hxk=; h=From:Subject:Date:Cc:To; b=vxLrHYmmOBfj+EMDo5inzURIFSN2bm6ENdYKatOb56YqMZjU6KmHoAOPIxfsHP5h/ sP+BzJi3WIs8/OlPNkgDECwy6qDdTJyUjFst4TT3D6p7myDBwNZI5tUFW7Je8689lT 6cYgXajYl/BnhvhUUO+rP2BEKaHwimP21a9JwFuI= Content-Transfer-Encoding: quoted-printable From: Wil deBeest Mime-Version: 1.0 (1.0) Message-Id: Date: Mon, 18 Apr 2022 20:02:49 +0200 X-Mailman-Approved-At: Mon, 18 Apr 2022 14:10:32 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650305483; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7hXJMI1qbYdodmv1kdxT2tHPR1rNwdxtBzJPccX4hxk=; b=WWcNt/PpT5X1sESx+tFtMa5JjrU9FUn1MmIcPOlKyjwTu64ziRmWnJ/OtQIjvZCNrqFgSm bZiS8Qda0gisaEgEwrN87SY+8VujfTGudK2NnKVY9kj7M4vUo4xR2xDJE/E6l/5GGlPiih ArQRA9afoTjHqQGzQT2YqUFk1uC9U5hcMcecgrWJnKi8fqqfQ11sNjr4rcKBJ5tai9xvIS y18N2Sa/Nr7nUWIUzNoJ3d5cXlUNPeA/mv0Eo5T3mObwpRYWvf3quB4VnE1IxL/H3b+8al Wa1jYw75ns7f0ieYC8Sxc8iD2/ErZKq4pQxNfzSg2pv6Xo9KxDdLQRYg2N9kkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650305483; a=rsa-sha256; cv=none; b=PTbpnq5auNalWqN4M4FvYPdDN8GZpHzu3xi/RggwIar67hpeGDVN2v+UMD8XCXOgaJ2+Rp JgEnmKMJn8vg5W65BkWryhHAkuPHrxHalpXGuEZ/fjQQv0Foc3EbWWFP4AHvLYKZWh17ca ran6500CjU1hyn0eR82PRTMz17o0so9DTi9bzNg2EYeyTMIIgxXnW2DAZgftpC41aQ9/lE Kc0zpZU3iKI1NR45NSz53ofEkbw5HTctqWIRlArqv0TYe9nKoemMWBs86MG3g6e2Y0ZjgJ 5nL3uGo65V964GJNVJaKbIlmk6vLqjWmmlIOzqTDbSICecwt/rS9gG/9OANwXg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=4tii.de header.s=mail header.b=vxLrHYmm; dmarc=fail reason="SPF not aligned (relaxed)" header.from=4tii.de (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.56 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=4tii.de header.s=mail header.b=vxLrHYmm; dmarc=fail reason="SPF not aligned (relaxed)" header.from=4tii.de (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 425BA40FF X-Spam-Score: 5.56 X-Migadu-Scanner: scn0.migadu.com X-TUID: K0ufFT/d6Dz+ =EF=BB=BFGreg Hogan writes: > Hi Wil, Hi Greg, thank you for the feedback! > I had recently looked at adding this package so I happen to have a few com= ments. >=20 > v1.2.6 was released last week. I had updated the package from v1.0.0 before creating the patch, but thanks to my mail server I was only able to send it the other day. > Is it preferable to "(delete 'check)" the test phase or specify the "#:tes= ts? #f" argument? I am quite new to Guix and Scheme, but `#:tests? #f' seems much better to me= . > Instead of the "replace 'install" lambda, I had done: > #:make-flags (list (string-append "PREFIX=3D" (assoc-ref %outputs "out")))= > which is both shorter and to my understanding more generic (more adaptable= to future additional binaries or libraries, though this > package will likely only ever have a single binary). That's definitely neater. I'd suggest you send your patch here to replace my hacky one, but if you prefer I could also incorporate your improvements into mine and update the version. Wil > Greg >=20 > On Sat, Apr 16, 2022 at 12:18 PM Wil deBeest wrote: >=20 > --- > gnu/packages/admin.scm | 52 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) >=20 > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm > index 1db04adf71..68f09cdbf9 100644 > --- a/gnu/packages/admin.scm > +++ b/gnu/packages/admin.scm > @@ -730,6 +730,58 @@ (define-public bpytop > memory, disks, network and processes. It's a Python port and continuation= of > @command{bashtop}.") > (license license:asl2.0))) > +(define-public btop > + (package > + (name "btop") > + (version "1.2.5") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/aristocratos/btop") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1v0lj296bzwgs29hv9z3r82fwmibiqgsvsqqh2fimxs0jmld7c2v")))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'configure) ;; not provided > + (delete 'check) ;; not provided > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append > + (assoc-ref outputs "out")"/bin"))) > + (install-file "bin/btop" bin))))))) > + (home-page "https://github.com/aristocratos/btop") > + (synopsis "Resource monitor for processor, memory, disks, network and= processes") > + (description "Resource monitor that shows usage and stats > +for processor, memory, disks, network and processes. > + > +C++ version and continuation of bashtop and bpytop. > + > +Features > + > + Easy to use, with a game inspired menu system. > + Full mouse support, all buttons with a highlighted key is clickable > + and mouse scroll works in process list and menu boxes. > + Fast and responsive UI with UP, DOWN keys process selection. > + Function for showing detailed stats for selected process. > + Ability to filter processes. > + Easy switching between sorting options. > + Tree view of processes. > + Send any signal to selected process. > + UI menu for changing all config file options. > + Auto scaling graph for network usage. > + Shows IO activity and speeds for disks > + Battery meter > + Selectable symbols for the graphs > + Custom presets > + And more... > +") > + (license license:asl2.0))) >=20 > (define-public pies > (package >=20 > base-commit: 20645d8467852990413c1ea9cf81cec82d23defd > --=20 > 2.35.1 --=20 Pascal