all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Murilo" via Bug reports for GNU Guix <bug-guix@gnu.org>
To: "Frank J. Cameron" <fjc@fastmail.net>, <75237@debbugs.gnu.org>
Subject: bug#75237: Packaging ghostty terminal
Date: Fri, 10 Jan 2025 10:49:32 -0300	[thread overview]
Message-ID: <D6YFW4BTOY56.3I5WTCTLAXAB8@disroot.org> (raw)
In-Reply-To: <472b98bc-76c7-41b6-809b-7bc18b460886@app.fastmail.com>

Hi Frank,

> error: sub-compilation of libcxx failed
>     /gnu/store/...-zig-pkgdir-xcode_frameworks-.../include/i386/_types.h:48:33: note: typedef redefinition with different types ('long long' vs 'long')
>     [...]
>     /gnu/store/...-glibc-2.39/include/bits/types.h:44:25: note: previous definition is here
>     [...]
> Build Summary: 78/81 steps succeeded; 1 failed (disable with --summary none)

I took a glance at the package definition in the link you sent, it seems to me
that this error is caused because ghostty vendors [1] various zig custom builds
[2] from the C sources within its own source repository.
What I suspect is happening (again, I didn't try building your
package definition to check, I could be wrong!) with this error is the
'unpack-dependencies phase from zig-build-system runs 'zig fetch' in all the
dependencies and thus replaces all the zig sources in the main 'build.zig.zon',
including the local vendored ones [2], thus you won't get the custom vendored
builds from the local source repository [1].

This is why I replaced [3] the 'unpack-dependencies in the %standard-phases.
This doesn't mean we absolutely cannot use 'unpack-dependencies, infact I am
trying to package it with the 'unpack-dependencies phase, but its proving to be
a bit hard to accomodate it.
The easier option would be to reimplement it and only run 'zig fetch' on the
packages that we want it to replace, but it would be best if we could use the
'unpack-dependency phase from zig-build-system for upstreaming purposes.

[1] https://github.com/ghostty-org/ghostty/tree/6ef757a8f85db7a124d370378850339a899c9e65/pkg
[2] https://github.com/ghostty-org/ghostty/blob/6ef757a8f85db7a124d370378850339a899c9e65/build.zig.zon#L46-L59
[3] https://codeberg.org/look/saayix/src/commit/b319144fbcd37ce786134cca1092946afad8393b/saayix/packages/terminals.scm#L64




  reply	other threads:[~2025-01-10 13:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-01  3:07 bug#75237: Packaging ghostty terminal boogs via Bug reports for GNU Guix
2025-01-01 13:44 ` Murilo via Bug reports for GNU Guix
2025-01-01 18:12   ` boogs via Bug reports for GNU Guix
2025-01-09 23:10 ` Frank J. Cameron
2025-01-10 13:49   ` Murilo via Bug reports for GNU Guix [this message]
2025-01-10 15:26     ` Frank J. Cameron
2025-01-10 19:00       ` Frank J. Cameron
2025-01-10 21:21   ` Frank J. Cameron
2025-01-10 14:27 ` Murilo via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D6YFW4BTOY56.3I5WTCTLAXAB8@disroot.org \
    --to=bug-guix@gnu.org \
    --cc=75237@debbugs.gnu.org \
    --cc=fjc@fastmail.net \
    --cc=murilo@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.