From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36838) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqNE7-0001Cd-FC for guix-patches@gnu.org; Wed, 24 Jul 2019 15:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqNE6-0003mc-63 for guix-patches@gnu.org; Wed, 24 Jul 2019 15:47:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57496) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqNE5-0003mM-Oz for guix-patches@gnu.org; Wed, 24 Jul 2019 15:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqNE5-00045f-Kk for guix-patches@gnu.org; Wed, 24 Jul 2019 15:47:01 -0400 Subject: [bug#36440] [PATCH] Add FreeCAD Resent-Message-ID: Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) From: John Soo In-Reply-To: Date: Wed, 24 Jul 2019 12:46:40 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190722161120.36fd0942@alma-ubu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jonathan Brielmaier Cc: 36440@debbugs.gnu.org Hi Jonathon, Thanks for your comments. I was able to apply the patches over current maste= r this morning after a fetch. There are some dependencies between the patche= s. The only thing I can think of is to make sure you apply them in order. I=E2= =80=99ll take a look and adjust to the rest of your comments in the next day= or so. Thanks again. - John > On Jul 24, 2019, at 12:52 AM, Jonathan Brielmaier wrote: >=20 > I didn't build all the packages, because it failed to apply them on top > of current master. Did you rebased it on current master? >=20 > I only comment where I "know" something... >=20 >> On 7/23/19 6:25 PM, John Soo wrote: >> ** Coin3D >>=20 >> *** DONE Delete blobs >>=20 >> *** hg-fetch deletes .hg dirs (and all submodules' .hg dirs) >=20 > - Usually the (arguments) section is right after the (build-system...) > but this is more optical :P > - Wikipedia uses https://bitbucket.org/Coin3D/coin/src but I think the > link to their wiki https://bitbucket.org/Coin3D/coin/wiki/Home is even > better :) >=20 >> ** SoQT vs. Quarter >>=20 >> *** Not interchangeable as far as I know. >>=20 >> *** FreeCAD requires SoQT specifically during configure. >=20 > Do we really need SoQT? Neither openSUSE > https://build.opensuse.org/package/show/science/FreeCAD nor ArchLinux > https://aur.archlinux.org/packages/freecad/ depending on SoQT >=20 >> ** Pyside2 >>=20 >> *** Does all of pyside2 belong in qt.scm? - there are three packages: >> Shiboken2, Pyside2, and Pyside2-Tools >=20 > qt.scm does already include python and python-xyz, so from this side > it's not a problem. If pyside* would be used by non QT projects, which > also doesn't depend on QT it would be good to have it in python-xyz > module, but I don't think that is the case. So leave them in qt.scm :) >=20 > python-shiboken-2 > Maybe leave a comment that it's a source inside of pyside-setup, because > the first repo I found was this :) > https://code.qt.io/cgit/pyside/shiboken.git/ >=20 > pyside-2-tools: > - Maybe elaborate a bit more in the description, I have no idead what > "lupdate, rcc and uic" is :P > - Is there a reason why we don't run the tests? >=20 > python-pyside-2: > - No newlines in the description after a sentence, just two whitespaces :)= >=20 >> ** libmedfile >=20 > - description: What is a MED file? >=20 >> *** Reason for old version is that what was released when I started >>=20 >> *** 4.0.0 requires hdf5 >=3D 1.10.2 >>=20 >> **** HDF5 has some dependents: >>=20 >> guix refresh --list-dependent hdf5 Building the following 11 packages wou= ld >> ensure 23 dependent packages are rebuilt: >> r-ioniser@2.8.0 r-scone@1.8.0 r-lumi@2.36.0 r-yarn@1.10.0 >> r-illuminahumanmethylationepicmanifest@0.3.0 r-scdd@1.8.0 pigx@0.0.3 >> r-pore@0.24 r-yamss@1.10.0 r-xcms@3.6.1 r-msnid@1.18.0 >=20 > 20 rebuilds is not a problem. >=20 >> **** HDF5 patches need updates when HDF5 updated to 1.10.5 >=20 > So they don't apply anymore at the moment? >=20 >> ** Using releases over hg/git downloads (please advise) >>=20 >> 1. Pyside2 packages - Done for compatibility reasons >> 2. Coin3D and SoQt - I don't think there are releases of these aside from= >> the bitbucket repository. >=20 > https://bitbucket.org/Coin3D/coin/downloads/ >=20 >> 3. LLVM propagated packages (llvm-toolchain and pyside-libcxx-headers) >> - I am not sure these are the best way to accomplish the goal anyways. >> - Not sure where to find the right sources for llvm-toolchain-6 and the >> pyside-libcxx-headers. >> 4. libarea - Seems like libarea is actually close to not even having sour= ce >> available anymore, let alone a release >> 5. libspnav - Confused as to the best source to use here. If there is a >> release or better version, I can update. >=20 > This one: > https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=3Dpa= ckages/libspnav#n13 >=20 >> 6. FreeCAD >> - I can use the releases if they exist. I do not think they have source >> tarballs available. >> - I was packaging during a lot of active development of FreeCAD >>=20 >> Thank you for your review and advice. >=20 > That's it from me at the moment. Strong work! Keep it up :) > ~Jonathan