From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id qAzzBzJQcGYGVwAAqHPOHw:P1 (envelope-from ) for ; Mon, 17 Jun 2024 15:03:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id qAzzBzJQcGYGVwAAqHPOHw (envelope-from ) for ; Mon, 17 Jun 2024 17:03:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=inria.fr header.s=dc header.b=b6gnc2Iv; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=inria.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718636594; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=NvVk3Du14GnuIgxaejjBPT4CGvJayyhs2Q59Uufh9O4=; b=n/zC56BUt44iKWKH/Ms6MV/IUfS4Oy4pDMmgmKP6ATrkqq9K++Q8/ZtZ8QpATQasnPdECF 3IWD6orGXa+X9U8FSBba+zRSkZ/qN+6sM3YV1Nq3Cxau+lVZCuksA/09MYHIGwGcMEn4Hf wwrSrvz7h+nzxdZWGKU+EYA5zNQ5iKSQCj51l4cZ0k8w+kreQ5BfIc6bUojlRfVUTDz0v6 x7uAeyFtZZEo/FfPnGX9ejUNxYnj1lfv9LiVBUOcqPWx0+QzVaGkd+HDjxRO0tyTmEM7n9 tKP6dUw2tYdqsC2NIDoFgp6yLdkXpWLB/Epoc7MvqwCELmoFC+LPneFks7lKXA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=inria.fr header.s=dc header.b=b6gnc2Iv; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=inria.fr ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718636594; a=rsa-sha256; cv=none; b=SLm641bIrIEn72DmWCfGN1ybeOnySaIf/cDx+YnJbNCbnElJ1qauQq1E3SLtHNYJxKRXj+ 5O/1yP8n5IMCOSmHu0u+xKDEm3Mx1j0lzFxcFCwO0ZxcXyiiURWH5sMeCk0v+A1xRaIsYC 06Yl7u/stjP/ugAMHUo8oz1/W9iszkCpsQt5K4S9kUfLQsVtAT/SdcV2g4onnm6S/v8hEt k0g1wJ7JrR5sH3+ReY1qLnl1Js4jiDFAxK2tocOa+mcZWCR1NTrSwr1jsvdGnyKGUY23Qa NtxJJXN7OHgFvATTlsKzYh5JGFEM3lIFcoguHSBvMci5EhQf5P/vIsztEsr/Ow== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0520E69B19 for ; Mon, 17 Jun 2024 17:03:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJDsH-0006Dg-0Z; Mon, 17 Jun 2024 11:02:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJDsC-0006Bx-Aj for guix-devel@gnu.org; Mon, 17 Jun 2024 11:02:20 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJDs2-0002MT-NG for guix-devel@gnu.org; Mon, 17 Jun 2024 11:02:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=mime-version:content-transfer-encoding:date:message-id: cc:subject:from:to:references:in-reply-to; bh=NvVk3Du14GnuIgxaejjBPT4CGvJayyhs2Q59Uufh9O4=; b=b6gnc2Ivjn4du7IxkALYVyWLM/o+y7tU6xfj0H0VJavMPiUk1SzjoqCN oe3pHVMse93XeoefGi9M2E7MM9kHr2sCG9mD27GYv7jz6esfuQHwYhLoy Zdvi4ofWUcicXNTpsS58Mirnqbj4SjHBr7dojzEYalzP1ZJsRYWD40zmv 8=; X-IronPort-AV: E=Sophos;i="6.08,244,1712613600"; d="scan'208";a="89905733" Received: from unknown (HELO localhost) ([193.50.110.191]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2024 17:02:07 +0200 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 17 Jun 2024 17:02:06 +0200 Message-Id: Cc: Subject: Re: [PATCH Cuirass] cuirass: Fix handling of SPECIFICATION-NAME. From: "Romain GARBAGE" To: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Mailer: aerc 0.15.2 References: <20240617124425.8410-1-romain.garbage@inria.fr> <8734pb7kiw.fsf@inria.fr> In-Reply-To: <8734pb7kiw.fsf@inria.fr> Received-SPF: pass client-ip=192.134.164.104; envelope-from=romain.garbage@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -10.86 X-Migadu-Queue-Id: 0520E69B19 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -10.86 X-TUID: mCtO6YCjTZi/ On Mon Jun 17, 2024 at 3:42 PM CEST, Ludovic Court=C3=A8s wrote: > Hi! Hi Ludo' ! > Romain GARBAGE skribis: > > [...] > > * src/cuirass/base.scm: Handle SPECIFICATION-NAME as a symbol. > > * src/cuirass/http.scm: Handle SPECIFICATION-NAME as a symbol. > > * src/cuirass/templates.scm: Fix template generation. > > Bonus points if you can mention the affected procedures in the message > above (I can do it for you otherwise). Will fix in v2. > I tested it locally following the instructions from =E2=80=98README=E2=80= =99. One case > where we still get a type error is when triggering evaluation through > the web interface: > > wget --post-data=3D"" -O/dev/null \ > http://localhost:8080/jobset/random/hook/evaluate > > This leads to this backtrace in =E2=80=98cuirass web=E2=80=99: > > --8<---------------cut here---------------start------------->8--- > In cuirass/http.scm: > 1408:46 1 (url-handler # _ _) > In ice-9/boot-9.scm: > 1685:16 0 (raise-exception _ #:continuable? _) > In procedure string->symbol: Wrong type argument in position 1 (expecting= string): random > --8<---------------cut here---------------end--------------->8--- > > Note that this in turn causes communication with =E2=80=98cuirass registe= r=E2=80=99 over > the =E2=80=9Cbridge=E2=80=9D, so there could be other issues there. IIRC I saw that the register part properly handles the symbols. I made some changes and checked locally, this case seems to be handled correctly in v2. Romain